Looks good.
I think the problem was, that at the point where $mbox had been assigned via get_input_value, the current POST-Reuqest already had "INBOX" as destination mailbox (because of the periodic mail-check). So when $mbox is assigned in the if-statement, the variable-scope prevents it from being change till the clear_mailbox command.
Regards, Micha.
-----Ursprüngliche Nachricht----- Von: Jason Williams [mailto:jasonw@cs.jhu.edu] Gesendet: Dienstag, 8. Januar 2008 16:24 An: dev Betreff: Re: [RCD] Critical Bug empty's Inbox
FYI I had a quick look at this, since I use RoundCube as the webmail client here, and well, I put together a quick fix and rolled it into a patch. I attached it to the bug in trac, but for redundancy's sake, I'll post it here too.
> There is a critical Bug in Roundcube that empty's the users mailbox > when emptying the trash folder... >
> http://trac.roundcube.net/ticket/1484449 "empty kills mailbox" > http://roundcubeforum.net/forum/index.php?topic=2195.new;topicseen#new Empty Trash empties INBOX >
> We also figured out that this always happen's when the user clicks on > the button empty trash and at the same time the automatic refresh of > the inbox is happen, the inbox is also empty. > Maybe it's the same Problem described in: >
> http://trac.roundcube.net/ticket/1484678 Method session_start with > custom session handlers is not thread-safe >
> I hope we can discuss some solutions, because we can't fix this issue > by ourselves... >
> thx Stefan > _______________________________________________ > List info: http://lists.roundcube.net/dev/ --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/7Q/aSY6mvDu/inbox_delete_fix.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/