On 11/14/12 06:58, Jonas Meurer wrote:
Am 14.11.2012 15:01, schrieb Thomas Bruederli:
On Wed, Nov 14, 2012 at 10:51 AM, Thomas Bruederli thomas@roundcube.net wrote:
Hello folks,
We kind of made it a tradition in Roundcube to add some nasty bugs with every second release we publish :-)
This time a pull request accidentally was merged into the release branch instead of git-master where we usually do the testing. The effect of this bug is the compose screen randomly reloading and likely loosing the contents you're writing. There's a patch you can download [1] and apply to any 0.8.3 installation.
I'm sorry, I forgot to mention how exactly to apply the patch to the release package. You first have to restore source file, then patch it and afterwards re-create the minified version of app.js again:
$ bin/jsunshrink.sh $ patch -p1 < roundcubemail_0.8.3_compose_reload_fix.diff $ bin/jsshrink.sh
argh, every mail from you makes it worse :-/
A short notice that bin/jsshrink requires a java runtime enviroment installed on the system would have been very helpful. Now I've unshrinked javascript files and no option to reshrink them. I'll do the required work on development systems in future.
This mail isn't meant offensive. Quite the opposite, I'm impressed by the high quality of roundcube and your work so far. Human errors are normal, not a big problem at all. But you might want to add more verbose documentation to your announcements in the future, that would be highly appreciated.
Keep up the great work!
Best regards, jonas
I don't have java runtime on my production box either, but I routinely shrink javascripts at http://closure-compiler.appspot.com/home
-- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________