Hi Eric,
I absolutely agree with your suggestion. Your sorting class seems to do a better job than iil_SortHeaders does. Unfortunately I didn't read your patch first and just looked for my faults because sorting once worked in RoundCube. I will add your patch to the Trunk and replace the old sorting behavior.
Thanks a lot! Thomas
2006/7/26, Eric Stadtherr estadtherr@gmail.com:
- Zitierten Text ausblenden -
Thomas,
That's essentially what I did in my fix - use the sequence returned by the IMAP SORT command to re-order the list returned by the FETCH command.
The only problem with using iil_SortHeaders to sort the fetched list is that it implements its own sorting algorithm, ignoring the sequence returned by the SORT command. The algorithm probably produces the same results, but why tell the IMAP server to sort the list and then throw away the results? I think we need to choose one or the other - tell the IMAP server to sort the list, or execute our own sorting algorithm. I vote for letting the IMAP server do the sort - this automatically gives us support for any future IMAP sorting behavior without having to maintain our own algorithms.
Thoughts?