Thanks for your assistance, Harold and Fahrzin.
I've developed the patch and have attached it to this message (let me know if there's someplace else I should send it instead).
A few concerns:
- The search() method in rcube_contacts.inc; I think while testing this
patch, I think I found a glitch in it. If you have a contact in your
address book
and you delete it by mistake, then try to add the same contact again, it
will see it as a
duplicate and won't let you add it. This is because the search() method
searches all contacts, even those with the del flag set. Should I try to
fix this, or just file a bug report? Does anybody more familiar with the
source know if it will break anything if I make it only search records not
deleted? Or maybe when instructed to add a duplicate contact, Roundcube
should simply turn off the 'del' flag if it's set?
- I didn't know the best way to get the raw email address from the
$MESSAGE headers, so I wrote a simple method that uses preg_match to extract it. If there's a better way, please let me know and I'll update my patch.
- Caching causes a bit of a glitch in my patch. If you click a message
with remote objects, click Always display, it will add the sender to the address book and display the images. If you go right back to the message however it will show the cached version so you have to Shift-Reload or it will appear it was unsuccessful. I'd be grateful if anybody knows a way around this.
- As I'm monolinguistic, I've only added the message for it
($messages['alwaysshow']) to the en_US locale, so it won't display properly if your locale is different. Sorry.
Let me know what you think.
Thanks, Ben
On Mon, 8 Oct 2007 23:12:20 +0200, Harold Aling h.aling@home.nl wrote:
On Mon, 8 Oct 2007 15:57:12 -0400, Ben ben@forlent.com wrote:
to start by writing a patch that allows you to "always display" images
in
messages from specific senders, so you don't have to click "display images" each time you open their message.
Being kind of new to this, my questions are as follows:
- is anybody already working on this feature?
Check the bug reports/feature requests on trac...
- If I do develop it, would it likely be added to the project?
If it's well written, modulair and easy to implement: sure...
- How would I go about implementing it? Just download the SVN and patch
it? Then do I send this list the patched files or just the snippets I modified or something else?
I believe that's the best way to do it. It'll probably won't make it into 1.0, so I'd guess writing it against SVN would give you the best base...
- From a technical standpoint, what would be the best way to store the
whitelist of email senders? Flatfile, new database table, or in the address book?
I'd go for the addressbook option. Email addresses which are stored in
the
addressbook are in my case always trusted...
Thanks, Ben
Good luck!
-H-
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/mW/maW5sP0T/display_images.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/