Michael Heydekamp wrote:
Am 14.11.2012 09:32, schrieb Thomas Bruederli:
Michael Heydekamp wrote:
Well, THAT's a good and sense making feature, my compliments.
Two comments:
- It would IMHO be a good idea to indicate in some way that the images
displayed below the message are just thumbnails. I wasn't aware of this feature yesterday evening, received a mail with some pics, and was surprised that the sender did shrink them to such a small size (which I would even have preferred)... ;)
OK, I thought it's somehow obvious that images of this size are thumbnails... Any concrete suggestions how to visualize that better?
Just displaying the text "Thumbnail" (well, how would you translate this into German ;) ?) somewhere above/below the picture...? In contradiction to A.L.E.C's post, the size is OK to me, as in most cases this relatively large thumbnail size would often not even lead me to display/load the picture in full size at all. This is pretty convenient, IMHO.
First of all, the size of the thumbnails is configurable through the 'image_thumbnail_size' option.
- Is it planned to provide a second link (next to the "Download" link),
which simply displays the image - full size or fit-to-screen, and probably in a new window - within Roundcube? We know from the past that Roundcube can do that. ;-) That would at least be much more convenient rather than downloading the image and then loading it into the local app being associated to this file type on this particular system - if such an app is available at all (think of Internet Cafés and such).
You can click on the thumbnail itself to open up the full size image. Mabye an additional link "Show" next to "Download" would fix this.
And I just added these explicit links to "Show" an image attachments right next to the "Download" links.
Probably. It depends what the link exactly would do - show it WITHIN Roundcube (i.e. the browser) or launch a local app?
At least it currently doesn't work the way you're describing in IE8/Win7. I can click on the thumbnail, but instead of opening up the full size image within Roundcube or the browser, I'm getting a dialogue "Möchten Sie diese Datei öffnen oder speichern?" ("Do you want to open or save this file?"). If I click on "Öffnen" (= Open), then the image is loaded into the "Windows-Fotoanzeige" - and this is exactly what I would like to avoid, as this is an app on the local machine.
By default, Roundcube opens attachment types known that browsers can display them (e.g. image/jpeg, text/plain, etc.) in a new browser window but doesn't send them to be downloaded. The default list of mimetypes can be overwritten in you local config. Check option 'client_mimetypes'. If it's set to null, then the default list applies.
Is this behaviour different elsewhere...?
Yes, in my browser :-)
But I had a closer look at it with IE9 on Win7 and indeed found out a totally weird behavior there, which caused all attachments to be downloaded directly: the list of supported mimetypes, which is passed to the browser as array mimetypes:["text/plain",...] is, for some reason only Microsoft knows, treated as an object here. So .indexOf() didn't work as expected.
That's really a bummer! I didn't find out why IE randomly treats array syntax as Object instead of Array. I workarounded it in https://github.com/roundcube/roundcubemail/commit/54cc75f28d75d01eb10c0be51e...
And you can still open the image by clicking the file name in the regular attachment listing. This still does and has always been opening images in a new window.
Yes and no. It does bring up exactly the same dialogue as described above, so a local app will afterwards be launched if I click on "Open".
Right, because it's exactly the same procedure called. And that also applies for the new "Show" links.
I never saw that clicking on an image attachment does show it WITHOUT loading it into a local app.
That should be solved now with the fix for IE described above.
But anyway, good job and thanks again!
Thanks a lot!
Regards, Thomas