On Fri, Jan 2, 2009 at 3:27 PM, A.L.E.C alec@alec.pl wrote:
Jonas Nasholm wrote:
Hi,
I would like to propose a modification of "iniset.php" to eliminate possible "Undefined index: HTTPS" notices in the error log.
Thanks, Jonas.
The existence of $_SERVER['HTTPS'] should be tested before any attempt to retrieve its value. We currently use the following solution:
isset($_SERVER['HTTPS']) ? ini_set('session.cookie_secure', ($_SERVER['HTTPS'] && ($_SERVER['HTTPS'] != 'off'))) : ini_set('session.cookie_secure', 0);
The proposed modification is attached as a patch file.
Thanks, but we just need to move upper the line: ini_set('error_reporting', E_ALL&~E_NOTICE);
We need to fix it. Instead of hiding it since most of those errors are being handled more strict in later PHP versions. Besides, a side effect is cleaner and more robust code.
http://trac.roundcube.net/changeset/2211/trunk/roundcubemail/program
Happy new year, Till
Till _______________________________________________ List info: http://lists.roundcube.net/dev/