Hi Vincent
Thanks for your contribution! So far we've applied the fix for empty e-mail addresses in autocompletion to SVN trunk. As you might have seen in trunk, the address book meanwhile has more fields that can form the display name. Therefore your modifications about first/last name sorting don't fit perfectly and we didn't add them to our codebase. I'm also wondering why sorting in autocompletion should differ from sorting in the address book listing. In the latter case the list is sorted by the entire display name string which is by default composed from prefix + first + middle + last + suffix. I guess we should look for a solution that generally influences the display name composing/display and sorting.
Best regards, Thomas
2011/6/9 Vincent BOURDEIX vbourdeix@linagora.com:
Hi everyone,
Today I propose you 4 small patches which I needed for a client. I generated them with git which explains the numbers in the patches names.
These four patches do the following :
- Add of a french translation for a preference setting (default addressbook)
- Add of a user's preference to be able to display a contact's lastname
before his firstname in autocompletion when composing an email.
- Small bug fix where a contact with an empty email was displayed at
autocompletion
- Add of a user's preference to be able to sort contacts on their lastname
in emails autocompletion
Have a good day.
Vincent BOURDEIX
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/8S/gqbypSSE/0006-Modification-to.patch http://detached.gigo.com/rc/8S/gqbypSSE/0002-Add-of-a-transl.patch http://detached.gigo.com/rc/8S/gqbypSSE/0004-Add-setting-to-.patch http://detached.gigo.com/rc/8S/gqbypSSE/0005-Modification-to.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/ BT/0ddf6350
List info: http://lists.roundcube.net/dev/ BT/aba52c80