till wrote:
2008/2/29 t.pajor@kei.pl:
On Fri, Feb 29, 2008 at 11:31 AM, Michael Baierl mail@mbaierl.com wrote:
Maximilien Cuony [The_Glu] wrote:
- Notice: Undefined index: _step in
/var/www/webmail/tmp/trunk/roundcubemail/installer/rcube_install.php on line 39
These are just noticies so I think they are fine in there - notices should be disabled anyways - if you code around undefined index notices it will make your life much harder and your code even more unreadable.
I'll disable notices using ini_set()...
i don't think that turning notices of is a good thing, we need to have a good code, not error_reporting(E_ALL ^ E_NOTICE);
I agree. They should be fixed and not hidden!
Notices IMO just destroy the very nice advantages of PHP. They're good for development but don't expect all (of my) code to be notice-free. Especially if you make use of third party libraries (as we do), you cannot guarantee that all code is notice free.
The fact that the PHP interpreter doesn't care about inexisting indexes and undeclared variables is one of the reasons why I like PHP.
I agree that there shouldn't be any notices in the installer but many people who install scripts like RoundCube have no idea about PHP and they maybe have notices on. To avoid unnecessary complains and bug reports that aren't really bugs I still vote to disable notices within the installer.
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/