Hi,

I want to start develop for Roundcube. Just for training and my personal use, I make this changement: when you add a contact, the name to show is auto completed by the firstname and surname field.

If you think it could be usefull add it in the svn. I want to add some infos in address book like phone number, address .... Like in thunderbird.

Where is the better place to show the database changement? Or do i have to work on others things?

Fred

svn diff output

Index: roundcubemail/program/steps/addressbook/edit.inc

--- roundcubemail/program/steps/addressbook/edit.inc (revision 540) +++ roundcubemail/program/steps/addressbook/edit.inc (working copy) @@ -1,4 +1,4 @@ -<?php +<?php

/* +-----------------------------------------------------------------------+ @@ -65,17 +65,20 @@ // return the complete address edit form as table $out = "$form_start<table>\n\n";

• $a_show_cols = array('name', 'firstname', 'surname', 'email');

• $a_show_cols = array('firstname', 'surname', 'name', 'email'); foreach ($a_show_cols as $col) { $attrib['id'] = 'rcmfd_'.$col;

•   if($col == 'firstname' || $col == 'surname')
  

•           $attrib['onkeyup'] = 'rcmfd_name.value=rcmfd_surname.value +
  

' ' +rcmfd_firstname.value;"'; $title = rcube_label($col); $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib); $out .= sprintf("<tr><td class="title"><label for="%s">%s</label></td><td>%s</td></tr>\n", $attrib['id'], $title, $value);

• }

• unset($attrib['onkeyup']);

•   }
  
  

  $out .= "\n</table>$form_end";