Re: [RCD] New password plugin driver - vpopmaild

Johannes,

Your driver was revised and commited to trunk: http://trac.roundcube.net/changeset/2973

Thank you.

-- Victor Benincasa

On Sun, Sep 20, 2009 at 6:08 AM, Johannes Hessellund <johannes@shiningsun.dk

wrote:

Hi Victor

You're right. And the line with the slogin should properly return 'PASSWORD_ERROR' as that's were the password is verified.

The section should be:

$result = $vpopmaild->readLine(); if(!preg_match('/^+OK/', $result)) { $vpopmaild->disconnect(); return PASSWORD_CONNECT_ERROR; } else { $vpopmaild->writeLine("slogin ". $_SESSION['username'] . " " . $curpass); $result = $vpopmaild->readLine(); if(!preg_match('/^+OK/', $result) ) { $vpopmaild->disconnect(); return PASSWORD_ERROR;

/Johannes

Victor Benincasa skrev:

...

Hi Johannes,

I'm reviewing your driver, thanks for sending it.

What do you think about returning 'PASSWORD_CONNECT_ERROR' instead of 'PASSWORD_ERROR' on the following check (because it is in the connection phase)?

   $result = $vpopmaild->readLine();
   if(!preg_match('/^\+OK/', $result)) {
       $vpopmaild->disconnect();
       return PASSWORD_ERROR;

-- Victor Benincasa

On Sat, Sep 19, 2009 at 2:53 PM, Johannes Hessellund < johannes@shiningsun.dk mailto:johannes@shiningsun.dk> wrote:

I use qmail with vpopmail as mail-server.

vpopmaild can be used to change password among other things. Using vpopmaild in a vpopmail enviroment, lets vpopmail take care of database backend. And vpopmail-server and webmail-server can be separated.

I have attached a vpopmaild driver to use with the password plugin. 'vpopmaild.php'. It is based on vpoppassd.php!

Also included are the new config.inc.

I added to config.inc this:

$rcmail_config['password_driver'] = 'vpopmaild';

// vpopmaild Driver options // ----------------------- // The host which changes the password $rcmail_config['password_vpopmaild_host'] = 'localhost';

// TCP port used for vpopmaild connections $rcmail_config['password_vpopmaild_port'] = 89;

Please review, and commit it to the svn.

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Y3/3h1glqMU/vpopmaild.php http://detached.gigo.com/rc/Y3/3h1glqMU/config.inc.php Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---

---

List info: http://lists.roundcube.net/dev/