On 11/16/2012 08:11 AM, Daniel Kahn Gillmor wrote:
It looks to me like it was fixed for drafts and sent messages, but it was *not* fixed for deleted messages. I can't seem to convince http://trac.roundcube.net/ to let me have an account, but i think that ticket should be re-opened.
I think the attached patch fixes the situation for the trash (as well as fixing any other attempt to move into a folder that doesn't exist).
There's a logic in rcube_imap::move_message() which creates a destination folder if it doesn't exist but only for default (special) folders. Doesn't it work for you? According to your patch, now we'd have redundant check for folder existence.
I think we shouldn't do this for non-special folders.
Arguably, you might also want to subscribe to the newly-created folder, and not just create it; but as a baseline, i think this is a reasonable patch against v0.8.4.
It also subscribes to such folder.