Re: [RCD] rcube_imap_generic readLine issues

On 12.07.2010 23:32, Brad Davidson wrote:

The problem here is that there are LOTS of places in the rcube_imap_generic code (old ilohamail, I know) that run in a DO...WHILE loop around readLine and don't ever check to see if it's returning NULL. I know that this is intended to loop around possible untagged IMAP replies until the desired response line is found, but there needs to be some code to break out of the loop if a NULL is encountered.

There are so many places that this would need to be fixed that I'm not really sure where to start, or even if my patch would be accepted.

I've reviewed the code again. I've made some fixes in r3958 and now I don't see more places with infinite loop possibility. Get as to know if you find some.