On 14 Jul, 2008, at 2:50 PM, till wrote:
On Mon, Jul 14, 2008 at 3:42 AM, Amitai Schlair
schmonz@schmonz.com wrote:On Jul 13, 2008, at 7:55 PM, till wrote:
But being productive I suggest that instead of an env variable
(which setting is so system specific etc.), I think we could implement a constant in index.php which would direct the code to the location of the configuration files. If empty, fall back on "local" (which is roundcube/config/).This could be overwritten/replaced with a simple sed by a package maintainer if he thinks this is absolutely necessary.
Sure, that sounds great to me. I came up with my patch because I wanted to be able to set the path in one place without knowing much about RoundCube; if index.php is a better place, then yes please. :-)
Yeah, I totally see where you are coming from. If you want to revise your patch, that would be a great help. Then attach it to a ticket and let me know, I'll get to it. :)
Might you (or another committer) have a chance soonish? It'd make my
life (as both a sysadmin and a packager) much easier if the upcoming
beta came with the patch in #1485215 already applied, and it's a low-
impact change that's easy to test.
Thanks,
- Amitai
List info: http://lists.roundcube.net/dev/