Hi all,
Here is another patch to message list.
It adds column with Junk/NonJunk IMAP flag to a message list. Everything is done in a thunderbird-like manner.
Known issues:
- Hook needs to be added to "mark_as_junk"/"mark_as_non_junk" actions
(report message to SpamAssassin, move it to a 'Junk' folder functionality, etc. should be moved to plugins). 2) Thunderbird actually uses two flags, "Junk" and "NonJunk". For now, message without any of these flags is shown as NonJunk (without any icon), but such message is not shown when one chooses an "Only Not Junk" filter. I'm unsure how to implement full support for two flags with only one icon (make it a three-state?). The only way to mark message as a NonJunk is to mark it as Junk before (in sieve or manually). 3) "Junk" and "NonJunk" are nonstandard user flags, but I hardcoded them into code for simplicity (as user flags handling is not done yet in a roundcube core). 4) I'm not aware of other MUA's, how do they mark messages. If it differs, then compatibility type should be introduced, and it should be made an user-definable option. 5) Icons are stolen from thunderbird and a bit crappy on a red background when message is selected. 6) This revision of patch applies only on a top of threaded view patch I sent in a previous e-mail. Actually, they touch code in a same places, and it is quite hard to keep changes in sync between thread-aware and unaware versions, so I work only with a former one.
Current code works stable, but polishing is needed (I'm about IMAP flags).
Comments are welcome,
Best, Vladislav
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/yQ/Pn6TafGf/roundcubemail-0.3-ju.patch http://detached.gigo.com/rc/yQ/Pn6TafGf/junk.png http://detached.gigo.com/rc/yQ/Pn6TafGf/nonjunk.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/