-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

> 2) Better create this against devel-vnext to make use of autoloading etc..

Ok. I have to finish some things before, but I will do it :).

For a demo, it's can only be on my local server so.. not relay possible, but if you want I can do it... (but it's will be online only ~07:00-~22:00 GMT+1)

Here are some screens :

Filter's list : http://pix.nofrag.com/4/4/9/4d23379e4e40222777c9bd5b7db89.html
Editing a filter : http://pix.nofrag.com/3/4/9/759cd88e87f8d2fbb3aae55749fa4.html

Regards,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://firegpg.tuxfamily.org

iD8DBQFG+1rsjKKs5/FTCjURAs/wAJ9NLUi2yPnWWgBcHAxG6T3id8nZgACgm//F
L+kkpoI0prSuN982yRts/U8=
=46+r
-----END PGP SIGNATURE-----


On 9/27/07, till <klimpong@gmail.com> wrote:
Hey Maximilien,

On 9/14/07, Maximilien Cuony <maxi.the.glu@gmail.com> wrote:
> Here is my first patch for my filter's system.
>
> I separate my filter system (named mc_filters) from the filter's interface.
>
> In lib/Filters are the different classes for filter's system (for the moment
> only mc_filters and the base class).Filter's system used are stored in the
> main.inc.php.
>
> So.. I'm open to all your remarks, like horribles English's mistakes ;).
>
> The code is a bit ugly for the moment (I try to not edit your base files and
> the CSS so I re-use for ex. the classes for another pages for settings) ^^,
> but I will correct this later.
>
> All is based on the revision 740 of the trunk.
>
> What do you think about it ? What I have to change ?

Well, basically here is some feedback:

1) Use your own classes, don't add your code to "core" files.
2) Better create this against devel-vnext to make use of autoloading etc..

I couldn't try it yet and won't be able to do so soon - got a working
demo or screens?

Till



--
(  o  _    Maximilien Cuony [The glu]
/ /  \       Mon Blog : http://theglu.tuxfamily.org
V_ /_     www.archlinux.org www.getfirefox.com
Ce mail est signé numériquement avec FireGPG.
Clé publique : http://theglu.tuxfamily.org/public/cle.pgp