> "Roundcube, code proudly cleant by argumenting trolls"
For what it's worth, I found it pretty funny, so: I'll take it! ;-)
> For that specific "entire content of a function" case I mentioned the exceptions that allow returns at the beginning of a function that check preconditions.
True, and that is indeed a good example that you're citing. I still think my version is easier to understand, but hey - I did the work on it, so it might as well just be confirmation bias ;-)
Would you propose resetting the entire function or is there another approach that could incorporate my changes. I'm mostly trying to find the best way of dealing with things like this in general - I think we might need a couple iterations like the one we have now until I can auto-pilot changes as close as possible to what we agree on here. It also means that there are potentially a couple of other situations that you might want to weigh in on - although so far, most of the code has been rather tame in terms of function and if/else statement length.