hi,
applied both - looks good.
cheers, raoul
On Sat, 2008-01-26 at 14:30 +0100, Maximilien Cuony[The_Glu] wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
I make two small patches to correct two smalls problems :
First, When we got a new mail, the title of the page change (the number of new mails is showed). But if we click to set a message as read, or delete it, the title counter is not updated.
So !
- When a message is moved or deleted, the counter is updated [only for
inbox)
- When a message is read/unread on the list, the counter is updated [only
for inbox]
- If you access roundcube with an url like ?_task=mail&_mbox=INBOX,
counter is updated (only for inbox)
- If you read a message and return to the list, the counter is updated
- We you read a message, the counter is updated too (counter is here when
you read the message). I don't know if it's a good idea, but is hard to disable this (it's possible, but it's mean a lot of changes)
- If you navigate between folders and go to inbox, the counter is
updated.
- When a new message is received, the title is updated, only for inbox !
(I think this feature for trash is not very useful ;) )
It's fix http://trac.roundcube.net/ticket/1484650 :)
Second :
We you click on a list, and re-click later on the same row, the row is showed as selected, but not in the interface (for example in the mail list button for actions (replay...) switch to disables)
I didn't really found the problem in the code, but I find a way to fix the problem. I tested the lists with my edit, and I don't see any changes in they comportment, so I think it's ok.
All patches are based on the trunk, lasted revision. I hope you will patch the trunk if there is no problems :)
Regards,
Maximilien Cuony [The_Glu] http://theglu.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) Comment: http://firegpg.tuxfamily.org
iEYEARECAAYFAkebNgoACgkQjKKs5/FTCjUYJgCfaoNMSYcPgGOmAyWlgrBiGfGt XDEAniLuQJva9R+hmctKwr5yoQlZwwve =dm/6 -----END PGP SIGNATURE-----
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/pf/7yJFnqq1/patch1-unreadcounter.txt http://detached.gigo.com/rc/pf/7yJFnqq1/patch2-long-double-c.txt Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/