Hi Robin,
Thanks a lot for your efforts on this RoundCube feature. Let me just add my 2 cents...
I guess the preview box is something that is defined and styled by the skin. This implies that it's position and it's size is completely controlled by the skin. The only thing the app.js should do is to check whether there is a container to display the preview or not. I don't like the behavior that the message list is cropped to half size when you first click a message. Either the preview pane is available (again, it's the skin that enables it) or it isn't at all.
As already mentioned, the preview pane should not be controlled by the application but only by the skin. This also means, the there should not be any configuration parameters related to the preview pane. If your skin does not provide it, what's the configuration parameter for? At least, that's something your users may ask.
Please don't get me wrong. I like what you've done so far, but I just like to keep things separated and not mashed up.
Regards, Thomas
Robin Elfrink wrote:
Robin Elfrink wrote:
Now for Internet Explorer to break long lines, didn't even see that before, was too busy resizing <div>s ...
A simple <pre> did the trick.
I've put up my patch for preview pane support in the trac system, ticket number 1484008.
http://trac.roundcube.net/trac.cgi/ticket/1484008
Robin