8 Oct
2009
8 Oct
'09
7:34 a.m.
- You're fetching text message body twice for checking if inline
message/part is signed/encrypted. This is of course not good for performance, you should store fetched body in memory for further use (e.g. by extending get_part_content function). It will be used probably once again in plugin and again for message displaying.
Mmmm... But what about memory usage? Encrypted/signed message could be rather big. And we could hit PHP memory limit easily. I'd prefer some kind of stream-operating parser/detector therefore.
Vladislav
List info: http://lists.roundcube.net/dev/