Ian Lewis wrote:
Hi - not sure where 'potential bugs' in Larry should be reported but here's hijacking this thread (writing this with Larry now)...
- I have the Larry 'reply all' button working on the top (taskbar?)
set of 'mail' options, but not on the reply-all button in the 'mail preview' window. It's possible I broke it by modding other bits of apps.js - I don't think so though.
That was indeed a typo in the skin template. Fixed in r5955.
- The contacts list enabling code in apps.js has been moved (copied)
out of the 'addressbook' task section into the 'mail'/'compose' task/action section. It would be more useful (to me...) if it was just moved into the 'mail' task section of apps.js still using the 'if (this.gui_objects.contactslist) {' control flow, i.e. check for the gui object but not the 'compose' action. This doesn't affect Larry.
Done in r5956
- The new contacts list code in the 'mail' task is using internal
names such as 'adressbookslist' and 'list-adresses' i.e. 'adress' is mis-spelt in English. Existing functions in Roundcube correctly spell the (English) 'address' part of the names. There is not a potential name clash (I've searched all files) and I suggest those new 'adress' names could be globally re-spelt 'address' to minimise future errors.
Typos corrected in r5955.
~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80