Hi,
I just added your tab-index patch to the current CVS version.
Thanks! Thomas
remmelt@remmelt.com wrote:
Hello all!
First a quick introduction: longtime PHP/MySQL dev, mainly on CMS's. Living in Berlin with girlfriend and cat, orignally from the Netherlands. I play guitar and I make my own effectpedals once in a while, mostly overdrives, distortions and fuzzes.
Fed up with that gmail looks so much better than squirrelmail! I'd love to be able to use a production-ready roundcube, and thought you could use some help.
I like to <tab> to the next field when I'm writing mail. When I do that now, it goes over the Cc and Bcc fields, which is kind of annoying. I noticed that tabindex wasn't an allowed parameter in the compose skin's object call, so I added it. Below is the patch. If there is a preferred way of sending patches, please let me know!
Thanks for a great product!
Remmelt
<patch>
=================================================================== RCS file: /cvsroot/roundcubemail/roundcubemail/program/steps/mail/compose.inc,v retrieving revision 1.7 diff -r1.7 compose.inc 86c86
< if (in_array($attr, array('id', 'class', 'style', 'size')))
if (in_array($attr, array('id', 'class', 'style', 'size','tabindex'))) 149c149 < $allow_attrib = array('id', 'class', 'style', 'cols', 'rows', 'wrap');
$allow_attrib = array('id', 'class', 'style', 'cols', 'rows','wrap', 'tabindex'); 156c156
< $allow_attrib = array('id', 'class', 'style', 'size');
$allow_attrib = array('id', 'class', 'style', 'size', 'tabindex');Index: roundcubemail/skins/default/templates/compose.html
RCS file: /cvsroot/roundcubemail/roundcubemail/skins/default/templates/compose.html,v retrieving revision 1.4 diff -r1.4 compose.html 51c51
< <td><roundcube:object name="composeHeaders" part="from" form="form" /></td>
<td><roundcube:object name="composeHeaders" part="from" form="form"
tabindex="1" /></td> 56c56 < <td><roundcube:object name="composeHeaders" part="to" form="form" cols="80" rows="2" /></td>
<td><roundcube:object name="composeHeaders" part="to" form="form"
cols="8" rows="2" tabindex="2" /></td> 63c63 < <td><roundcube:object name="composeHeaders" part="cc" form="form" cols="80" rows="2" /></td>
<td><roundcube:object name="composeHeaders" part="cc" form="form"
cols="80" rows="2" tabindex="3" /></td> 68c68 < <td><roundcube:object name="composeHeaders" part="bcc" form="form" cols="80" rows="2" /></td>
<td><roundcube:object name="composeHeaders" part="bcc" form="form"
cols="80" rows="2" tabindex="4" /></td> 73c73 < <td><roundcube:object name="composeHeaders" part="replyto" form="form" size="80" /></td>
<td><roundcube:object name="composeHeaders" part="replyto" form="form"
size="80" tabindex="5" /></td> 82c82 < <td><roundcube:object name="composeSubject" id="compose-subject" form="form" /></td>
<td><roundcube:object name="composeSubject" id="compose-subject"
form="form" tabindex="6" /></td> 91c91 < <roundcube:object name="composeBody" id="compose-body" form="form" cols="80" rows="20" warp="virtual" />
<roundcube:object name="composeBody" id="compose-body" form="form"
cols="80" rows="20" warp="virtual" tabindex="7" />
</patch>