I did 1 pull request with 3 commits. I don't know how to split the 3 commits into 3 pull requests. Not sure if I did it right. Can you see it?
On Thu, Jan 14, 2016 at 8:32 PM, A.L.E.C alec@alec.pl wrote:
On 01/14/2016 08:17 PM, Devoted Mystic wrote:
I modified many points in enigma_engine.php and now everything works as expected (tested with text plain, text plain + attachments, html, html with attachments email).
Last time I checked all of this worked ;)
I even added self-signing and private key export, but I don't advise to use them, as they should be further refined. The only thing I did not implement is about signature for non text plain emails (but the signature needs to be removed for non text plain emails to be decrypted correctly).
I would like to contribute my fixes. Can somebody check them, or tell me how to do?
Best way is to create a pull request(s) on github. Would be nice to have a separate PR for every issue/feature separately to make the review/acceptance process simpler.
https://help.github.com/articles/using-pull-requests/ https://github.com/roundcube/roundcubemail
-- Aleksander 'A.L.E.C' Machniak Kolab Groupware Developer [http://kolab.org] Roundcube Webmail Developer [http://roundcube.net]
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev