----- Original Message ----- From: "Vladislav Bogdanov" bubble@hoster-ok.com To: roland@roland-liebl.de Cc: "Jocelyn Delalande" jocelyn.lists08@crapouillou.net; dev@lists.roundcube.net Sent: Sunday, September 27, 2009 6:55 AM Subject: Re: [RCD] automatic addressbook plugin
Hi Roland, hi all
On Fri, 25 Sep 2009 15:30:20 +0200, Roland Liebl roland@roland-liebl.de wrote:
(i) I defined the automatic addressbook as readonly *). I think it
should
not be possible to add manually created items to the automatic
addressbook.
But how one can delete unneeded contacts from that addressbook then? We should find a way to only disable 'create' and 'import' actions.
I disabled 'create' and 'import' now by $rcmail->output->command('enable_command','add','import',false);
Does anyone have a clue how to disable the import button aswell? (ii) If a automatically added contact is edited, the contact is moved to the default addressbook and removed from the automatic addressbook. I
think
when a user edits a contact, we can assume that it is accepted as a permanent personal contact. My code modifications presume that the
default
addressbook source is always "0". Is this right or would it be better to use a configurable value?
Move to the personal address book on edit is a bit unclear for end user... It leads to hundreds of questions "Where are my contacts?". It is much better to add dragging support to addressbooks... And expand contextmenu plugin to addressbooks too.
Drag and drop is way out of my javascript skills. Personally I like the 'move on edit' behavior. But you are right, it might not be the behavior a end user is expecting. I made it configurable now (only admin level, not a user setting).
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/T4/SU0YiduP/automatic_addressboo.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/