Am 17.07.2013 21:30, schrieb Thomas Bruederli:
On Sun, Jul 14, 2013 at 9:27 AM, Michael Heydekamp listuser@freexp.de wrote:
Done. Just one problem: additional headers doesn't show any additional headers anymore.
We placed the config line of additional headers in config.inc.php, of course.
It's not surprising that there remain some glitches after such a major change. Fixed in https://github.com/roundcube/roundcubemail/commit/68eb1835
You're working too long till night - your commit happened after our daily git-pull at 21:10 our local time. ;) So I'll see the result only by tomorrow and will report, if any issues.
BTW: Why does especially this plugin (and this plugin only) need to be configured in the main config rather than having its own config file?
Simplicity and laziness...
As we can see now, in the long run it would have been more simple to have an own config for additional_headers, right...? ;)
Thanks for reporting!
Dafür nicht.
Anyway, a general question with regards to the new config:
As I understand it, if a new additionl key is being invented, upon git-pull it will automatically go to defaults.inc.php, right? As long as it's not manually being included in the local config.inc.php as well, the default of this key in defaults.inc.php will apply, right?
But what if a key is being renamed/replaced by a different one... (we recently had this case, IIRC)? How does this work then, and how can we make sure that outdated config keys in the local config.inc.php will be replaced by the current ones (if the outdated key does exist there at all)?
Cheers,
Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany