On 08/31/2013 02:17 AM, David Deutsch wrote:Yes. This code is quite big because of the nature of filters. We can
> This is the first time that I'm considering breaking something up into
> separate methods. There's a 600 line if/elseif construct in there. I mean
> come /on/.
split it to separate methods, but please, do not do this now. Focus on
code style and simple fixes.
Also, I see you didn't like some of my comments on your code style. I
propose to wait for Thomas. I think he might have taste similar to mine.
--
Aleksander 'A.L.E.C' Machniak
LAN Management System Developer [http://lms.org.pl]
Roundcube Webmail Developer [http://roundcube.net]
---------------------------------------------------
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl
_______________________________________________
Roundcube Development discussion mailing list
dev@lists.roundcube.net
http://lists.roundcube.net/mailman/listinfo/dev