Hi!
Chris January wrote: ...
- Ported to 0.3-SVN-r2863
...
- Fixed indentation and braces style in JS to comply with RC
coding style.
All these changes look good to me!
I'm really glad. Any cons against considering it to be committed to trunk in a future?
Known issues: 1. Messages from a threaded folder are sorted not in a thread-aware order but rather in a natural order when browsing with GUI controls at the bottom of a message view pane. This is probably a minor issue because it is more convenient anyway to browse through threaded discussions with a preview pane enabled. Maybe we need to explicitly enable a preview pane for a threaded folders.
I don't fully understand what you're saying here. Would you mind expanding?
I mean that when one double-clicks a message in a thread-enabled folder, (s)he will get messages sorted in an order different from an order in a threaded view. When browsing through a messages with controls available in a message view pane (without a message list) they will be sorted in a order which is a "thread-unaware", unlike what Thunderbird does. Example: When I double-clicked a first message in one of my folders which has threads enabled, I got it with number "2" in a message-view pane. When I pressed a "next" icon there, I've got a message which was at the fifth position in an expanded threaded list view.
- Last selected message is neither focused nor centered in a list
when returning to a list from a message view pane. I think it is minor issue too.
This patch (and original one too) is sometimes too intrusive, so it needs to be checked at least twice just not to break things.
That is true. I was disappointed my original patch couldn't be made into a plugin for 0.3 but as you say it is too intrusive.
Yes, rcube_imap.php changes should be reviewed very carefully by those who commited previous code.
Did you notice Lacri's last comment on the blog page? There is a bug with messages showing up again after you delete them (it's purely client side).
I didn't notice that bug yet, this issue should be probably checked again by those who found it if it is possible. Screenshots would be cool to start with "firebug"ging if it is really a JS issue. Lacri, would you please provide them?
Best, Bubble
List info: http://lists.roundcube.net/dev/