Zachery Hostens wrote:
ive been using roundcube for a while, but always seem to have a problem after another.
today i enjoyed the most bizarre of these. (actually these have been on going)
fyi: cvs roundcube qmail-smtpd bincimap imap server
Pure CVS: after logging in i can send 1 message fine, any other message i try to send my browser sits there with the spinning logo "Sending Message" even after my smtpd log sends the message and disconnects the client from 127.0.0.1.
CVS + my identity-reply patch: every other message i send roundcube brings me back the the message list BUT:
- does NOT send my mail.
- does NOT bring me back to the compose screen.
- does NOT save the mail in anyway.
- does NOT give any message via logs/sendmail.
- does NOT give any message via logs/errors.
- does NOT even tell me it failed to send my mail.
Don't know what's the problem here. Have you configured a smtp_host in your config? RC uses the Pear Net_SMTP class if a smtp server is configured or PHP's mail() if not. Personally I have not tested RoundCube with bincimap and I'm not aware if its peculiarities.
(this is tested the past week+)
i also have an issue where ONLY every OTHER email i try to send gets sent. and the others give me no error/warning of ANY kind. im gonna try this without my patch later, but i HIGHLY doubt that is of any issue here. (yes, i had to type THIS VERY email twice, and attempt to send it 5+ times to get it to work)
now im experiencing roundcube throwing up the 'Invalid or Timedout Session' message
while i was composing a message (this one in fact,) and another time when it was sitting idle on one of the message list windows.
This is a known bug and is due checking the crated time instead of changed time in the session table. The current CVS version also provides a periodic keep-alive signal from the client to keep up the session while typing a long mail.
the more i update roundcube the more unstable it gets, and the more pure oddities i see that should never be seen in any type of software :x
An what do you update exactly? And what do you mean with unstable?
<flame> just from looking at the source/(making one patch) i have to say ive never seen code formed so 'oddly' to put it. there is a lot of stuff thrown around randomly and for no reason. just index.php has to look at 3-4 different variables to decide what to actually do in the request. global is used in almost every function of include files, its migraine causing.
So what's wrong when using database and IMAP connections as globals instead of passing the same five arguments to every function call? Please explain what you call "stuff thrown around randomly for no reason".
when i was creating my identity-reply patch i noticed the function i was modifying being called 3 times in one request, all hitting my peice of code. there are many other functions that are "designed" to do multiple tasks, which defeats the purpose of making them in the first place (ie: functions are suppose to be small simple peices of code to solve one problem, not accept 20 variables, and return any of 10 replies back :x)
Example please. I know that some functions are a bit blown up because of some changes in the concept.
php isnt my favorite but im willing to help. but now im afraid to touch anything cause it barely works, and its a pita to try to figure out how any of the code works, (or why it works?) :x
.. (i could go on but will stop here) excuse the flame, (take it as helpful-critism please) but i spent the last half-hour yelling at roundcube for not sending my email.
</flame>
I don't think that this was "helpful-critism". If you get a headache when looking at the code, then you better leave it. And if you think this peace of software "barely works" then I suggest to wait for a stable release or look for another product...
for the good critism: i do have to say roundcube is the most aesthetically pleasing designed webmail client there is anywhere. all others are generic 1995 html 1.1 <table>-thumping designed-to-make-users-nauseous kind of thing. or they are pleasing, though try to look like a desktop application which just DOESNT work for web apps.
i will take the time sometime this week to run roundcube through a debugger/strace-like tool and throw out a handful of ideas/ways to make roundcube just work. though i really dont want to throw a lot of time into roundcube if no one wants to actually push roundcube into as clean a codebase as it is an interface.
- Zachery
Please come up with some concrete suggestions instead of generally cursing the code. I know that it's not perfect since I'm not a professional software developer and I just started studying computer science one month ago.
Thomas