Alright, got the first round in rather quickly, Alec commented some more two days ago and I just pushed through a couple more commits.
I think there are only two situations left where we are still discussing the details, but I think we're getting close to finishing this. If anybody still has broader points to address, I think this is now the time, otherwise, I think we have ourselves a first good-to-go PR.
I must say that I'm quite happy with how things are turning out, I even think this is starting to change my own preferences on code style a little
- dialing back on one-liners, mainly ;-)
Thanks to everybody who has helped and weighed in so far - and thanks in particular for the patience!
-David
On Thu, Sep 12, 2013 at 9:15 AM, David Deutsch skoremail@gmail.com wrote:
Alright, I think the first pull request is pretty much up to our specification: https://github.com/roundcube/roundcubemail/pull/109
If you find anything that I've missed, just let me know!
On Wed, Sep 11, 2013 at 8:31 PM, David Deutsch skoremail@gmail.comwrote:
Having it again here cannot benefit the Roundcube project in any way.
Indeed, I hope I did not make the impression that I wanted to have the basic style discussion that has turned many mailing lists first into hot pits of hell and then tumbleweeds. I was just trying to find a consensus to build on and got a bit carried away trying to influence the decisionmaking ;-)
In the end, there are a lot of pros and cons for various ways of doing things. The important thing is making decisions while remaining open to change. We have come to a decision and that's what counts right now.
On Wed, Sep 11, 2013 at 8:29 PM, Reindl Harald h.reindl@thelounge.netwrote:
Am 11.09.2013 20:16, schrieb Rob Sheldon:
On 2013-09-11 11:06, Reindl Harald wrote:
what i personally *never* understood is why the whole world is writing one of both unreadable code-styles at all
...
This is a 40-year-old debate over style. Having it again here cannot
benefit the Roundcube project in any way
maybe you answered to a different thread / topic as i did............
Roundcube Development discussion mailing list dev@lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev