A.L.E.C wrote:
Yes, but I was too busy. I'll start probably in next week. Do you guys have any newer version of this patch?
Not yet. I'm quite busy with other projects now, sorry. Everything except rcube_imap.php should should apply clear still (at least I hope). I tried to apply last patch week or two ago, and everything applied fine except that file. Anyway I think it would be better if you reorganize that code yourself, does anybody else know that algorithm with headers better in its current state? :)
Only few notes from me:
- We should probably combine threading with index_sort in a way that
index_sort is implicitly enabled when threading is on. This would simplify code a bit and make some hunks unnecessary (I mean a so-called 'default' sorting mode).
- We should give user a possibility to switch between threaded and
non-threaded view from a message_list itself. I already wrote that an ideal solution for me would be a tiny dropdown in the very left message_list header position with options for threading, index_sort and default sort (I mean sorting by columns) modes. One problem I see with this is a 'date' sorting which is probably a kinda special case, it should be enabled for all of three modes (FIXME), giving user an option to 'reverse-sort' the list. I hope somebody can propose a better solution for that 'reverse' listing. Hmmm.... I think all other sorting options should be disabled when either threading or index_sort are enabled, shouldn't they?
I see no problems with all the added JS code, and I'd say it is stable.
Only one quite big problem remains - that async deletion bug I wrote before. It would be really cool if you fix it in one shot with threading so we have finished threading solution.
Best, Vladislav _______________________________________________ List info: http://lists.roundcube.net/dev/