Hallo,
don't looked at the code, but had some time ago the same problem. As long as i know IE don't block promt's, but it ask/warn you if you want to popup the promt. And this is very annoying...
The replacement of promt/alert and co. is not that difficult. But, as i said before, i don't looked a the code. As replacement there are different (ready) possibilities:
- An easy one is:
http://abeautifulsite.net/notebook_files/87/demo/ Just replace alert/promt/confirm with jAlert/jConfirm... Okey... one must define the Event-Handler when pressing OK-Button and so on in a different way. But nothing difficult.
- Another one is:
http://docs.jquery.com/UI/Dialog For my tastes a littlebit heavy-weight. But when one want to use more of the UI-Library of JQuery, than maybe a usefull choise.
- Yet another way is to use any of the modal-plugins. This way you must
do, what the plugin above do for you, by yourself. But also this is not that difficult. First time i had to solve this problem with promts i used the jQuery BlockUI-Plugin (http://www.malsup.com/jquery/block/).
One Thing what i'm thinking about is the skinning. Since this Prompts (don't know if this is the same for the plugin darklight mentiod) are skinable the skindefinitions should be editable a replaceable by each rc-skin. For the first two plugins the definitions are done through css-definitions. So also nothing difficult.
Eduard
till schrieb:
On Sat, Jun 20, 2009 at 10:19 PM, darklightdarklight.xdarklight@googlemail.com wrote:
Hi,
as ticket #1485135 [1] suggests, javascript's native prompt() should be replaced with a custom one. I did a bit of research and I found Impromptu [2] seemed to do this job quite well.
after some fiddling with the code I managed to get a nice-looking (at least I think so -> but that doesn't count as I fail at any design/graphics tasks) prompt dialog. A screenshot of it can be seen under [3]
my only problem is: to get this working, I had to refactor some code in app.js (not much, but still enough that it could break something :)) Because of this I'm asking for someone who could review my code and suggest what could've been done better. A patch against svn trunk is provided under [4]
PS: I also think that the milestone for the ticket should be set to 0.4-beta, as it requires a bit more work than just replacing one line in app.js
Thanks for working on this, and I also liked what you did.
Re: the workload. I think a jquery-ui based version would def. need a little more time. Can anyone confirm if this is an urgent thing? I never heard that prompt() is blocked in IE. I also don't have IE until Tuesday to confirm this.
Till
Regards, Martin
[1] http://trac.roundcube.net/ticket/1485135 [2] http://trentrichardson.com/Impromptu/index.php [3] http://img5.abload.de/img/rcppuje3.png [4] http://pastebin.ca/1467910 _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/