Thomas Bruederli wrote:
Unfortunately I didn't have the time to test your patch but I now updated my trunk and there are some javascript errors on the subscription list in my Firefox 2.0 on Mac. Also the folder names are not displayed anymore. I reopened http://trac.roundcube.net/trac.cgi/ticket/1457344 with a dump of the javascript error and a screenshot of my folder list.
I noticed, and updated it asking if you by any change have 'foreign' characters in your folder names. I haven't seen empty names, and suspect that's where your JS errors come from, somehow.
If you zip your complete Maildir and send it to me I can debug this problem :)
In revision 813 you implicitly add new folders as a subfolder of the selected one. This should be confirmed by the user (with a checkbox for example) since it's hard to unselect a row in the subscription list and as a user I simply wouldn't expect it to be created as a subfolder.
Okay, will do that. And/or add the ability to list.js to unselect one row, if multiselect is disabled, by simply clicking on the selected row again?
And finally: do you update the IMAP subscription list when moving a folder? I remember some problems when deleting a folder but not unsubscribing it first. Some IMAP servers don't update the subscription list automatically.
No, I assumed that the backend code for 'rename-folder' would do that. Because moving a folder in IMAP is nothing more than renaming it.
<clicketyclick>
Okay, unction rename_mailbox() in program/include/rcube_imap.inc handles that.
Robin _______________________________________________ List info: http://lists.roundcube.net/dev/