Dev

dev@lists.roundcube.net

4296 discussions

Hellenic Translation
by jim＠cobaltblue.gr 13 Jan '07

13 Jan '07

Hello all, I'm posting the Hellenic translation for Roundcube beta2. I had translated and submitted the translation for Roundcube beta1, but unfortunately I did not see it as an official translation on the website, sourceforge etc. Thank you all for your terrific work, this is my small contribution back. Kind regards Jim Deves

1 0

Re: Template Questions
by Brett Patterson 11 Jan '07

11 Jan '07

Ralf Scholle wrote: > Brett Patterson schrieb: > >> Ralf Scholle wrote: >> >>> Hello, >>> >>> i found 2 "problems" on the template: >>> >>> first in main.inc.php i have this variables >>> $rcmail_config['skin_path'] = ''; >>> and >>> $rcmail_config['product_name'] = ''; >>> >>> why didn't we use this at the templates?? >>> >>> for example in /templates/login.html the information is "Hardcoded" >>> <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" >>> width="165" height="55" border="0" alt="RoundCube Webmail" >>> hspace="10" /> >>> >>> or in /includes/header.html >>> <roundcube:button command="mail" image="/images/roundcube_logo.png" >>> alt="RoundCube Webmail" width="165" height="55" /> >>> >>> i think id would be better when we could use the variables?!! >>> What do you think?? >>> >>> cu Ralf >>> >>> -- >>> Sorry for my English :-/ >>> >>> >>> >>> >>> >>> ___________________________________________________________ Der frühe >>> Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: >>> http://mail.yahoo.de >>> >>> >>> >>> >>> >> The skin path just tells RC which skin to use. Within each >> subdirectory of the themes folder are self-contained themes. They're >> self contained meaning that they use their own images / layouts. >> >> I personally like how it's done now. I don't see a reason for >> changing the theming system. >> >> ~Brett >> >> >> >> > Hey Brett, > > sorry i write to you and not to the list but let me explain what i mean ... > > my Question was why the variables from the config file are not in the > theme?? > I thought it could be better for example this way: > <img src="<?php $rcmail_config['skin_path'] > ?>/images/roundcube_logo.png" id="rcmbtn104" > width="165" height="55" border="0" alt="<?php > $rcmail_config['product_name'] ?>" hspace="10" /> > > instead of this way?? > <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" > width="165" height="55" border="0" alt="RoundCube Webmail" hspace="10" /> > > so everybody can change the variables in the config file and in the > themes automaticaly changes the path ... > > you understood?? > > cu Ralf > > > ___________________________________________________________ > Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de > I understand what you mean. But it's trivial the change you want to do. Plus, on top of that, the themes are strict HTML. So there should be no PHP code inside of it. If you look at every theme, it uses Roundcube's Theme Engine (brilliant I might add) to properly parse messages, folders, actions and such. No PHP code is to be contained in the themes. What you're suggesting is the complete opposite of abstraction. You want to put PHP code directly into the theme which. The whole point of the template parser is to get the PHP out of the theme so that non-PHP web designers can create a slick GUI for Roundcube. So that being said, I understand what you're saying, but it goes against the whole point of abstraction and the MVC. I still am totally against making the change(s) you suggest about this. ~Brett

1 0

New folder parent selection (#1457344)
by Robin Elfrink 11 Jan '07

11 Jan '07

An attempt to fix feature request #1457344, select parent folder when creating new folder. To do: - Make JS display new folder at the appropriate position. - Check with http://trac.roundcube.net/trac.cgi/wiki/Dev_Guidelines Comments so far, anybody? Robin Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 455) +++ program/include/main.inc (working copy) @@ -1366,6 +1366,7 @@ 'identityform' => 'rcube_identity_form', 'foldersubscription' => 'rcube_subscription_form', 'createfolder' => 'rcube_create_folder_form', + 'parentfolder' => 'rcube_parent_folder_form', 'renamefolder' => 'rcube_rename_folder_form', 'composebody' => 'rcmail_compose_body' ); Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 455) +++ program/localization/en_US/labels.inc (working copy) @@ -223,6 +223,7 @@ $labels['folder'] = 'Folder'; $labels['folders'] = 'Folders'; +$labels['parentfolder'] = 'Parent folder'; $labels['foldername'] = 'Folder name'; $labels['subscribed'] = 'Subscribed'; $labels['create'] = 'Create'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 455) +++ program/js/app.js (working copy) @@ -2426,10 +2426,13 @@ var form; if ((form = this.gui_objects.editform) && form.elements['_folder_name']) + { name = form.elements['_folder_name'].value; + fparent = form.elements['_folder_parent'].value; + } if (name) - this.http_request('create-folder', '_name='+urlencode(name), true); + this.http_request('create-folder', '_name='+urlencode(name)+'&_parent='+urlencode(fparent), true); else if (form.elements['_folder_name']) form.elements['_folder_name'].focus(); }; Index: program/steps/settings/manage_folders.inc =================================================================== --- program/steps/settings/manage_folders.inc (revision 455) +++ program/steps/settings/manage_folders.inc (working copy) @@ -47,18 +47,24 @@ else if ($_action=='create-folder') { if (!empty($_GET['_name'])) - $create = $IMAP->create_mailbox(trim(get_input_value('_name', RCUBE_INPUT_GET, FALSE, 'UTF-7')), TRUE); + { + $name = trim(get_input_value('_name', RCUBE_INPUT_GET, FALSE, 'UTF-7')); + if (!empty($_GET['_parent'])) + $name = trim(get_input_value('_parent', RCUBE_INPUT_GET, FALSE, 'UTF-7')) . $IMAP->delimiter . $name; + $create = $IMAP->create_mailbox($name, TRUE); + } if ($create && $REMOTE_REQUEST) { - $commands = sprintf("this.add_folder_row('%s','%s')", + $display_create = str_repeat('    ', substr_count($create, $IMAP->delimiter)).preg_replace('/.*'.preg_quote($IMAP->delimiter).'/', '', rcube_charset_convert($create, 'UTF-7')); + $commands .= sprintf("this.add_folder_row('%s','%s')", JQ($create), - JQ(rcube_charset_convert($create, 'UTF-7'))); + JQ($display_create)); rcube_remote_response($commands); } else if (!$create && $REMOTE_REQUEST) { - $commands = show_message('errorsaving', 'error'); + $commands .= show_message('errorsaving', 'error'); rcube_remote_response($commands); } else if (!$create) @@ -167,7 +173,9 @@ $zebra_class = $i%2 ? 'even' : 'odd'; $folder_js = JQ($folder); $folder_js_enc = JQ(rcube_charset_convert($folder, 'UTF-7')); - $folder_html = $CONFIG['protect_default_folders'] && in_array($folder, $CONFIG['default_imap_folders']) ? rcube_label(strtolower($folder)) : rcube_charset_convert($folder, 'UTF-7'); + $display_folder = str_repeat('    ', substr_count($folder, $IMAP->delimiter)).preg_replace('/.*'.preg_quote($IMAP->delimiter).'/', '', rcube_charset_convert($folder, 'UTF-7')); + + $folder_html = $CONFIG['protect_default_folders'] && in_array($folder, $CONFIG['default_imap_folders']) ? rcube_label(strtolower($folder)) : $display_folder; if (!$protected) $a_js_folders['rcmrow'.($i+1)] = array($folder_js, $folder_js_enc); @@ -239,6 +247,23 @@ return $out; } +function rcube_parent_folder_form($attrib) + { + global $IMAP; + + $select = new select(array('name' => '_folder_parent')); + $select->add('', ''); + + $folders = $IMAP->list_mailboxes(); + foreach ($folders as $folder) + { + $display_folder = str_repeat('    ', substr_count($folder, $IMAP->delimiter)).preg_replace('/.*'.preg_quote($IMAP->delimiter).'/', '', $folder); + $select->add($display_folder, $folder); + } + + return $select->show(''); + } + function rcube_rename_folder_form($attrib) { global $CONFIG, $IMAP, $JS_OBJECT_NAME; Index: skins/default/templates/managefolders.html =================================================================== --- skins/default/templates/managefolders.html (revision 455) +++ skins/default/templates/managefolders.html (working copy) @@ -25,9 +25,25 @@ <div class="boxtitle"><roundcube:label name="createfolder" /></div> <div class="settingspart"> +<table border="0" cellspacing="0" cellpadding="1"> +<tr> +<td> +<roundcube:label name="parentfolder" />:  +</td> +<td> +<roundcube:object name="parentfolder" form="subscriptionform" /> +</td> +</tr> +<tr> +<td> <roundcube:label name="foldername" />:  +</td> +<td> <roundcube:object name="createfolder" form="subscriptionform" /> <roundcube:button command="create-folder" type="input" class="button" label="create" /> +</td> +</tr> +</table> </div> </div>

3 5

de_DE corrections
by Michael Bueker 11 Jan '07

11 Jan '07

Hi, Attached, there are corrected versions of de_DE/messages.inc and labels.inc. Most changes are for consistency and language accuracy. ~Mik

2 2

Dovecot
by Justin Frydman 10 Jan '07

10 Jan '07

I am considering an upgrade to dovecot which uses maildir instead of mbox, will roundcube still function?

5 6

Slovene language files updated
by Andrej Mocilnik 10 Jan '07

10 Jan '07

In the attachment there are the files for Slovenian translation with UTF-8 encoding. Andrej

1 0

Italian language files, updated
by Andrej Mocilnik 10 Jan '07

10 Jan '07

Hi to everyone, attached you find the updated labels and messages files for the Italian language. -- Dott. Andrej Mocilnik ----------------------------- DotCom Information technology Via Biancospino, 9 34016 - Opicina (TS) Italy tel: +39 040 2158191 fax: +39 040 0641954 cell: +39 338 9379513 E-mail: amocilnik(a)dotcom.ts.it ----------------------------- Ai sensi del D.lgs n. 196 del 30.06.03 (Codice Privacy) si precisa che le informazioni contenute in questo messaggio sono riservate e ad uso esclusivo del destinatario. Qualora il messaggio in parola Le fosse pervenuto per errore, La preghiamo di eliminarlo senza copiarlo e di non inoltrarlo a terzi, dandocene gentilmente comunicazione. Grazie This message, for the D.lgs n. 196 / 30.06.03 (Privacy Code), may contain confidential and/or privileged information. If you are not the addressee or authorized to receive this for the addressee, you must not use, copy, disclose or take any action based on this message or any information herein. If you have received this message in error, please advise the sender immediately by reply e-mail and delete this message. Thank you for your cooperation.

1 1

Problem with encoding when iso-8859-1 foreign characters are found in the From header
by roundcube＠zserv.com 10 Jan '07

10 Jan '07

One of the users of roundcube on my server recieved an email where the name in the From header contained foreign characters. When she replied to this email, qmail gave an instant bounce message: <?=(a)oak.webhost999.com>: Sorry, no mailbox here by that name. (#5.1.1) I looked at the source for the email she replied to, and the From header looked like this (the email address has been changed and antispamed): From: =?iso-8859-1?q?Elo=EDsa=20Alvarado?= <test at yahoo dot com> I hit reply and changed the email within the < and the > to my email address to see what would happen. I recieved the reply, but I also got the same bounce message. When I looked at the source for the message I sent in my sent mail folder, the To header looked like this: To: =?UTF-8?Q?Elo=C3=83=C2=ADsa=20Alvarado=20<test at yahoo dot com>?= I have read of people reporting bug with roundcubes encoding, but I haven't heard of a fix, is one underway? Thanks. Marc

4 3

messagelist reload upon new email arrival
by Bram Vogelaar 08 Jan '07

08 Jan '07

Dear all I have been wondering for a while about the fact that when a new email arrives the folder name and title name are correctly updated to show this new arrival. However the appropriate message list isn't updated, which seemed odd to me. Is this a bug or a feature?? After having spend some time inside the cod, i am now hopelessly stuck. I either end up in an eternal loop or need to code a new function (js/php) to instigate a message list reload without a this.set_unread_count(). Does anyone have an idea about this? with regards Bram Vogelaar

1 0

Config file format
by Jim Lester 08 Jan '07

08 Jan '07

First and for most, thank you for saving me from SquirrelMail, really, thank you. Second its really hard to look up what has been discused on the list to see what has been said and what hasn't, so forgive me if I say anything redundant, besides suggestions should be seconded, and thirded ect. Anyways. So my main point, the config file shouldn't be in php format, its really awkward to work with. I know it was probably easier to do out of the gate, but at some point it should be broken up in normal config style. Like: db_host = localhost db_Name = roundcubedatabse db_Password = p@ssword Instead of the mysql syntax in a php array. This would obviously involve writing some sort of parser, but it would be a good idea. Thats what I got. Thanks. --- Jim Lester ACM Staff Manager notroot(a)acm.cs.umn.edu

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev