Dev December 2006

dev@lists.roundcube.net

66 participants
67 discussions

LDAP auto-completion tweaks ...
by Ryan Rittenhouse 13 Dec '06

13 Dec '06

I've got a bunch of students that opt to use the svn of roundcube (after I make sure there are not huge bugs) and was threatened with certain death if I didn't patch it to use LDAP auto-completion. Since I've parked it in a pseudo-production environment and it has the potential to annoy people, I've added an option on the user settings to enable/disable this. I also discovered that it will not auto-complete unless you have at least one entry in your address book so I changed that as well. I've included the diff that has the original additions as well as my own as a rough and ready patch for anyone wanting to run this. -Ryan Rittenhouse -- Network Administrator Goshen College (574) 535-7004 Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 404) +++ program/localization/en_US/labels.inc (working copy) @@ -216,6 +216,7 @@ $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; $labels['previewpane'] = 'Show preview pane'; +$labels['ldapcomplete'] = 'Auto-Complete Addresses from Ldap (directory)'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 404) +++ program/steps/settings/func.inc (working copy) @@ -178,6 +178,14 @@ rep_specialchars_output(rcube_label('previewpane')), $input_preview->show($CONFIG['preview_pane']?1:0)); } + + //show config for ldap auto completion + $field_id = 'rcmfd_ldapcomplete'; + $input_preview = new checkbox(array('name' => '_ldap_complete', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('ldapcomplete')), + $input_preview->show($CONFIG['ldap_complete']?1:0)); if (!empty($CONFIG['drafts_mbox']) && !isset($no_override['preview_pane'])) { Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 404) +++ program/steps/settings/save_prefs.inc (working copy) @@ -27,6 +27,7 @@ 'prefer_html' => isset($_POST['_prefer_html']) ? TRUE : FALSE, 'htmleditor' => isset($_POST['_htmleditor']) ? TRUE : FALSE, 'preview_pane' => isset($_POST['_preview_pane']) ? TRUE : FALSE, + 'ldap_complete' => isset($_POST['_ldap_complete']) ? TRUE : FALSE, 'draft_autosave' => isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0 ); Index: program/steps/mail/compose.inc =================================================================== --- program/steps/mail/compose.inc (revision 404) +++ program/steps/mail/compose.inc (working copy) @@ -20,6 +20,7 @@ */ require_once('Mail/mimeDecode.php'); +require_once('include/rcube_ldap.inc'); require_once('lib/html2text.inc'); // define constants for message compose mode @@ -887,16 +888,53 @@ FROM ".get_table_name('contacts')." WHERE user_id=? AND del<>1",$_SESSION['user_id']); -if ($DB->num_rows($sql_result)) +if ($DB->num_rows($sql_result) || $CONFIG['ldap_complete']) { $a_contacts = array(); while ($sql_arr = $DB->fetch_assoc($sql_result)) if ($sql_arr['email']) $a_contacts[] = format_email_recipient($sql_arr['email'], rep_specialchars_output($sql_arr['name'], 'js')); - - $OUTPUT->add_script(sprintf("$JS_OBJECT_NAME.set_env('contacts', %s);", array2js($a_contacts))); + + /* LDAP autocompletion */ + if($CONFIG['ldap_complete']) foreach ($CONFIG['ldap_public'] as $ldapserv_config) + { + /* we need fuzzy search enabled */ + if ($ldapserv_config['fuzzy_search'] != 1) + continue; + + $mail_field = $ldapserv_config['mail_field']; + $name_field = $ldapserv_config['name_field']; + + $cLdap = new rcube_ldap(); + + $cLdap->connect ($ldapserv_config['hosts'], + $ldapserv_config['port'], + 3, + $ldapserv_config['dn'], + $ldapserv_config['password']); + + + + $results = $cLdap->search ($ldapserv_config['base_dn'], + $name_field."=*", + array($mail_field, $name_field), + $ldapserv_config['scope']); + + for ($i = 0 ; $i < $results['count'] ; $i++) + { + $mail = $results[$i][$mail_field]; + $name = $results[$i][$name_field][0]; + + for ($j = 0 ; $j < $mail['count'] ; $j++) + $a_contacts[] = format_email_recipient($mail[$j], + $name); + } + $cLdap->close (); } + $OUTPUT->add_script(sprintf("$JS_OBJECT_NAME.set_env('contacts', %s);", array2js($a_contacts))); +} + parse_template('compose'); ?>

1 0

LDAP auto-completion (ticket #1483899)
by Pierre Mauduit 13 Dec '06

13 Dec '06

Hi, Since some people seem to be interested in LDAP autocompletion feature, (http://trac.roundcube.net/trac.cgi/ticket/1483899) I coded it on my RC copy. I tried it, and it looks like working ; (I permit myself to join the patch to this mail, because it is not really huge). By the way, my current RC copy begins to be slightly different from the svn copy. So it will be great if some LDAP users could give some feedbacks. In addition, a main problem of this code is that it could certainly slow the generations of the pages in some cases. (I have less than 20 contacts on my LDAP, but what if there was more than a thousand ?). best regards, -- Pierre

4 4

About some features / enhancements
by Pierre Mauduit 13 Dec '06

13 Dec '06

Hello, As far as I dive into the RC code, i have been trying to add some features to my RC copy, and I'd like to give some remarks about this great webmail project. - Autocompletion : When I worked on LDAP autocompletion support (around 1st of december), I figured out that all contacts were added to a big javascript array. Why not making XMLHttpRequests to a page that returns the autocompletion, when 4 ou more / less caracters are given ? I think it could improve performances in case of users handling thousands of contacts into their addressbook. I did'nt look the code toroughly, and don't know if it is really possible. - Message threads : For my personal javascript culture, I began to code something like threaded mails view (ticket #1424907). It's just a begin for the moment, see here if you're curious enough : http://pedrov.kwain.net/~pedrov/rcube/mail_toggle/toggle.html Anyway, I'm not sure that it's RC compliant (I could not use a table to show messages), and I'm still a beginner in Javascript language. Does anybody here has begun to code anything about this ticket ? (I'd like to know if i'm wrong) - French translation : Thanks Thomas, for having commited french language modifications ! just one remark : we (Aurélien and I) prefer to translate "junk" into "indésirables" ;-) - LDAP support : I read in the list archives, that the public ldap search has to be rewritten completely (http://lists.roundcube.net/mail-archive/roundcube.dev/2006/09/136/) Does anyone has more info about it ? Can I help ? best regards, -- pierre

2 1

"Sender" field empty
by Michael Bueker 12 Dec '06

12 Dec '06

Hi, in the latest SVN of roundcube, I can't send any mail because the "Sender" selection box in the Write Mail dialog is empty. I have tried re-creating my identity, but that didn't help. I am using a config file that worked a few SVN revisions back, and I have properly adjusted it to the latest .dist config file. I would hate to have to re-create my roundcube user (in fact, I don't even know how to delete my old one). ~Mik -- Blessed are the geek.

3 3

Tool for translations
by Robin Elfrink 11 Dec '06

11 Dec '06

Hi, I wrote a small thingy to help in translating RoundCube. This is not intended to be added to RoundCube, just a little helpful tool. Place the attached translate.php in ./program/localization, and point your browser to '<your-RC-URL>/program/localization/translate.php?language=<your-language>' . Example in my case: http://eddy.introweb.nl/roundcubemail/program/localization/translate.php?la… The output is copy&pasteable to the files labels.inc and messages.inc, and untranslated labels and messages will show in red. Robin

5 8

Printed message
by Robin Elfrink 11 Dec '06

11 Dec '06

Hi, Quoted text is not shown on a printed message, except for a bit of padding on the left. This small patch adds a grey border to the left. I'm not quite sure about the grey-levels, but if nobody objects I'll commit this today. Robin Index: skins/default/print.css =================================================================== --- skins/default/print.css (revision 392) +++ skins/default/print.css (working copy) @@ -109,3 +109,23 @@ padding: 0; font-size: 9pt; } + +div.message-part blockquote +{ + color: #444; + border-left: 2px solid #444; + margin: 0.5em 0px 0.5em 0px; + padding: 0px 0px 0px 1em; +} + +div.message-part blockquote blockquote +{ + color: #666; + border-left: 2px solid #666; +} + +div.message-part blockquote blockquote blockquote +{ + color: #888; + border-left: 2px solid #888; +}

2 7

Patch to allow 12 hour date to display for emails sent today.
by dmandell 09 Dec '06

09 Dec '06

Hi again, I'm an American and prefer to use a 12 hour time display (i.e. 1:05pm) rather than a 24 hour clock (13:05). Currently Roundcube allows 12 hour time displays for messages older than one day, but for messages received today it still uses the 24 hour display. The following patch creates a preference for today's date (called date_today) in main.php.inc and then edits main.inc to use it. Again, if I'm doing this wrong please let me know. Thanks, Doug Index: roundcubemail/config/main.inc.php.dist =================================================================== --- roundcubemail/config/main.inc.php.dist (revision 400) +++ roundcubemail/config/main.inc.php.dist (working copy) @@ -107,6 +107,9 @@ // the default locale setting $rcmail_config['locale_string'] = 'en'; +// use this format for today's date display +$rcmail_config['date_today'] = 'H:i'; + // use this format for short date display $rcmail_config['date_short'] = 'D H:i'; Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1687,7 +1687,7 @@ // define date format depending on current time if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit) - return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp)); + return sprintf('%s %s', rcube_label('today'), date($CONFIG['date_short'] ? $CONFIG['date_today'] : 'H:i', $timestamp)); else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit) $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i'; else if (!$format)

1 0

patch for tabindex on send button (compose email page)
by dmandell 08 Dec '06

08 Dec '06

Hi all, I prefer to use keyboard navigation whenever possible. RC currently allows tabbing between recipient, subject and body, but the send button doesn't allow tabindex. In other webmail applications (yahoo, gmail, etc) send is next after tab, and it's quite convenient that way. I'm assuming you didn't purposely make it difficult to tab to the Send button, so I've created a patch for your approval. Below is a patch that allows tabindex in buttons and makes "Send" and "Cancel" next in the tab order after the email body. Please let me know if I'm not submitting the patch right or if you have any issues. Thanks a bunch, Doug Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1501,7 +1501,7 @@ if ($attrib['label']) $attrib['value'] = $attrib['label']; - $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$ + $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$ $out = sprintf('<input%s disabled />', $attrib_str); } Index: roundcubemail/skins/default/templates/compose.html =================================================================== --- roundcubemail/skins/default/templates/compose.html (revision 400) +++ roundcubemail/skins/default/templates/compose.html (working copy) @@ -100,15 +100,15 @@ <table border="0" cellspacing="0" width="100%" summary=""><tbody><tr> <td> -<roundcube:button type="input" command="send" class="button" label="sendmessage" /> -<roundcube:button type="input" command="list" class="button" label="cancel" /> +<roundcube:button type="input" command="send" class="button" label="sendmessage" tabindex="8" /> +<roundcube:button type="input" command="list" class="button" label="cancel" tabindex="9" /> </td> <td align="right"> -<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="8" /> +<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="10" /> </td> <td align="right"> <roundcube:label name="editortype" />: </td> -<roundcube:object name="editorSelector" tabindex="9" /> +<roundcube:object name="editorSelector" tabindex="11" /> </tr></tbody></table> </td>

1 0

[Fwd: Re: Printed message]
by Robin Elfrink 07 Dec '06

07 Dec '06

Ryan: Please reply to the lest next time, while I'll try to instruct my mail-client. -------- Original Message -------- Subject: Re: Printed message Date: Thu, 07 Dec 2006 10:41:59 -0500 From: Ryan Rittenhouse <ryanmr(a)goshen.edu> To: Robin Elfrink <elfrink(a)introweb.nl> References: <4573FC24.3050400(a)introweb.nl> <4573FFF6.8090205(a)gmail.com> <457401F3.4050601(a)introweb.nl> <457404FC.4000302(a)gmail.com> <4576AFC5.3080703(a)introweb.nl> <4576B620.1020902(a)gmail.com> <45782497.9000401(a)introweb.nl> <45782C43.7000208(a)cantella.com> <45782ECF.7050306(a)introweb.nl> Robin Elfrink wrote: > How about a user-configurable option then? Or would the settings get > cluttered too much? I like the idea of user-configurable. I think it'll be a while before the settings list starts getting cluttered. Ever see the one for Ilohamail? ;p -Ryan Rittenhouse Network Administrator Goshen College ryanmr(a)goshen.edu (574) 535-7004

1 0

[Fwd: Re: Printed message]
by Robin Elfrink 07 Dec '06

07 Dec '06

Pierre: Please reply to the lest next time, while I'll try to instruct my mail-client. -------- Original Message -------- Subject: Re: Printed message Date: Thu, 7 Dec 2006 16:30:54 +0100 From: Pierre Mauduit <pierre.mauduit(a)gmail.com> To: Robin Elfrink <elfrink(a)introweb.nl> References: <45782ECF.7050306(a)introweb.nl> Hi, > How about a user-configurable option then? > I think it is the best solution to get everybody happy with this :-) -- pierre

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev December 2006