Dev May 2006

dev@lists.roundcube.net

61 participants
52 discussions

new behaviors after CVS upgrade
by Martin Marques 18 May '06

18 May '06

I'm seeing new behaviors in RC after the last upgrade I did. - When marking a message and later deleting it, the next message gets automatically marked, which isn't a good idea, as I could accidently click twice on the delete botom and get both messages erased. - Spell checker is present, but doesn't seem to work. Except from this, things look very good. -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador ---------------------------------------------------------

7 15

[PATCH] Return Receipt
by Salvatore Ansani 18 May '06

18 May '06

Hi guys, I made changes to roundcube CVS Sources to request, when composing emails, "Notification Requests". I've added a checkbox to handle requests. I send patch to M/L and Forum :) Regards, Salvatore

9 18

MDB2 wrapper update
by Lukas Kahwe Smith 18 May '06

18 May '06

Hi, I updated the MDB2 wrapper .. It also seems to work with the session class, so the mdb2 specific handling can be disabled in main.inc. There is one problem with the affectedRows() method. MDB2 (as well as the new PDO extension) require the use of the exec() method for DML (INSERT/UPDATE/DELETE..) and then it directly returns the affected rows number. To accommodate this the wrapper would need to be expanded. Either query() needs to get another parameter or even better there needs to be an exec() method in the wrapper that behaves like MDB2/PDO. Its easy to get the same behavior with DB. I also attached an xml schema file. This file can use used with MDB2_Schema (or ezc/DatabaseSchema) as a single portable RDBMS schema file from which both mentioned packages can even generate alter statements. So instead of having to maintain multiple files per RDBMS and one installation/upgrading file for each you fold everything into a single file. Do note however that currently there is no way to handle UPDATE/DELETE statements, and there is no support for FOREIGN KEY's at this point. If there is interest I can help in writing an installer for this. The file can also be used at packaging time to generate the SQL files you guys currently ship (http://pooteeweet.org/blog/312). regards, Lukas <?php /* +-----------------------------------------------------------------------+ | program/include/rcube_db.inc | | | | This file is part of the RoundCube Webmail client | | Copyright (C) 2005, RoundCube Dev. - Switzerland | | Licensed under the GNU GPL | | | | PURPOSE: | | PEAR:DB wrapper class that implements PEAR DB functions | | See http://pear.php.net/package/DB | | | +-----------------------------------------------------------------------+ | Author: David Saez Padros <david(a)ols.es> | +-----------------------------------------------------------------------+ $Id: rcube_db.inc,v 1.16 2006/02/19 17:39:26 roundcube Exp $ */ /** * Obtain the PEAR::DB class that is used for abstraction */ require_once('MDB2.php'); /** * Database independent query interface * * This is a wrapper for the PEAR::DB class * * @package RoundCube Webmail * @author David Saez Padros <david(a)ols.es> * @author Thomas Bruederli <roundcube(a)gmail.com> * @version 1.16 * @link http://pear.php.net/package/DB */ class rcube_db { var $db_dsnw; // DSN for write operations var $db_dsnr; // DSN for read operations var $db_connected = false; // Already connected ? var $db_mode = ''; // Connection mode var $db_handle = 0; // Connection handle var $a_query_results = array('dummy'); var $last_res_id = 0; /** * Object constructor * * @param string DSN for read/write operations * @param string Optional DSN for read only operations */ function __construct($db_dsnw, $db_dsnr='') { if ($db_dsnr=='') $db_dsnr=$db_dsnw; $this->db_dsnw = $db_dsnw; $this->db_dsnr = $db_dsnr; $dsn_array = MDB2::parseDSN($db_dsnw); $this->db_provider = $dsn_array['phptype']; } /** * PHP 4 object constructor * * @see rcube_MDB2::__construct */ function rcube_db($db_dsnw,$db_dsnr='') { $this->__construct($db_dsnw,$db_dsnr); } /** * Connect to specific database * * @param string DSN for DB connections * @return object PEAR database handle * @access private */ function dsn_connect($dsn) { // Use persistent connections if available $dbh = MDB2::connect($dsn, array('persistent' => TRUE, 'portability' => MDB2_PORTABILITY_ALL ^ MDB2_PORTABILITY_EMPTY_TO_NULL)); if (PEAR::isError($dbh)) { raise_error(array('code' => 500, 'type' => 'db', 'line' => __LINE__, 'file' => __FILE__, 'message' => $dbh->getMessage()), TRUE, FALSE); } else if ($this->db_provider=='sqlite') { $dsn_array = MDB2::parseDSN($dsn); if (!filesize($dsn_array['database']) && !empty($this->sqlite_initials)) $this->_sqlite_create_database($dbh, $this->sqlite_initials); } return $dbh; } /** * Connect to appropiate databse * depending on the operation * * @param string Connection mode (r|w) * @access public */ function db_connect($mode) { $this->db_mode = $mode; // Already connected if ($this->db_connected) { // no replication, current connection is ok if ($this->db_dsnw==$this->db_dsnr) return; // connected to master, current connection is ok if ($this->db_mode=='w') return; // Same mode, current connection is ok if ($this->db_mode==$mode) return; } if ($mode=='r') $dsn = $this->db_dsnr; else $dsn = $this->db_dsnw; $this->db_handle = $this->dsn_connect($dsn); $this->db_connected = true; } /** * Execute a SQL query * * @param string SQL query to execute * @param mixed Values to be inserted in query * @return number Query handle identifier * @access public */ function query() { $params = func_get_args(); $query = array_shift($params); return $this->_query($query, 0, 0, $params); } /** * Execute a SQL query with limits * * @param string SQL query to execute * @param number Offset for LIMIT statement * @param number Number of rows for LIMIT statement * @param mixed Values to be inserted in query * @return number Query handle identifier * @access public */ function limitquery() { $params = func_get_args(); $query = array_shift($params); $offset = array_shift($params); $numrows = array_shift($params); return $this->_query($query, $offset, $numrows, $params); } /** * Execute a SQL query with limits * * @param string SQL query to execute * @param number Offset for LIMIT statement * @param number Number of rows for LIMIT statement * @param array Values to be inserted in query * @return number Query handle identifier * @access private */ function _query($query, $offset, $numrows, $params) { // Read or write ? if (strtolower(trim(substr($query,0,6)))=='select') $mode='r'; else $mode='w'; $this->db_connect($mode); if ($this->db_provider == 'sqlite') $this->_sqlite_prepare(); if ($numrows || $offset) $result = $this->db_handle->setLimit($numrows,$offset); if (empty($params)) { $result = $this->db_handle->query($query); } else { $params = (array)$params; $q = $this->db_handle->prepare($query); $result = $q->execute($params); $q->free(); } // add result, even if it's an error return $this->_add_result($result); } /** * Get number of rows for a SQL query * If no query handle is specified, the last query will be taken as reference * * @param number Optional query handle identifier * @return mixed Number of rows or FALSE on failure * @access public */ function num_rows($res_id=NULL) { if (!$this->db_handle) return FALSE; if ($result = $this->_get_result($res_id)) return $result->numRows(); else return FALSE; } /** * Get number of affected rows fort he last query * * @return mixed Number of rows or FALSE on failure * @access public */ function affected_rows($result = null) { if (!$this->db_handle) return FALSE; return $result; } /** * Get last inserted record ID * For Postgres databases, a sequence name is required * * @param string Sequence name for increment * @return mixed ID or FALSE on failure * @access public */ function insert_id($sequence = '') { if (!$this->db_handle || $this->db_mode=='r') return FALSE; return $this->db_handle->lastInsertID($sequence); } /** * Get an associative array for one row * If no query handle is specified, the last query will be taken as reference * * @param number Optional query handle identifier * @return mixed Array with col values or FALSE on failure * @access public */ function fetch_assoc($res_id=NULL) { $result = $this->_get_result($res_id); return $this->_fetch_row($result, MDB2_FETCHMODE_ASSOC); } /** * Get an index array for one row * If no query handle is specified, the last query will be taken as reference * * @param number Optional query handle identifier * @return mixed Array with col values or FALSE on failure * @access public */ function fetch_array($res_id=NULL) { $result = $this->_get_result($res_id); return $this->_fetch_row($result, MDB2_FETCHMODE_ORDERED); } /** * Get co values for a result row * * @param object Query result handle * @param number Fetch mode identifier * @return mixed Array with col values or FALSE on failure * @access private */ function _fetch_row($result, $mode) { if (PEAR::isError($result)) { raise_error(array('code' => 500, 'type' => 'db', 'line' => __LINE__, 'file' => __FILE__, 'message' => $this->db_link->getMessage()), TRUE, FALSE); return FALSE; } return $result->fetchRow($mode); } /** * Formats input so it can be safely used in a query * * @param mixed Value to quote * @return string Quoted/converted string for use in query * @access public */ function quote($input, $type = null) { // create DB handle if not available if (!$this->db_handle) $this->db_connect('r'); // escape pear identifier chars $rep_chars = array('?' => '\?', '!' => '\!', '&' => '\&'); return $this->db_handle->quote($input, $type); } /** * Quotes a string so it can be safely used as a table or column name * * @param string Value to quote * @return string Quoted string for use in query * @deprecated Replaced by rcube_MDB2::quote_identifier * @see rcube_MDB2::quote_identifier * @access public */ function quoteIdentifier($str) { return $this->quote_identifier($str); } /** * Quotes a string so it can be safely used as a table or column name * * @param string Value to quote * @return string Quoted string for use in query * @access public */ function quote_identifier($str) { if (!$this->db_handle) $this->db_connect('r'); return $this->db_handle->quoteIdentifier($str); } /** * Return SQL statement to convert a field value into a unix timestamp * * @param string Field name * @return string SQL statement to use in query * @access public */ function unixtimestamp($field) { switch($this->db_provider) { case 'pgsql': return "EXTRACT (EPOCH FROM $field)"; break; default: return "UNIX_TIMESTAMP($field)"; } } /** * Return SQL statement to convert from a unix timestamp * * @param string Field name * @return string SQL statement to use in query * @access public */ function fromunixtime($timestamp) { switch($this->db_provider) { case 'mysqli': case 'mysql': case 'sqlite': return "FROM_UNIXTIME($timestamp)"; default: return date("'Y-m-d H:i:s'", $timestamp); } } /** * Adds a query result and returns a handle ID * * @param object Query handle * @return mixed Handle ID or FALE on failure * @access private */ function _add_result($res) { // sql error occured if (PEAR::isError($res)) { raise_error(array('code' => 500, 'type' => 'db', 'line' => __LINE__, 'file' => __FILE__, 'message' => $res->getMessage() . " Query: " . substr(preg_replace('/[\r\n]+\s*/', ' ', $res->userinfo), 0, 512)), TRUE, FALSE); return FALSE; } else { $res_id = sizeof($this->a_query_results); $this->a_query_results[$res_id] = $res; $this->last_res_id = $res_id; return $res_id; } } /** * Resolves a given handle ID and returns the according query handle * If no ID is specified, the last ressource handle will be returned * * @param number Handle ID * @return mixed Ressource handle or FALE on failure * @access private */ function _get_result($res_id=NULL) { if ($res_id==NULL) $res_id = $this->last_res_id; if ($res_id && isset($this->a_query_results[$res_id])) return $this->a_query_results[$res_id]; else return FALSE; } /** * Create a sqlite database from a file * * @param object SQLite database handle * @param string File path to use for DB creation * @access private */ function _sqlite_create_database($dbh, $file_name) { if (empty($file_name) || !is_string($file_name)) return; $data = ''; if ($fd = fopen($file_name, 'r')) { $data = fread($fd, filesize($file_name)); fclose($fd); } if (strlen($data)) sqlite_exec($dbh->connection, $data); } /** * Add some proprietary database functions to the current SQLite handle * in order to make it MySQL compatible * * @access private */ function _sqlite_prepare() { include_once('include/rcube_sqlite.inc'); // we emulate via callback some missing MySQL function sqlite_create_function($this->db_handle->connection, "from_unixtime", "rcube_sqlite_from_unixtime"); sqlite_create_function($this->db_handle->connection, "unix_timestamp", "rcube_sqlite_unix_timestamp"); sqlite_create_function($this->db_handle->connection, "now", "rcube_sqlite_now"); sqlite_create_function($this->db_handle->connection, "md5", "rcube_sqlite_md5"); } } // end class rcube_db ?>

1 0

PHP Warning: Cannot modify header information
by phil 17 May '06

17 May '06

I'm running the latest CVS (spellcheck rocks!) and when I send an email, my /var/log/httpd-error.log tells me: [Wed May 17 09:27:43 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0, referer: https://cryer.us/roundcubemail-cvs/?_auth=8a3fedb6ff5174f02748cce209456e876… [Wed May 17 09:27:43 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0, referer: https://cryer.us/roundcubemail-cvs/?_auth=8a3fedb6ff5174f02748cce209456e876… [Wed May 17 09:27:44 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Wed May 17 09:27:44 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 This only started up recently, let me know if I need to display my php.ini, turn up logging or anything else to help debug. Thanks P -- http://fak3r.com - you don't have to kick it

2 1

Multiple identities - default option not saving?
by Richard Green 17 May '06

17 May '06

Not quite sure what's happening, it doesn't seem to save the default identity tickbox and also when you select a different default identity, it doesn't untick the other default. Maybe this is just down to problem #1, however. -- Richard

1 0

deleting from view message
by Charles McNulty 16 May '06

16 May '06

I'm not having any luck debugging the issue with deleting messages while in the show message screen. Here is the error: Error: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIXMLHttpRequest.status] Source file: http://www.popquizhotshot.com/rc_delete/program/js/app.js Line: 3326 To reproduce the error: 1) edit main.inc.php such that: $rcmail_config['trash_mbox'] = ''; $rcmail_config['flag_for_deletion'] = TRUE; 2) view any e-mail message 3) click the delete icon 4) click on the inbox and note that the message has not been marked as deleted My javascript debugger shows that everything appears to be being called with all of the correct parameters and everything but when it reaches line ~3015 in http_request: request_obj.GET(this.env.comm_path+'&_action='+escape(action)+'&'+querystring); The request is never sent to the client. logging shows that index.php and mark.inc are never called. It all works just fine when in the message list but it doesn't work when viewing a message. Any help would be greatly appreciated. -Charles (x-posted to forums)

1 0

Disk Usage: unknown - but do have support
by Bezaleel Support 16 May '06

16 May '06

Hello all, I am currently using the latest CVS version of RC. I have logged in and checked to make certain I have QUOTA support in imap. [quote] 1 login klanders <XXXX> 1 OK LOGIN Ok. 2 GETQUOTA * QUOTA "GETQUOTA" (STORAGE 32381 97657) 2 OK GETQUOTA Ok. [/quote] Whenever I log into round cube, I see "Disk Usage: unknown" at the bottom of every page. Anyone have any ideas? Kevin L.

2 5

Search bug
by Jon Daley 16 May '06

16 May '06

/var/www/secure/webmail>svn diff program/ Index: program/include/rcube_imap.inc =================================================================== --- program/include/rcube_imap.inc (revision 1636) +++ program/include/rcube_imap.inc (working copy) @@ -876,10 +876,11 @@ $a_messages = iil_C_Search($this->conn, $mailbox, $criteria); // clean message list (there might be some empty entries) - foreach ($a_messages as $i => $val) - if (empty($val)) - unset($a_messages[$i]); - + if($a_messages){ + foreach ($a_messages as $i => $val) + if (empty($val)) + unset($a_messages[$i]); + } return $a_messages; } /var/www/secure/webmail>svn commit -m "need to check value before passing to foreach. search is also broken, so this might not be the real fix" Maybe I will get a chance to see what is broken with the search too.

4 5

Changing Folder Results in Clearing Messages
by Bezaleel Support 15 May '06

15 May '06

Hello all, I downloaded the CVS file from the Files section (5-5-2006) and updated my installation of RC. All seems to work fine, however, when I first login I see all my messages listed under my Inbox. If I click on another folder, none of the contents of the folder are shown. Even if I click back onto the Inbox, the Inbox contents are no longer shown. I can then click the New Message icon, and in the compose screen I can click on the green arrow to return to my email folders and the contents are shown again. However, as soon as I click on another folder, the contents are hidden once again. It seems that I can go to any other function (ie - click on Settings, Address Book, etc) and then return to a folder and I am shown contents. As soon as I begin clicking from folder to folder, those contents are not shown anymore. Any ideas? Thanks in advance! Kevin L.

5 6

CVS now up to date??
by Bezaleel Support 13 May '06

13 May '06

Hello again everyone! I gave the sourceforge status page ( http://sourceforge.net/docman/display_doc.php?docid=2352&group_id=1 ) a look and it showed that the new CVS system is online. Does this mean that the files now shown in the CVS via Browsing the CVS Repository are up to date with all modifications from devs? Are there any updates since the 2006-05-05 tarball that was put up in the Files section? Just curious as the latest changes in the CVS repository (via browsing it) seem to have been made 7 days ago (May 5/6th). Can't wait to be on the bleeding edge once again. Was starting to go into withdrawals. ;) Kevin L.

4 6

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev May 2006