Dev September 2007

dev@lists.roundcube.net

35 participants
43 discussions

Missing recipient/subject on replys
by Ethan Erchinger 17 Sep '07

17 Sep '07

Nobody has seen this, or everyone is ignoring the question? ================================================ Hi, I looked quite a bit but didn't see anyone else complaining about this. I recently (3 weeks ago) upgraded to the latest SVN, and migrated configuration files, and database data to the new schema. Actually I wasn't sure what may have changed in the schema, so I created a new DB, and just migrated the contacts to the new DB. After that sometimes when clicking on reply in a message, the compose window comes up, with all details, except the recent window is blank, and the subject contains on "re:". Finally the header inserted at the top of the message "On <date>, <recipient> wrote," is missing the date and recipient data. Any ideas what could be wrong? I see no errors in apache error_log or in any files in "logs". I believe filesystem permissions are set correctly. Thanks for any help you can provide. Ethan _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Fwd: Question about Templates
by Brett Patterson 14 Sep '07

14 Sep '07

Jorge: There isn't a list of items used, so you'd have to search in the code to see what's available to you. $CONFIG (I think that's what it is) and $_POST and $_SESSION is available always as they're global. Other than that, you'd have to look through the documentation that's written in the wiki or through the code. sorry. ~Brett On 9/14/07, Jorge Asch <jasch(a)conexion.co.cr> wrote: > > If this works as advertised, where can I get a list of common variables > that might be in use. > > What do you mean by "proper template engine"? What roundcube has is > perfectly fine. There's no need to hunker down and rework the entire code > to use SMARTY or any other PHP templating system, or to use a different > one. The one we have works, and works well. > > > -- > Jorge Asch Revilla > CONEXION DCR > www.conexion.co.cr > 800-CONEXION > > > -- ~ Brett Patterson -- ~ Brett Patterson _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Question about Templates
by Jorge Asch 14 Sep '07

14 Sep '07

How would I print out a variable on a template. For example, I would like to display a text with the user's email address, or display a text with the currently choosen language setting. How would I acomplish this on a template? Thanks. -- Jorge Asch Revilla CONEXION DCR www.conexion.co.cr 800-CONEXION _______________________________________________ List info: http://lists.roundcube.net/dev/

4 3

Firefox line break issue
by Joel Clermont 13 Sep '07

13 Sep '07

I have noticed that plain text emails in Firefox lose the line breaks if I copy and paste into a new message. The line breaks are preserved if I use an HTML message, or if I use plain text with Safari or IE. Has anyone else noticed this? Is there a workaround? Joel Clermont joel(a)orionweb.net 262-377-9930 _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Problems with last version from SVN
by Julien Wadin 12 Sep '07

12 Sep '07

Hi all, I took the last version from the SVN because it has a built-in html editor. Very very nice ! The problem I have is that when I reply to a message in my inbox, the To filed is left blank... Also, when I send a message, an alert says me that my body is blank. I push OK and the message is sent correctly, with the body I wrote. Any ideas about these 2 issues ? Many thanks -- Wadin Julien Tel : +32 (0) 475 632 168 Web : http://blog.julienwadin.be/ Simplifiez vous Postfix : http://postfixwinadmin.jwhosting.eu _______________________________________________ List info: http://lists.roundcube.net/dev/

3 5

Missing recipient/subject on replys
by Ethan Erchinger 11 Sep '07

11 Sep '07

Hi, I looked quite a bit but didn't see anyone else complaining about this. I recently (3 weeks ago) upgraded to the latest SVN, and migrated configuration files, and database data to the new schema. Actually I wasn't sure what may have changed in the schema, so I created a new DB, and just migrated the contacts to the new DB. After that sometimes when clicking on reply in a message, the compose window comes up, with all details, except the recent window is blank, and the subject contains on "re:". Finally the header inserted at the top of the message "On <date>, <recipient> wrote," is missing the date and recipient data. Any ideas what could be wrong? I see no errors in apache error_log or in any files in "logs". I believe filesystem permissions are set correctly. Thanks for any help you can provide. Ethan _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

MySQL usage to much??
by crow 11 Sep '07

11 Sep '07

Hello All, I setup a Roundcube webmail, and it is working fine. Some part not but i can live with that. The problem is that my Server admin is complaining about mysql usage and threads that Roundcube make. I disabeled CACHE but that didnt help either: / enable caching of messages and mailbox data in the local database. // this is recommended if the IMAP server does not run on the same machine $rcmail_config['enable_caching'] = FALSE; // lifetime of message cache // possible units: s, m, h, d, w $rcmail_config['message_cache_lifetime'] = '10d'; Readed that on forum: http://roundcubeforum.net/forum/index.php?topic=116.msg927#msg927 Here is list of thread that are on MySQL5 > Id User Host/IP DB Time Cmd Query > or State > -- ---- ------- -- ---- --- > ---------- > 7547906 root localhost USERNAME_test 0 Query show > full processlist > 7547970 USER1_em localhost USER1_ema 0 > Sleep > > 7547997 USER1_em localhost USER1_ema 1 > Sleep > > 7546309 USER1_em localhost USER1_ema 3 > Sleep > > 7547986 USER1_em localhost USER1_ema 10 > Sleep > > 7547875 USER1_em localhost USER1_ema 84 > Sleep > > 7547789 USER1_em localhost USER1_ema 139 > Sleep > > 7546131 eximstats localhost eximstats 200 > Sleep > > 7546390 USER1_em localhost USER1_ema 259 > Sleep > > 7547605 USER1_em localhost USER1_ema 266 > Sleep > > 7546367 USER1_em localhost USER1_ema 318 > Sleep > > 7546235 USER1_em localhost USER1_ema 325 > Sleep > > 7546220 USER1_em localhost USER1_ema 502 > Sleep > > 7546209 USER1_em localhost USER1_ema 562 > Sleep > > 7546684 USER1_em localhost USER1_ema 802 > Sleep > > 7546414 USER1_em localhost USER1_ema 982 > Sleep > > 7546406 USER1_em localhost USER1_ema 991 > Sleep > > 7546358 USER1_em localhost USER1_ema 1019 > Sleep > > 7546350 USER1_em localhost USER1_ema 1029 > Sleep > > 7546141 USER1_em localhost USER1_ema 1149 > Sleep > If someone have any suggestion pls let me know. Btw: runing last SVN from roundcubemail. thNX _______________________________________________ List info: http://lists.roundcube.net/dev/

6 9

Switch character seta
by Yoshikazu Tsuji 11 Sep '07

11 Sep '07

Hello. Some mailler doesn't suuport UTF-8. So, we japanese need to switch charater set. Maybe, I think other people who use multibyte language also need to switch. This is patch to add character set selector. This code was exist in older version. ============================================================ --- ./skins/default/templates/compose.html (svn rev 667) +++ ./skins/default/templates/compose.html (changed) @@ -104,6 +104,9 @@ <roundcube:button type="input" command="list" class="button" label="cancel" /> </td> <td align="right"> +<roundcube:label name="charset" />: <roundcube:objectname="charsetSelector"> +</td> +<td align="right"> <roundcube:label name="editortype" />: <span class="radios-left"><roundcube:object name="editorSelector" tabindex="9" /></span> </td> ============================================================ This is patch to set default character set every languages. ============================================================ --- ./program/localization/index.inc_ (svn rev 672) +++ ./program/localization/index.inc (changed) @@ -88,7 +88,11 @@ 'tw' => 'zh_TW' ); -$rcube_charsets = array(); +$rcube_languages_default_charset = array( + 'en_US' => 'ASCII', + 'en_GB' => 'ASCII', + 'kr' => 'EUC-KR', + 'zh_TW' => 'BIG5', + 'zh_CN' => 'GB2312', + 'ja' => 'ISO-2022-JP' +); +$rcube_charsets = array(); ?> ============================================================ This is patch to set default character to charset_selector. ============================================================ --- rcmail_template.inc_ (svn rev 732) +++ rcmail_template.inc (changed) @@ -824,7 +824,12 @@ function rcmail_charset_selector($attrib) { global $OUTPUT; + global $sess_user_lang; + static $rcube_languages_default_charset; + if (empty($rcube_languages_default_charset)) + @include($INSTALL_PATH.'program/localization/index.inc'); + // pass the following attributes to the form class $field_attrib = array('name' => '_charset'); foreach ($attrib as $attr => $value) @@ -853,7 +858,12 @@ $select = new select($field_attrib); $select->add(array_values($charsets), array_keys($charsets)); - $set = $_POST['_charset'] ? $_POST['_charset'] : $OUTPUT->get_charset(); + // language has default charset configured + if (isset($rcube_languages_default_charset[$sess_user_lang])) + $set = $rcube_languages_default_charset[$sess_user_lang]; + else + $set = 'UTF-8'; + return $select->show($set); } ============================================================ Yoshikazu. -- /** ----------------------------------------- * Yoshikazu Tsuji @ church.ne.jp * * E-mail : yskzt(a)church.ne.jp * Web : http://church.ne.jp/ * ------------------------------------------ */ _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Ticket #1484429
by yskzt＠church.ne.jp 11 Sep '07

11 Sep '07

Hi. I thought mbstring functions can handle chr(160) in UTF-8. But, when I test my patch, mbstring return false and report error "mb_strpos(): Unknown encoding or conversion error.". like this: mb_internal_encoding("UTF-8"); $test_str = "abcd".chr(160)."efg"; mb_strpos($test_str, chr(160)) ==> false I searched web sites. - The chr(160) in UTF-8 is incorrect. (http://en.wikipedia.org/wiki/UTF-8) - In UTF-8, no-break space(nbsp) is 0xC2 0xA0. (http://www.fileformat.info/info/unicode/char/00a0/index.htm) So, how about this? =================================== --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 (rev 774) +++ main.inc 2007-09-12 01:05:31.000000000 +0900 (changed) @@ -1103,6 +1103,17 @@ return $str; } +function mb_str_replace($search_str, $replace_str, $str) + { + $current_pos = 0; + while (($found_pos = mb_strpos($str, $search_str, $current_pos)) !== false) + { + $str = mb_substr($str, 0, $found_pos).$replace_str.mb_substr($str, $found_pos + mb_strlen($search_str)); + $current_pos = $found_pos + strlen($replace_str); + } + + return $str; + } /** * Replacing specials characters to a specific encoding type @@ -1123,7 +1134,12 @@ // convert nbsps back to normal spaces if not html if ($enctype!='html') - $str = str_replace(chr(160), ' ', $str); + { + if ($OUTPUT->get_charset()=='UTF-8') + $str = mb_str_replace(chr(194).chr(160), ' ', $str); + else + $str = str_replace(chr(160), ' ', $str); + } // encode for plaintext if ($enctype=='text') =================================== Yoshikazu. On Wed, 5 Sep 2007 03:05:21 +0200, till <klimpong(a)gmail.com> wrote: > On 9/3/07, Yoshikazu Tsuji <yskzt(a)church.ne.jp> wrote: >> Hi. >> >> The following code causes Ticket #1484429 >> (http://trac.roundcube.net/trac.cgi/ticket/1484429). >> ============================================================= >> = "program/include/main.inc" function rep_specialchars_output >> >> // convert nbsps back to normal spaces if not html >> if ($enctype!='html') >> $str = str_replace(chr(160), ' ', $str); >> ============================================================= >> >> This problem is happened in multibyte enviroment (japanese too). >> In message list, function rep_specialchars_output garbled >> UTF-8 message subjects. >> >> Is converting chr(160) to space really necessary ? >> >> This is patch using multi byte functions. >> >> =============================================================== >> --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 >> +++ main.inc 2007-09-03 16:22:59.000000000 +0900 >> @@ -1122,8 +1122,17 @@ >> $enctype = $GLOBALS['OUTPUT_TYPE']; >> >> // convert nbsps back to normal spaces if not html >> - if ($enctype!='html') >> - $str = str_replace(chr(160), ' ', $str); >> + if ($enctype!='html') { >> + $current_pos = 0; >> + while(true) { >> + $found_pos = mb_strpos($str, chr(160), $current_pos); >> + if($found_pos == false) >> + break; >> + >> + $str = mb_substr($str, 0, $found_pos)." ".mb_substr($str, > $found_pos >> + 1, mb_strlen($str)); >> + $currentpos += 1; >> + } >> + } >> >> // encode for plaintext >> if ($enctype=='text') >> =============================================================== > > multibyte looks like the better alternative, especially since we are > dealing with people from different countries. And since we are using > mb already, I have no issues with this. > > Just one thing, can you add this to the trac? Please? :) > > Thanks, > Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Small LDAP patch
by Harold Aling 11 Sep '07

11 Sep '07

Dear list, I'm a novice in Roundcube 'hacking', but I plan to fix a few items in the future, since I really like RC! To enable my local LDAP addressbook, I had to change the following line in 'rcube_ldap.inc' (svn version): Index: rcube_ldap.inc =================================================================== --- rcube_ldap.inc (revision 774) +++ rcube_ldap.inc (working copy) @@ -90,7 +90,7 @@ { if ($lc = @ldap_connect($host, $this->prop['port'])) { - ldap_set_option($lc, LDAP_OPT_PROTOCOL_VERSION, $this->prop['port']); + ldap_set_option($lc, LDAP_OPT_PROTOCOL_VERSION, 3); $this->prop['host'] = $host; $this->conn = $lc; break; Maybe $this->prop['ldap_version'] can be added to the preferences? -H- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev September 2007