Dev

dev@lists.roundcube.net

1 participants
4297 discussions

[PATCH] Theaded view mode
by Vladislav Bogdanov 22 Aug '09

22 Aug '09

Hi, I'm just subscribed, so first thanks to all devs for all efforts on making RC really great. I noticed that threaded view support is planned for 0.4-beta1, so I attach a reworked patch for a threaded mailbox view mode. It is not fully perfect, but is a good (re)starting point for that anyway. Changes comparing to roundcubemail-threading-20090706.patch from http://www.atomice.com/blog/?page_id=34: 1. Ported to 0.3-SVN-r2863 2. Implemented auto expand of threads with unread messages only. 3. Added GUI configuration option for autoexpand control (on, off, unread). 4. Autoexpansion works in both static and JS message lists. 5. Automatically change between 'unread children' and message icons in a list (in parent message rows) when child message is marked read/unread. 6. Count messages, not threads in a message view pane. 7. Fixed navigation in a message view pane when threading is enabled. 8. Fixed setting folders with non-ASCII named to threaded mode. 9. Fixed incorrectly displayed rows (children of collapsed row) after multi-level expand/collapse. Simplified expand logic. 10. Fixed expand indicator is not changing when expanding/collapsing with keyboard. 11. Fixed plus key on a numeric keypad is not working (at least on linux Fedora 11 + Firefox 3.5.2). 12. Added support for whole thread expand/collapse with clicking/pressing hotkeys while holding the Control key. 13. Save expand state in env everywhere (after keypresses too). 14. Added russian translation. 15. Fixed indentation and braces style in JS to comply with RC coding style. Known issues: 1. Messages from a threaded folder are sorted not in a thread-aware order but rather in a natural order when browsing with GUI controls at the bottom of a message view pane. This is probably a minor issue because it is more convenient anyway to browse through threaded discussions with a preview pane enabled. Maybe we need to explicitly enable a preview pane for a threaded folders. 2. Last selected message is neither focused nor centered in a list when returning to a list from a message view pane. I think it is minor issue too. This patch (and original one too) is sometimes too intrusive, so it needs to be checked at least twice just not to break things. Thanks for your time, comments are welcome. Best, Vladislav --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/X6/LiAx90cn/roundcubemail-SVN-28.patch http://detached.gigo.com/rc/X6/LiAx90cn/unread_children.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

An updated Hebrew translation
by Moish 19 Aug '09

19 Aug '09

-- Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/RJ/6AfXTAfM/messages.inc http://detached.gigo.com/rc/RJ/6AfXTAfM/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

plugins updated slovenian translation
by Barbara Krasovec 17 Aug '09

17 Aug '09

Hello! I'm sending the updated slovenian translation of managesieve and password plugins. I named the files incorrectly the last time, si.SI instead of sl.SI. Please delete those files and commit the ones in the attachment. Thanks. Barbara --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/FU/3GKw654x/managesieve_passwd_s.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Forward as Attachment Plugin
by Roland Liebl 14 Aug '09

14 Aug '09

Hi all, before I release my __forward_as_attachment__ plugin any code review is appreciated! Sandro, thanks again for the images. Regards, Roland --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/a3/u3MrjBJm/forward_as_attachmen.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Password plugin
by Andrea Cappelli 14 Aug '09

14 Aug '09

Hi all I have configured the password plugin and I have created the file it_IT.inc under localization, you can find it attached if you want to include it in the main distribution I have a problem, after i change the password i get the green box with the success message, but also another message with a "SERVICE NOT AVAILABLE" error with code 500, in the middle of the page. Seems to me that the IMAP server is refusing the connection, and the only thing that can be broken is the password, so i suppose the error is in the password update in $_SESSION, but i couldn't make it work For me the solution is to add the line header("Location: index.php?_task=logout"); in password.php, on line 96, that force the user to re autenticate, but this is very dirty in my opinion Can anyone point me to a solution or give me some tip to accomplish the task? Thanks --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/YD/TiwiIPYm/it_IT.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 4

Images for "Forward as Attachment" Plugin
by Roland Liebl 14 Aug '09

14 Aug '09

Hello, can someone help to get suitable icons for a "forward as attachment" plugin. The icons (_act.png, _pas.png) should look like the default forward icon overlapped by a small clip. Many thanks to any volunteer! Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Pending hook requests
by Roland Liebl 13 Aug '09

13 Aug '09

Hello Thomas, it would be great if you could catch the time to add the following pending hook requests: #1- logout_hook http://trac.roundcube.net/ticket/1486042 [1] #2- new_message http://trac.roundcube.net/ticket/1486005 [2] #3- html_editor http://lists.roundcube.net/mail-archive/dev/2009-08/0000081.html [3] If you accept hook request #3 it would be great to have a patch for rcube_html_page.php ::: include_script. to make it possible to change the script_path (default ./program/js) to something else. The reason is, that I have to include an alternative editor.js file by my TinyMCE plugin (coding in progress). But if I use $rcmail->api->output->include_script the file is included to late and I get javascript errors. Many thanks and best regards, Roland Links: ------ [1] http://trac.roundcube.net/ticket/1486042 [2] http://trac.roundcube.net/ticket/1486005 [3] http://lists.roundcube.net/mail-archive/dev/2009-08/0000081.html _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Response to holding the delete key in the message list
by None 13 Aug '09

13 Aug '09

Hello, The following pertains only to message deleting with the config option 'display_next' set to true. When I hold the delete/backspace key down with a message selected for a couple seconds and messages are loaded from the next page, some will come back more than once. For example, say this is my message list: uid = 1 uid = 2 uid = 3 uid = 4 uid = 5 ... now if i delete the first three by holding the delete key down for a second, my message list might look like this: uid = 4 uid = 5 uid = 6 uid = 6 uid = 7 This also brings up the question as to how fast messages should be deleted while holding the delete or backspace key down, in my tests it must be 15-25 messages per second which is quicker than my reflexes are able to accurately stop deleting at a certain point. What do you guys think? Would it be best to set a timer so we can only delete 'x message per second' or maybe wait until the previous message has been deleted and the new message has come from the next page before deleting another?... Thanks! Ryan Ostrander _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

php 5.2.9 and Fileinfo
by jgeertsma＠home.nl 12 Aug '09

12 Aug '09

ok I Upped my system with PHP 5.2.9. But now I have issues with Fileinfo. Yes may it should be asked at Centos etc I know, but maybe users here can help me faster.php -v PHP Warning: PHP Startup: fileinfo: Unable to initialize module Module compiled with module API=20050922, debug=0, thread-safety=0 PHP compiled with module API=20060613, debug=0, thread-safety=0 These options need to match in Unknown on line 0 PHP 5.2.9 (cli) (built: Mar 10 2009 16:42:52) Copyright (c) 1997-2009 The PHP Group Zend Engine v2.2.0, Copyright (c) 1998-2009 Zend Technologies For now I removed the Fileinfo package. What is done with this package by RoundCube?And most important...how can I fix this issue?Thanks! _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

patches
by Terminal Addict 11 Aug '09

11 Aug '09

search.inc.patch is for program/steps/addressbook/search.inc This patch is a workaround for what appears to be a PHP bug that prevents the setting of multi-dimension associative arrays in $_SESSION (more specifically, the value of $_SESSION['search'][$search_request]). The bug causes issues with multiple LDAP searches, and "Contact not found" error messages. rcube_ldap.php.patch is for program/include/rcube_ldap.php This patch allows the user to specify multiple base DN values for searching. It will not affect users that only have a 'base_dn' value specified. With this patch, the main.inc.php file can include 'search_base_dn' => array() in an LDAP configuration. This can be helpful for people dealing with a poorly implemented LDAP structure. This patch also returns empty results for searches conducted with only the default filter (as is done when the LDAP address book is first selected). These essentially empty searches will return inconsistent results anyway. Finally, this patch will check for both case-sensitive and all lowercase fieldmap values to ensure consistent results are displayed in search lists and contact details. Both patches were made against 0.3 RC1. Kyle --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/PB/tUxKCfdd/search.inc.patch http://detached.gigo.com/rc/PB/tUxKCfdd/rcube_ldap.php.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev