Dev

dev@lists.roundcube.net

1 participants
4289 discussions

patch for subfolders display
by DrSlump 03 Oct '05

03 Oct '05

Hi, I'm playing a bit with this webmail and I've implemented the displaying of subfolders. I've done the patch on the latest release since the CVS source seem to be badly broken when I checked out. I added three new functions to 'program/steps/mail/func.inc' ---- function rcmail_build_folder_tree( &$arrFolders, $folder, $path = '' ) { $pos = strpos($folder, '/'); if ($pos !== false) { $subFolders = substr($folder, $pos+1); $currentFolder = substr($folder, 0, $pos); } else { $subFolders = false; $currentFolder = $folder; } $path .= $currentFolder; if (!isset($arrFolders[ $currentFolder ])) { $arrFolders[ $currentFolder ] = array( 'id' => $path, 'name' => $currentFolder, 'folders' => array(), ); } if (!empty($subFolders)) { rcmail_build_folder_tree( $arrFolders[$currentFolder]['folders'], $subFolders, $path.'/' ); } } function rcmail_render_folder_tree_html( &$arrFolders, &$special, &$mbox, $nestLevel = 0 ) { global $JS_OBJECT_NAME, $IMAP; $idx = 0; $out = ''; foreach ($arrFolders as $key=>$folder) { $zebra_class = ($nestLevel*$idx)%2 ? 'even' : 'odd'; $folder_lc = strtolower($folder['id']); if (in_array($folder_lc, $special)) $foldername = rcube_label($folder_lc); else $foldername = $folder['name']; if ($unread_count = $IMAP->messagecount($folder['id'], 'UNSEEN')) $foldername .= sprintf(' (%d)', $unread_count); $out .= sprintf('<li class="mailbox %s %s%s%s"><a href="#%s" onclick="return %s.command(\'list\',\'%s\')" onmouseup="return %s.mbox_mouse_up(\'%s\')">%s</a>'."\n", preg_replace('/[^a-z0-9\-_]/', '', $folder_lc), $zebra_class, $unread_count ? ' unread' : '', $folder['id']==$mbox ? ' selected' : '', $folder['id'], $JS_OBJECT_NAME, $folder['id'], $JS_OBJECT_NAME, $folder['id'], rep_specialchars_output($foldername)); if (! empty($folder['folders'])) $out .= '<ul>' . rcmail_render_folder_tree_html( $folder['folders'], $special, $mbox, $nestLevel+1 ) . "</ul>\n"; $out .= "</li>\n"; $idx++; } return $out; } function rcmail_render_folder_tree_select( &$arrFolders, &$special, &$mbox, $nestLevel = 0 ) { global $IMAP; $idx = 0; $out = ''; foreach ($arrFolders as $key=>$folder) { $out .= sprintf('<option value="%s">%s%s</option>'."\n", $folder['id'], str_pad('', $nestLevel*2*6, ' '), rep_specialchars_output($folder['name'])); if (! empty($folder['folders'])) $out .= rcmail_render_folder_tree_select( $folder['folders'], $special, $mbox, $nestLevel+1 ); $idx++; } return $out; } ------- Then changed quite a bit the function rcmail_mailbox_list() ------- function rcmail_mailbox_list($attrib) { global $IMAP, $CONFIG, $OUTPUT, $JS_OBJECT_NAME, $COMM_PATH; static $s_added_script = FALSE; static $arrFolders; $type = $attrib['type'] ? $attrib['type'] : 'ul'; $add_attrib = $type=='select' ? array('style', 'class', 'id', 'name', 'onchange') : array('style', 'class', 'id'); if ($type=='ul' && !$attrib['id']) $attrib['id'] = 'rcmboxlist'; // allow the following attributes to be added to the <ul> tag $attrib_str = create_attrib_string($attrib, $add_attrib); $out = '<' . $type . $attrib_str . ">\n"; // add no-selection option if ($type=='select' && $attrib['noselection']) $out .= sprintf('<option value="0">%s</option>'."\n", rcube_label($attrib['noselection'])); $mbox = $IMAP->get_mailbox_name(); // for these mailboxes we have localized labels $special_mailboxes = array('inbox', 'sent', 'drafts', 'trash', 'junk'); //build the folders tree if (empty($arrFolders)) { // get mailbox list $a_folders = $IMAP->list_mailboxes(); foreach ($a_folders as $folder) { rcmail_build_folder_tree( $arrFolders, $folder ); } } if ($type=='select') { $out .= rcmail_render_folder_tree_select( $arrFolders, $special_mailboxes, $mbox ); } else { $out .= rcmail_render_folder_tree_html( $arrFolders, $special_mailboxes, $mbox ); } if ($type=='ul') $OUTPUT->add_script(sprintf("%s.gui_object('mailboxlist', '%s');", $JS_OBJECT_NAME, $attrib['id'])); return $out . "</$type>"; } ---- The css also needs a bit of tweaking, basically just add the following rules to 'mail.css' ----- #mailboxlist ul { list-style: none; padding:0; margin:0; } #mailboxlist ul li { padding-left: 15px; background-position: 25px 1px; } #mailboxlist li.selected li { background-color: #F9F9F9; } #mailboxlist li.unread li { font-weight: normal; } #mailboxlist li.unread li.unread { font-weight: bold; } #mailboxlist li.selected li a{ color: black; font-weight: normal; } ----- And remove the 'height' propery from '#mailboxlist li' ! Finally, in 'program/js/app.js' replace the method 'this.select_mailbox()' with the next one ------ this.select_mailbox = function(mbox) { if (this.gui_objects.mailboxlist) { var item, reg, text_obj; var s_mbox = String(mbox).toLowerCase().replace(this.mbox_expression, ''); var s_current = this.env.mailbox.toLowerCase().replace(this.mbox_expression, ''); var nodes = this.gui_objects.mailboxlist.getElementsByTagName('LI'); for (var n=0; n<nodes.length; n++) { item = nodes[n]; if (item.className && item.className.indexOf('mailbox '+s_mbox+' ')>=0) this.set_classname(item, 'selected', true); else if (item.className && item.className.indexOf('mailbox '+s_current)>=0) this.set_classname(item, 'selected', false); } } this.env.mailbox = mbox; }; ------ I'm sorry for this way of sending the patch but it's late and knowing myself, if I wait for the CVS version to be fixed I will forget to send it :( ciao, ivan

1 0

roundcube and subfolders (courier-imap)
by Florian Munz 03 Oct '05

03 Oct '05

Hey, thanks for this great webmail client, it is just the thing I am searching for. I have only one issue: Is there support for subfolders? And specifically with courier-imap, every folder is subfolder of the INBOX. I tried playing with imap_root but that didn't changed it. I attached a screenshot thanks, Florian

2 1

CVS version bugs
by Jon Wolf 03 Oct '05

03 Oct '05

Installed a copy of the CVS code and stumbled across some major bugs: 1)SMTP broken! All mail sending fails with the following error: Warning: main(Net/SMTP.php) [function.main]: failed to open stream: Datei oder Verzeichnis nicht gefunden in /home2/wolf/public_html/domojo/CVS/program/include/rcube_smtp.inc on line 24 Fatal error: main() [function.require]: Failed opening required 'Net/SMTP.php' (include_path='.:/usr/lib/php:/usr/local/lib/php:program:program/lib') in /home2/wolf/public_html/domojo/CVS/program/include/rcube_smtp.inc on line 24 2)User preferences broken. When save is clicked in the user preferences screen the following error results: Fatal error: Call to a member function affectedRows() on a non-object in /home2/wolf/public_html/domojo/CVS/program/include/rcube_db.inc on line 243

3 2

strlen(x)
by David Saez Padros 03 Oct '05

03 Oct '05

Hi !! there are sevral places in index.php whith conditions like if ($_action=='error' && strlen($_GET['_code'])) where perhaps it could be the same to do if ($_action=='error' && isset($_GET['_code'])) it's not exaclty the same as if $_GET['_code'] is an empty string the first (original) condition will suceed but not the last proposed one. The advantatge of the last one is that it does not produce any warning in any error_reporting level. Looks like there are many places when this change is feasible, specially if strlen(x) is a way to test if x has been defined or not. other, not so obvious places where that change could be made are, i.e, change: $_framed = ( $_GET['_framed'] || $_POST['_framed'] ); for $_framed = ( isset($_GET['_framed']) || isset($_POST['_framed']) ); this will work always unless there is any situation where _framed could be zero, can this happen ? -- Best regards ... ---------------------------------------------------------------- David Saez Padros http://www.ols.es On-Line Services 2000 S.L. e-mail david(a)ols.es Pintor Vayreda 1 telf +34 902 50 29 75 08184 Palau-Solita i Plegamans movil +34 670 35 27 53 ----------------------------------------------------------------

2 1

support for PEAR:DB
by David Saez Padros 02 Oct '05

02 Oct '05

Hi !! I just added the necessary changes for PEAR.DB + database replication support on CVS, running configuration needs to be updated as now the database backed is configured with just two variables, one PEAR DSN for read/write database and another optional one for the read only database. In Master/slave replication schemas read/write is the master (usually remote and thuis slower) and read only is the slave (usually local and thus faster) -- Best regards ... ---------------------------------------------------------------- David Saez Padros http://www.ols.es On-Line Services 2000 S.L. e-mail david(a)ols.es Pintor Vayreda 1 telf +34 902 50 29 75 08184 Palau-Solita i Plegamans movil +34 670 35 27 53 ----------------------------------------------------------------

1 0

Session Invalid or Expired
by Matthew Nessworthy 02 Oct '05

02 Oct '05

Ahoy everyone, i love the look of roundcube and the interface looks very slick, but i seem to have run into a problem, i continually get session invalid or expired when trying to log on and when/if i get into the account as soon as i do an action it boots me out with the same error. Does anyone have any ideas? Cheers, Matthew

1 0

good article on webmail features..
by Praneet Kandula 01 Oct '05

01 Oct '05

Hey guys, I came across this article on what to expect from a modern webmail system from a pretty prominent designer. Perhaps we can try to include some of these in our roadmap? http://kurafire.net/log/archive/2005/08/25/perfect-webmail-system -- Praneet Kandula

1 0

Hi Everyone
by Praneet Kandula 01 Oct '05

01 Oct '05

I just wanted to introduce myself: My name's Praneet Kandula, and I develop with PHP, but am also pretty good on the design front with XHTML, CSS and JS. I look forward to helping out with roundcube when I can.

1 0

Save drafts
by Ben Hall 30 Sep '05

30 Sep '05

Hello, I downloaded and installed RoundCube yesterday. What an excellent webmail program! While I look forward to spell check, the real feature that I'd like to see is the ability to save to draft in the compose window. Is there a way to do this that I'm just missing? Also, the tar.gz files that I downloaded from the site didn't have the index.php file. I had to grab the CVS version. Finally, I have very basic instructions that I wrote as I set it up yesterday. I would be happy to post them somewhere if it would help. Cheers, Ben

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev