Dev

dev@lists.roundcube.net

2 participants
4318 discussions

reduce network requests by consolidating icon images
by Nathan Kinkade 05 Jun '09

05 Jun '09

I've been spending a lot of time in Firebug with RoundCube the past few weeks. One thing I've noticed is that there are quite a lot of network requests to freshly load the front page. With the default theme there are around 45 separate requests for a little less than 250K. I was asking myself how to reduce the number of requests and was reminded of something interesting that I had noticed Gmail doing, and that is to consolidate many icons into a single image and then use CSS to position the image as the background of a fixed width/height block-level element. As I went to implement this, I began to realize that not only does this approach reduce the number of network requests, but it also seems to simplify the code a bit. With this method the code doesn't have to worry at all about images or file names, but becomes somewhat image-agnostic by only specifying the *type* of behavior it would like to see in a given location. How that bahavior is implemented then becomes a simple matter of CSS. Here is the consolidated image with not all but most of the usual icons: https://natha.nkinka.de/devmail/skins/default/images/icons/rc_icons.png And here are the patches to implement this: http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=84a7acd0f42e3c3… I found that doing this reduced the number of requests on a clean load of the main mailbox view from 45 to 35, which is fairly significant. It does add about 5K to the page size because it brings along a number of unneeded icons for that page. 10 less requests may not be perceptible for many people running on a fast machine with broadband Internet to a server that isn't very loaded. However, for a busy machine, perhaps an installation of RoundCube serving webmail for a university, for example, 10 less requests per fresh page load could make a noticeable difference. 10 less requests will probably also make a noticeable difference for those on a high latency connection, where 5K extra is less of a problem than 10 more network requests. I have no idea whether this is of any use or interest to anyone else, but I thought I'd share my experiment with the list. Nathan _______________________________________________ List info: http://lists.roundcube.net/dev/

7 15

Skins Location of plugins
by Roland Liebl 04 Jun '09

04 Jun '09

I send this message again, because it was sorted into a wrong thread. ----- Original Message ----- From: Roland Liebl To: dev(a)lists.roundcube.net Sent: Sunday, May 17, 2009 6:16 AM Subject: Load skins templates from plugin directory Hello Devs, the attached patch is very usefull, IMO. It loads plugin templates from the plugin folder. It is similar to what you are already doing by the localization. E.g.: $rcmail->output->send("settings.account") ... will parse the template from ./[conf:plugins_dir]/settings/skins/[conf:skin]/templates/account.html. So we could use a "Domain Prefix" for plugin templates. It would make it easier to install a plugin, because the user does not have to copy things into the main skin folder. Please let me know, if you will incorporate the patch. I'm in process to update MyRoundCube to use the new Plugin API and have to know if I can rely on this method. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

Get rid of skip_deleted
by A.L.E.C 04 Jun '09

04 Jun '09

This option causes many problems. I like to get rid of it. What you think? There are related issues here and there, and it will be hard to fix them all if we need to live with this option. Removing this option will be of course a fine performance improvement. E.g. next/prev buttons in message page are not skip_deleted aware. Fixing this will require to add SEARCH/SORT ALL UNDELETED call with result sorting. There are related issues in searching and caching: http://trac.roundcube.net/ticket/1485634 -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

SEARCH
by Sandro Pazzi 04 Jun '09

04 Jun '09

Hi all, It seems that the search don't search the email but only the object and the body. Are right or was a bug? Thanks -- Sandro Pazzi IdWeb s.r.l. Viale Romagna 69/A - 06012 Citta' di Castello (PG) Tel. 075 851 97 28 Fax 075 851 97 30 _______________________________________________ List info: http://lists.roundcube.net/dev/

4 7

Updated galician translation
by David Garabana Barro 03 Jun '09

03 Jun '09

-- David Garabana Barro jabber & google talk ID: david(a)garabana.com Clave pública PGP/GPG: http://davide.garabana.com/pgp.html --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/yM/N5TIvYXQ/labels.inc http://detached.gigo.com/rc/yM/N5TIvYXQ/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Spanish Argentina (es_AR) translation update
by Javier Smaldone 03 Jun '09

03 Jun '09

Hi. This is the updated es_AR (Español, Argentina) translation. Regards, -- Javier Smaldone javier(a)smaldone.com.ar http://www.smaldone.com.ar/ - http://blog.smaldone.com.ar --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/TH/j6pQgXwQ/labels.inc http://detached.gigo.com/rc/TH/j6pQgXwQ/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Spanish (es_ES) translation update
by Javier Smaldone 03 Jun '09

03 Jun '09

Hi. This is the updated es_ES (Español, España) translation. Regards, -- Javier Smaldone javier(a)smaldone.com.ar http://www.smaldone.com.ar/ - http://blog.smaldone.com.ar --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/WN/jGkEHmus/labels.inc http://detached.gigo.com/rc/WN/jGkEHmus/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Encoding issue, possible workaround
by Eric Stadtherr 03 Jun '09

03 Jun '09

Devs, I recently received a bulk e-mail from an event organizer that displayed in RoundCube (using Firefox 3) with the little square hex-code glyphs in place of some of the punctuation marks. I researched why this was happening, and tracked it down to an encoding issue. The text/html message part in the e-mail source specified iso-8859-1 encoding. After RoundCube converted the message part to UTF-8, there were still non-UTF8 characters in the resulting text. One such character was 0x92, which is not even a valid iso-8859-1 character. It turns out that the message originator must have been using Windows-1252 encoding (in which 0x92 is a single-quote character, which was correct in the context in which it appeared), but incorrectly specified iso-8859-1 encoding in the MIME message. The Windows-1252 character set is effectively a superset of the iso-8859-1 character set, replacing some of the seldom-used control character code points with additional punctuation and accent characters. Some mail agents incorrectly blur the line between these two encodings, and send Windows-1252 characters in iso-8859-1 messages. The following workaround (in rcube_charset_convert()) corrects the issue (at least for my one test case): // Workaround for mail agents that include Windows-1252 characters // in text advertised as ISO-8859-1 if ($from == "ISO-8859-1" && preg_match("/[\x80-\x9F]/", $str)) $from = "WINDOWS-1252"; What does everyone think of including a workaround like this? I'm generally reluctant to work around improper behavior from other software, but this particular kind of relaxed interpretation seems common (check out the ISO-8859-1 page on Wikipedia). -- Eric Stadtherr estadtherr(a)gmail.com _______________________________________________ List info: http://lists.roundcube.net/dev/

5 9

[Plugin API] request response event
by A.L.E.C 03 Jun '09

03 Jun '09

In http_response() we have: if (response.action == 'list') this.triggerEvent('listupdate', { folder:this.env.source, rowcount:this.contact_list.rowcount }); I think we should add (instead) a "global" event at the end of http_response function: this.triggerEvent('http_response', { action:response.action }); So, plugins could bind to one (http_response) event and there just check for which action it's executed. Am I right? -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 9

Re: [RCD] Plugin WIKI page
by Roland Liebl 02 Jun '09

02 Jun '09

----- Original Message ----- From: "Cor Bosman" <cor(a)xs4all.nl> To: "Roland Liebl" <roland(a)roland-liebl.de> Sent: Monday, June 01, 2009 9:31 AM Subject: Re: [RCD] Plugin WIKI page > Hi Roland, a tip concerning your limit recipients plugin. Check out > function imap->decode_address_list(). > You can feed it a ['header']['from'] and it will return an array of valid > recipients. Much cleaner than what you do now. > > I had to find that myself as well..unfortunately the docs dont mention > such handy functions. > > Cor > > > Thanks for the hint. Next update of limit_recipients will do the check by ... function check_recipients($args){ $rcmail = rcmail::get_instance(); $recipients = count($rcmail->imap->decode_address_list($args['headers']['To'])) + count($rcmail->imap->decode_address_list($args['headers']['Cc'])) + count($rcmail->imap->decode_address_list($args['headers']['Bcc'])); if($recipients > $rcmail->config->get('limit_recipients')){ if($rcmail->config->get('limit_recipients_log')){ $this->log("Limit Recipients: " . $recipients . " > " . $rcmail->config->get('limit_recipients') . " --> " . $_SESSION['username'] . " --> IP: " . $this->getVisitorIP()); } $this->add_texts('localization/'); $rcmail->output->command('display_message',sprintf(rcube_label('limit_recipients_msg','limit_recipients'),$rcmail->config->get('limit_recipients')),'error'); $rcmail->output->send('iframe'); } return $args; } _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev