Resolved like inspired by Robert King. Thanks! Patch is not required
anymore.
I would just need your opinion about:
http://lists.roundcube.net/mail-archive/dev/2009-05/0000053.html
Regards,
Roland
_______________
function _load_config($plugin)
{
$rcmail = rcmail::get_instance();
$config = $rcmail->config->get('plugins_dir') . "/" . $plugin .
"/config/config.inc.php";
if(file_exists($config))
include $config;
else if(file_exists($config . ".dist"))
include $config . ".dist";
if(is_array($rcmail_config)){
$rcmail->config->merge($rcmail_config);
}
}
> ----- Original Message -----
> From: "Robert King" <robk(a)mun.ca>
> To: "RoundCube Dev" <dev(a)lists.roundcube.net>
> Sent: Sunday, May 17, 2009 5:42 PM
> Subject: Re: [RCD] Load plugin config from plugin folder
>
>
>> On Sun, 17 May 2009 13:03:37 -0230, Robert King <robk(a)mun.ca> wrote:
>>> In my plugins I've been calling a function in the plugin init of:
>>>
>>> class plugin_name extends rcube_plugin
>>> {
>>>
>>> public function init()
>>> {
>>> _load_config();
>>> }
>>>
>>> private function _load_config()
>>> {
>>> include('config.inc.php');
>>> $this->config = (array) $_config;
>>> }
>>>
>>> }
>>
>> Forgot this important detail:
>>
>> class plugin_name extends rcube_plugin
>> {
>> private $config;
>> ...
>> }
>>
>> --
>> Robert King
>> System Administrator
>> Computing & Communications
>> Memorial University
>> _______________________________________________
>> List info: http://lists.roundcube.net/dev/
>>
>
>
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi all, a plugin question ive been wondering about. What is the
recommended way for a plugin to save longterm non-user configurable
data? Just an example, lets say I want to keep track on if ive shown
a MOTD page to a user, id have to save that information. But some
plugins may have much more extensive needs here. Basically any data
you want to save immediately without going through a save preferences
click.
It might be nice to have some api functions that allow a plugin to
save this kind of data without having to construct your own SQL. Any
ideas about this? Maybe it exists already and I just couldnt find.
Also, looking at the code it seems as if plugins through
save_preferences hook can add saved prefs, but this has a potential
for unintentional overlap. If 2 plugins decide to use the same name,
you'll override a previous config with the same name. Maybe RC should
add the plugin name or something to the prefs key?
Regards,
Cor
_______________________________________________
List info: http://lists.roundcube.net/dev/
I've rewritten my managesieve patch using plugin api and I've found a few issues:
1. Templates from plugin directory. I've commited patch from Roland Liebl
and it's possible now, but... images path is hardcoded to "plugins/plugin_name/...",
and will not work if someone will change plugins_dir.
2. include_script() includes script after rcmail variable initialization.
That's ok, but there's a one situation when it's a problem.
For 'html' output I must write:
$this->rc->output->add_script(sprintf("rcmail.managesieve_updatelist('%s', '%s', %d);",
isset($new) ? 'add' : 'update', $this->form['name'], $fid), 'foot');
instead of more unified form:
$this->rc->output->command('managesieve_updatelist', isset($new) ? 'add' : 'update', $this->form['name'], $fid);
3. Localization folder name should be constant for all plugins (hardcoded in api).
Creating plugins translator will be simpler then.
--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Project Developer http://roundcube.net
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I’ve attached an updated Swedish localization of messages.inc.
Regards,
Jonas Nasholm
Bitfuse Network
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Y7/DpA6h7k5/sv_SE.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Does anyone know why http://roundcubeforum.net is unresponsive?
I seem to get redirected to some gaming website.
I tried asking in the IRC channel last night, but I think everyone was
asleep :-)
Is the forum site run by the roundcube admins? Does anyone know if it will
be coming back?
--
Michael Crumm
mcrumm(a)gmail.com
_______________________________________________
List info: http://lists.roundcube.net/dev/
> Message: 10 Date: Tue, 19 May 2009 15:10:26 +0200 From: till <klimpong(a)gmail.com>
> Subject: [RCD] Cache buster? (Re: Trunk 2501 error javascript in osx)
>> > On Tue, 19 May 2009 14:11:13 +0200, "A.L.E.C" <alec(a)alec.pl> wrote:
>>> >> Sandro Pazzi wrote:
>>> >>
>>>> >>> I've installed the last version and I find this errors in osx firefox
>> > and
>>>> >>> safari.
>>>> >>>
>>>> >>> All works fine in firefox and safari on windows.
>>> >>
>>> >> Css cache issue. Clear browser's cache.
>
> Do we need a cache buster? E.g. skins/default/css/main.css?v=RCVERSION
>
> Or we include the version in the filename for releases?
>
> Thoughts anyone?
>
I think version in the filename is better, that way browsers can cache the css.
The same can be done for js files. When I patched a js file to solve a bug,
that required full refresh in clients; you don't know when the cache will be
invalidated, somehow file mtime is not very reliable (?)
--
Gokdeniz Karadag
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi RoundCube users and list lurkers
We've recently published two new releases of the RoundCube Webmail package.
Version 0.2.2 is a minor update to the stable 0.2 branch. Beside some
bug fixes this version now supports STARTTLS for IMAP connections.
A bit further down the road we have the 0.3-beta version which now
includes the long awaited plugin API. This version is still under
development and we don't recommend to replace a productive version
with 0.3-beta. Nevertheless we'd like you to install and test it and
get the idea of how to write plugins. Read
http://trac.roundcube.net/wiki/Doc_Plugins to get started and find
some sample plugins within the package or more by browsing the SVN
repository: http://trac.roundcube.net/browser/trunk/roundcubemail/plugins
You can download both releases from http://roundcube.net/downloads and
as usual you're kindly requested to submit your reports to our bug
tracker: http://trac.roundcube.net/report
Have a lot of fun!
Thomas
_______________________________________________
List info: http://lists.roundcube.net/dev/
I dropped a note to brett [at] ... I'm just a moderator and can't do anything. But it looks like some kind of database injection:
<META HTTP-EQUIV="Refresh"
CONTENT="0; URL=http://xsaimex.mybrute.com/"><br />
<b>Warning</b>: include_once(includes/VBSEO_VB_CONFIG) [<a href='function.include-once'>function.include-once</a>]: failed to open stream: No such file or directory in <b>/var/www/vhosts/roundcubeforum.net/httpdocs/vbseo.php ...........
_______________________________________________
List info: http://lists.roundcube.net/dev/
On Tue, May 19, 2009 at 3:10 PM, Sandro Pazzi <sandro(a)idweb.it> wrote:
> On Tue, 19 May 2009 14:11:13 +0200, "A.L.E.C" <alec(a)alec.pl> wrote:
>> Sandro Pazzi wrote:
>>
>>> I've installed the last version and I find this errors in osx firefox
> and
>>> safari.
>>>
>>> All works fine in firefox and safari on windows.
>>
>> Css cache issue. Clear browser's cache.
>
> You are right.
>
> Thanks
>
Do we need a cache buster? E.g. skins/default/css/main.css?v=RCVERSION
Or we include the version in the filename for releases?
Thoughts anyone?
Till
_______________________________________________
List info: http://lists.roundcube.net/dev/