Dev

dev@lists.roundcube.net

1 participants
4297 discussions

Proposed patch against against 1732
by David Lublink 05 Sep '08

05 Sep '08

Hello, I received an email today with 232 emails listed in the To: header. Most of them had accents in the names so there was about 200 encoding emails in the To: header. The method responsable for this is decode_mime_string() and is recursive. My server stops recursion at the 150th level. So the email caused PHP to crash and a blank page to be shown. I wrote the following patch against revision 1732 which will resolve the issue. I changed the recursion for iteration : Index: program/include/rcube_imap.php =================================================================== --- program/include/rcube_imap.php (revision 1732) +++ program/include/rcube_imap.php (working copy) @@ -2416,9 +2416,10 @@ function decode_mime_string($input, $fallback=null) { $out = ''; + $work = $input; - $pos = strpos($input, '=?'); - if ($pos !== false) + // Iterate instead of recursing, this way if there are too many values we don't have stack overflows + while( strpos($work, '=?') ) { // rfc: all line breaks or other characters not found // in the Base64 Alphabet must be ignored by decoding software @@ -2436,7 +2437,7 @@ $rest = substr($input, $end_pos+2); $out .= rcube_imap::_decode_mime_string_part($encstr); - $out .= rcube_imap::decode_mime_string($rest, $fallback); + $work = $rest; return $out; } Please include this into trunk of round cube. Additionally, it would be nice if you patched this to the stable version. To patch this to the stable version, you'll want to change rcube_imap.php to rcube_imap.inc before patching. Using patch that comes with gentoo, it patched fine with fuzz. I tested this patch on trunk and on the stable release 0.1.1. I have noticed that PHP is slow on calling methods statically, so the iteration will be a bit faster than the recursion. :D Please let me know, David --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/WA/DcyDmMrV/against-1732.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Why can't use both sql and ldap address book in svn version?
by Zhang Huangbin 04 Sep '08

04 Sep '08

Hi, developers. I'm using Roundcube-0.1.1 with some plugins in product environment, and testing roundcubemail svn version. I'm confused why we can't use both sql and ldap address book in roundcube svn version. ----<-- main.inc.php ---- // This indicates which type of address book to use. Possible choises: // 'sql' (default) and 'ldap'. // If set to 'ldap' then it will look at using the first writable LDAP // address book as the primary address book and it will not display the // SQL address book in the 'Address Book' view. $rcmail_config['address_book_type'] = 'ldap'; ----<---- If i set it to 'sql', and configured ldap address book, it will list both two in address book panel, but when i click the ldap address book, it raised database error. If i use only ldap, it works. How can i use both address book types? Thanks very much. -- Zhang Huangbin _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

encoding of attachment headers
by Arkadiusz Miskiewicz 03 Sep '08

03 Sep '08

Hello, I need you opinion about http://trac.roundcube.net/ticket/1485151 Does anyone know why http://trac.roundcube.net/changeset/1576 was introduced (by alec)? The pear bug mentioned in changelog doesn't explain the change since tspecials need only escaping, not rfc2184 quoting. The problem becomes bigger (for me) because it seems that even major email providers in my country don't support rfc2184 (I'm pinging these). google mail uses quoted printable there ... which looks wrong. I'm lost. -- Arkadiusz Miśkiewicz PLD/Linux Team arekm / maven.pl http://ftp.pld-linux.org/ _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Problem with large attachments
by Javier Smaldone 02 Sep '08

02 Sep '08

Hi. I'm having an issue with large attachments (I've tried with a 5Mb file) with both RC 0.1-rc2 and 0.2-alpha. I've setting the PHP max upload size and the files are upload right (to /tmp and then moved to RC temp/), but sending the message fails without error (just the "sending message" notification, but nothing happens). I've also noted that the temp/ directory contains a lot of files (maybe all the files the users have sent?). Any clue? -- Javier Smaldone javier(a)smaldone.com.ar _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

updated Hebrew translation ( second edition )
by Moish 01 Sep '08

01 Sep '08

Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/al/MONJe4y0/labels.inc http://detached.gigo.com/rc/al/MONJe4y0/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

An updated Hebrew translation
by Moish 01 Sep '08

01 Sep '08

Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/NK/t8ZqQn90/labels.inc http://detached.gigo.com/rc/NK/t8ZqQn90/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Indonesian Translation update
by Arya Sabda 31 Aug '08

31 Aug '08

Hi All, sorry for the long time of translation, please see the attachment and CMIIW when translating them :) --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/te/Xse1VRO9/labels.inc http://detached.gigo.com/rc/te/Xse1VRO9/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] I have modified some function to use with filter rules
by San 31 Aug '08

31 Aug '08

sorry, database schema for use with this script CREATE TABLE IF NOT EXISTS `mailrules` ( `mailrule_id` int(11) NOT NULL auto_increment, `order` tinyint(4) NOT NULL default '0', `name` varchar(128) default NULL, `from` varchar(128) default NULL, `to` varchar(128) default NULL, `subject` varchar(128) default NULL, `cc` varchar(128) default NULL, `bcc` varchar(128) default NULL, `replyto` varchar(128) default NULL, `count` int(10) unsigned NOT NULL default '0', `user_id` int(10) unsigned NOT NULL default '0', `location` varchar(128) default NULL, PRIMARY KEY (`mailrule_id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; On Fri, Aug 29, 2008 at 7:55 PM, Roland Liebl <roland(a)liebl.ath.cx> wrote: > Hello San, > > I had a brief look on your patch. > > There is a new database table mailrules necessary. Structure? > Patch for db.php.inc.dist? > > Isn't there a template to manage mail rules? > > Please send me a complete zip of all modified file. > Sorry I'm on windows and can't use .patch files at all. > > Regards, > Roland > > On Fri, 29 Aug 2008 14:04:24 +0700, San <sansez(a)gmail.com> wrote: >> from this ticket : http://trac.roundcube.net/ticket/1484890 >> >> I have modified some function, about filter rules which use search >> function from rcube_imap.php >> I think it ok, please use this filter in next version of roundcube >> >> filter is the features I like.... >> >> sorry for my poor English. >> > > -- Sincerely, Nantharat Puwarang Sansez [at] Gmail [dot] com LPIC-1 : Linux Professional Institute Certified _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Plugin API
by Roland Liebl 31 Aug '08

31 Aug '08

Hi there, I have coded some stuff, not the way it is discussed at the moment. I started much sooner coding a plugin API. Test Server: http://www.roland-liebl.de/webmail user: demo(a)liebl.ath.cx pass: demo Download a complete package (based on SVN 1711) @ http://www.roland-liebl.de/dl/roundcube/ Even if you don't like the API please see the features I have implemented: http://www.roundcubeforum.net/showthread.php?t=3389 Most things are worth at least a review. Maybe you want to adapt things which are not hmailserver specific into default RoundCube. -Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Folder collapsing (#1267231)
by Robin Elfrink 29 Aug '08

29 Aug '08

Hi, I fully implemented collapsing folders. Collapsed/expanded state of a folder is saved in the user's preferences. Please test. I'd like specific feedback on the following: - the structure of the 'string' I use to save the state of collapsed/expanded folders - the place where I save the preferences (now in steps/mail/func.php). Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/GO/9vfmP3JZ/_1267231.20080612114.patch http://detached.gigo.com/rc/GO/9vfmP3JZ/_1267231.folder-coll.png http://detached.gigo.com/rc/GO/9vfmP3JZ/_1267231.folder-expa.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

5 23

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev