Dev

dev@lists.roundcube.net

1 participants
4293 discussions

recipient and subject missing when replying
by Glen Ogilvie 26 Nov '07

26 Nov '07

Hi, I've got a tricky roundcube problem. It seems related specifically to our communigate pro imap server. When clicking on reply, none of the header information that should be in a reply gets populated (subject, original email date, recipient). I've noticed that this always happens when the preview pane is turned on, and only sometimes happens when the preview pane is off. I've been using roundcube elsewhere for quite some time with a courier imap server, and don't have the same problems. I've looked at compose.inc, rcube_imap.inc and imap.inc, however, I am struggling to find out the cause of this problem. Any ideas of what to look for would be appricated. I am a php developer, so happy to hunt around in the code, just struggling to get my head around what is supposed to happen. Running rev 912 from svn. If I set $rcmail_config['enable_caching'] = FALSE; Then this problem occurs all of the time. I've done a tcpdump of the traffic between roundcube and the imap server. Something that I don't quite understand is why the appears to be 2 imap queries. What I see is: fh0 UID FETCH 6095 (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES)]) and then fh0 FETCH 927 (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES)]) Not sure why it does this twice. Also, I noticed that it's trying to fetch "Reply-to" which is not returned from Imap. Any ideas. TCP dump below: * OK CommuniGate Pro IMAP Server 4.3.6 at oss.co.nz ready cp01 CAPABILITY * CAPABILITY IMAP4 IMAP4REV1 ACL NAMESPACE UIDPLUS IDLE LITERAL+ QUOTA ID MULTIAPPEND LISTEXT CHILDREN BINARY LOGIN-REFERRALS STARTTLS AUTH=LOGIN AUTH=PLAIN AUTH=CRAM-MD5 AUTH=DIGEST-MD5 AUTH=MSN cp01 OK completed a000 AUTHENTICATE CRAM-MD5 a000 OK completed ns1 NAMESPACE * NAMESPACE (("" "/")) (("~" "/")) (("~public/" "/")) ns1 OK completed sel1 SELECT "INBOX" * FLAGS (\Answered \Flagged \Deleted \Seen \Draft $MDNSent $Hidden) * OK [PERMANENTFLAGS (\Answered \Flagged \Deleted \Seen \Draft $MDNSent $Hidden)] limited * 937 EXISTS * 0 RECENT * OK [UIDNEXT 6107] predicted next UID * OK [UIDVALIDITY 278662535] UIDs valid sel1 OK [READ-WRITE] SELECT completed fh0 UID FETCH 6095 (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES)]) * 927 FETCH (BODY[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES)] {259} From: "Someone" <removed> To: <gogilvie(a)oss.co.nz> Subject: WR for meeting Date: Wed, 7 Nov 2007 11:35:19 +1300 Content-Type: text/plain; .charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <auto-000004410094(a)oss.co.nz> UID 6095) fh0 OK completed fh1 UID FETCH 6095 (UID RFC822.SIZE FLAGS INTERNALDATE) * 927 FETCH (UID 6095 RFC822.SIZE 1576 FLAGS (\Seen) INTERNALDATE "06-Nov-2007 22:35:21 +0000") fh1 OK completed srch1 SEARCH UID 6095 * SEARCH 927 srch1 OK completed F1247 FETCH 927 (BODYSTRUCTURE) * 927 FETCH (BODYSTRUCTURE ("text" "plain" ("charset" "us-ascii") NIL NIL "7bit" 746 24 NIL NIL NIL NIL)) F1247 OK completed FUID FETCH 927 (UID) * 927 FETCH (UID 6095) FUID OK completed fh0 FETCH 927 (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES)]) * 927 FETCH (BODY[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES)] {259} From: "Someone" <removed> To: <gogilvie(a)oss.co.nz> Subject: WR for meeting Date: Wed, 7 Nov 2007 11:35:19 +1300 Content-Type: text/plain; .charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <auto-000004410094(a)oss.co.nz> ) fh0 OK completed fh1 FETCH 927 (UID RFC822.SIZE FLAGS INTERNALDATE) * 927 FETCH (UID 6095 RFC822.SIZE 1576 FLAGS (\Seen) INTERNALDATE "06-Nov-2007 22:35:21 +0000") fh1 OK completed ftch FETCH 927 (BODY.PEEK[1]) * 927 FETCH (BODY[1] {746} The WR for the meeting this morning: [cut] ) ftch OK completed I LOGOUT * BYE CommuniGate Pro IMAP closing connection I OK completed Regards -- Glen Ogilvie Open Systems Specialists Level 1, 162 Grafton Road http://www.oss.co.nz/ Ph: +64 9 984 3000 Mobile: +64 21 684 146 GPG Key: ACED9C17 _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Procmail and Exim filters script
by emi＠algorismia.com 23 Nov '07

23 Nov '07

Hi all!! I've just made the first filtering script to translate SQL filters to System filters. It takes user parameter (something like 'rcdev(a)cio.cat') and the system filtering type. At the moment, allowed types are 'procmail' (default) and 'exim'. If you call it without params, it will ask for IMAP user and translate filters to procmail format. Translated filters are printed to stdout. The 'help' param prints out help. I repeat: this is a very earlier version. You can only match a containing string on some message's part, not regexps. You can only move messages to another mailbox, not forwarding neither anytihng else. Now I will concentrate on Sieve. If anyone knows other significant mail filtering systems, tell me and, if possible, some syntax specification webpage. After doing firsts versions of more significant mail filtering systems, I will improve a better UI to allow advanced matching systems, probably adding another table to roundcube DB and altering the 'filters' existing one. Please, comment out when (in which step) do you think it will be applicable to svn version (upload work). Attached to this message, I send the script and the output from running the script with my user rcdev, one with procmail type and the other with exim's. Bugs and comments are welcome. Thanks to everybody!! PD: I've seen several connections from you to my server. Anyone wants to comment anything to filters UI? And is there someone who can tell me how to use drag'n'drop lists (to change filters order)? emi --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/KV/gEbX/jku/sql2filter.php http://detached.gigo.com/rc/KV/gEbX/jku/rcdev_exim.txt http://detached.gigo.com/rc/KV/gEbX/jku/rcdev_procmail.txt Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Conditional HTML and preview pane
by Robin Elfrink 20 Nov '07

20 Nov '07

Hi, Another go at a preview pane. I implemented conditional HTML which works like this: <roundcube:if condition="config:preview==true" /> html bla bla <roundcube:else /> other html bla bla <roundcube:endif /> The preview code was mostly Thomas', plus a bit of myself to let the user decide for herself. Code is not yet optimized, so it looks like poo, and I suspect IE6 will have problems, because I delete some CSS which made it look strange in IE7. Robin Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 380) +++ config/main.inc.php.dist (working copy) @@ -228,5 +228,11 @@ // save compose message every 300 seconds (5min) $rcmail_config['draft_autosave'] = 300; +// Enable preview pane +$rcmail_config['enable_preview'] = FALSE; + +// Default setting if preview pane is enabled +$rcmail_config['preview'] = FALSE; + // end of config file ?> Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 380) +++ program/include/main.inc (working copy) @@ -1106,9 +1106,8 @@ return FALSE; } - // parse for specialtags - $output = parse_rcube_xml($templ); + $output = parse_rcube_xml(parse_rcube_conditions($templ)); $OUTPUT->write(trim(parse_with_globals($output)), $skin_path); @@ -1269,6 +1268,48 @@ } +// parse conditional code +function parse_rcube_conditions($input) + { + global $CONFIG; + if (($matches = preg_split('/<roundcube:(if|elseif|else|endif)\s+([^>]+)>/is', $input, 2, PREG_SPLIT_DELIM_CAPTURE)) && + (count($matches)==4)) + { + if (preg_match('/^(else|endif)$/i', $matches[1])) + return $matches[0] . '' . parse_rcube_conditions($matches[3]); + else + { + $attrib = parse_attrib_string($matches[2]); + if (isset($attrib['condition']) && + preg_match('/^(session|config):([a-zA-Z0-9_]+)([=<>!]+)(.*)$/i', $attrib['condition'], $opts)) + { + $condmet = false; + if ($opts[1]=='session') + $condmet = eval("return (\$_SESSION['" . $opts[2] . "']" . $opts[3] . "'" . $opts[4] . "');"); + elseif ($opts[1]=='config') + $condmet = eval("return (\$CONFIG['" . $opts[2] . "']" . $opts[3] . "'" . $opts[4] . "');"); + $submatches = preg_split('/<roundcube:(elseif|else|endif)\s+([^>]+)>/is', $matches[3], 2, PREG_SPLIT_DELIM_CAPTURE); + if ($condmet) + $result = $submatches[0] . preg_replace('/.*<roundcube:endif\s+[^>]+>/is', '', $submatches[3]); + else + $result = '<roundcube:' . $submatches[1] . $submatches[2] . $submatches[3]; + return $matches[0] . '' . parse_rcube_conditions($result); + } + else + { + raise_error(array('code' => 500, + 'type' => 'php', + 'line' => __LINE__, + 'file' => __FILE__, + 'message' => "Unable to parse conditional tag " . $matches[2]), TRUE, FALSE); + } + } + } + else + return $input; + } + + // create and register a button function rcube_button($attrib) { Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 380) +++ program/localization/en_US/labels.inc (working copy) @@ -211,6 +211,7 @@ $labels['dstactive'] = 'Daylight savings'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; +$labels['preview'] = 'Show preview pane'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 380) +++ program/js/app.js (working copy) @@ -151,8 +151,15 @@ this.enable_command('firstmessage', true); } } + + // make preview/message frame visible + if (this.env.action == 'preview' && this.env.framed && parent.rcmail) + { + this.enable_command('compose', 'add-contact', false); + parent.rcmail.show_messageframe(true); + } - if (this.env.action=='show' && this.env.blockedobjects) + if ((this.env.action=='show' || this.env.action=='preview') && this.env.blockedobjects) { if (this.gui_objects.remoteobjectsmsg) this.gui_objects.remoteobjectsmsg.style.display = 'block'; @@ -637,7 +644,7 @@ case 'load-images': if (this.env.uid) - this.show_message(this.env.uid, true); + this.show_message(this.env.uid, true, this.env.action=='preview'); break; case 'load-attachment': @@ -667,22 +674,22 @@ case 'nextmessage': if (this.env.next_uid) - this.show_message(this.env.next_uid); + this.show_message(this.env.next_uid, false, this.env.action=='preview'); break; case 'lastmessage': if (this.env.last_uid) - this.show_message(this.env.last_uid); + this.show_message(this.env.last_uid, false, this.env.action=='preview'); break; case 'previousmessage': if (this.env.prev_uid) - this.show_message(this.env.prev_uid); + this.show_message(this.env.prev_uid, false, this.env.action=='preview'); break; case 'firstmessage': if (this.env.first_uid) - this.show_message(this.env.first_uid); + this.show_message(this.env.first_uid, false, this.env.action=='preview'); break; case 'checkmail': @@ -1052,6 +1059,9 @@ this.msglist_select = function(list) { + if (this.preview_timer) + clearTimeout(this.preview_timer); + var selected = list.selection.length==1; if (this.env.mailbox == this.env.drafts_mailbox) { @@ -1063,16 +1073,25 @@ this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected); this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false); } + + // start timer for message preview (wait for double click) + if (selected && this.env.contentframe) + this.preview_timer = setTimeout(this.ref+'.msglist_get_preview()', this.dblclick_time + 10); + else if (this.env.contentframe) + this.show_messageframe(false); }; this.msglist_dbl_click = function(list) { + if (this.preview_timer) + clearTimeout(this.preview_timer); + var uid = list.get_single_selection(); if (uid && this.env.mailbox == this.env.drafts_mailbox) this.goto_url('compose', '_draft_uid='+uid+'&_mbox='+urlencode(this.env.mailbox), true); else if (uid) - this.show_message(uid); + this.show_message(uid, false, false); }; @@ -1085,18 +1104,29 @@ }; + this.msglist_get_preview = function() + { + var uid = this.get_single_uid(); + if (uid && this.env.contentframe) + this.show_message(uid, false, true); + else if (this.env.contentframe) + this.show_messageframe(false); + }; + + /*********************************************************/ /********* (message) list functionality *********/ /*********************************************************/ // when user doble-clicks on a row - this.show_message = function(id, safe) + this.show_message = function(id, safe, preview) { var add_url = ''; + var action = preview ? 'preview': 'show'; var target = window; - if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) + if (preview && this.env.contentframe && window.frames && window.frames[this.env.contentframe]) { target = window.frames[this.env.contentframe]; add_url = '&_framed=1'; @@ -1107,13 +1137,27 @@ if (id) { - this.set_busy(true, 'loading'); - target.location.href = this.env.comm_path+'&_action=show&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; + var url = '&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; + if (action == 'preview' && String(target.location.href).indexOf(url) >= 0) + this.show_messageframe(true); + else + { + this.set_busy(true, 'loading'); + target.location.href = this.env.comm_path+url; + } } }; + this.show_messageframe = function(show) + { + var frm; + if (this.env.contentframe && (frm = rcube_find_object(this.env.contentframe))) + frm.style.display = show ? 'block' : 'none'; + }; + + // list a specific page this.list_page = function(page) { Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 380) +++ program/steps/settings/func.inc (working copy) @@ -155,6 +155,16 @@ rep_specialchars_output(rcube_label('htmleditor')), $input_htmleditor->show($CONFIG['htmleditor']?1:0)); + if ($CONFIG['enable_preview']) + { + $field_id = 'rcmfd_preview'; + $input_preview = new checkbox(array('name' => '_preview', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('preview')), + $input_preview->show($CONFIG['preview']?1:0)); + } + if (!empty($CONFIG['drafts_mbox'])) { $field_id = 'rcmfd_autosave'; @@ -242,4 +252,4 @@ } -?> \ No newline at end of file +?> Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 380) +++ program/steps/settings/save_prefs.inc (working copy) @@ -29,6 +29,8 @@ $a_user_prefs['pagesize'] = is_numeric($_POST['_pagesize']) ? (int)$_POST['_pagesize'] : $CONFIG['pagesize']; $a_user_prefs['prefer_html'] = isset($_POST['_prefer_html']) ? TRUE : FALSE; $a_user_prefs['htmleditor'] = isset($_POST['_htmleditor']) ? TRUE : FALSE; +if ($CONFIG['enable_preview']) + $a_user_prefs['preview'] = isset($_POST['_preview']) ? TRUE : FALSE; $a_user_prefs['draft_autosave'] = isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0; // MM: Date format toggle (Pretty / Standard) Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 380) +++ program/steps/mail/show.inc (working copy) @@ -34,8 +34,14 @@ // go back to list if message not found (wrong UID) if (!$MESSAGE['headers'] || !$MESSAGE['structure']) { - $_action = 'list'; - return; + show_message('messageopenerror', 'error'); + if ($_action=='preview' && template_exists('messagepreview')) + parse_template('messagepreview'); + else + { + $_action = 'list'; + return; + } } $MESSAGE['subject'] = $IMAP->decode_header($MESSAGE['headers']->subject); @@ -131,28 +137,6 @@ -// return an HTML iframe for loading mail content -function rcmail_messagecontent_frame($attrib) - { - global $COMM_PATH, $OUTPUT, $GET_URL, $JS_OBJECT_NAME; - - // allow the following attributes to be added to the <iframe> tag - $attrib_str = create_attrib_string($attrib); - $framename = 'rcmailcontentwindow'; - - $out = sprintf('<iframe src="%s" name="%s"%s>%s</iframe>'."\n", - $GET_URL, - $framename, - $attrib_str, - rcube_label('loading')); - - - $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('contentframe', '$framename');"); - - return $out; - } - - function rcmail_remote_objects_msg($attrib) { global $CONFIG, $OUTPUT, $JS_OBJECT_NAME; @@ -177,8 +161,10 @@ } -if ($_action=='print') +if ($_action=='print' && template_exists('printmessage')) parse_template('printmessage'); +else if ($_action=='preview' && template_exists('messagepreview')) + parse_template('messagepreview'); else parse_template('message'); -?> \ No newline at end of file +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 380) +++ program/steps/mail/func.inc (working copy) @@ -481,6 +481,7 @@ $javascript .= sprintf("%s.set_env('pagecount', %d);\n", $JS_OBJECT_NAME, ceil($message_count/$IMAP->page_size)); $javascript .= sprintf("%s.set_env('sort_col', '%s');\n", $JS_OBJECT_NAME, $sort_col); $javascript .= sprintf("%s.set_env('sort_order', '%s');\n", $JS_OBJECT_NAME, $sort_order); + $javascript .= sprintf("%s.set_env('preview', '%s');\n", $JS_OBJECT_NAME, $CONFIG['enable_preview'] && $CONFIG['preview']); if ($attrib['messageicon']) $javascript .= sprintf("%s.set_env('messageicon', '%s%s');\n", $JS_OBJECT_NAME, $skin_path, $attrib['messageicon']); @@ -558,6 +559,28 @@ } +// return an HTML iframe for loading mail content +function rcmail_messagecontent_frame($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + if (empty($attrib['id'])) + $attrib['id'] = 'rcmailcontentwindow'; + + // allow the following attributes to be added to the <iframe> tag + $attrib_str = create_attrib_string($attrib, array('id', 'class', 'style', 'src', 'width', 'height', 'frameborder')); + $framename = $attrib['id']; + + $out = sprintf('<iframe name="%s"%s></iframe>'."\n", + $framename, + $attrib_str); + + $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('contentframe', '$framename');"); + + return $out; + } + + // return code for search function function rcmail_search_form($attrib) { Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 380) +++ skins/default/templates/mail.html (working copy) @@ -42,6 +42,22 @@ </div> +<roundcube:if condition="config:preview==true" /> +<div id="mailcontframe" class="preview"> +<roundcube:object name="messages" + id="messagelist" + cellspacing="0" + summary="Message list" + messageIcon="/images/icons/dot.png" + unreadIcon="/images/icons/unread.png" + deletedIcon="/images/icons/deleted.png" + repliedIcon="/images/icons/replied.png" + attachmentIcon="/images/icons/attachment.png" /> +</div> +<div id="mailpreviewframe"> +<roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> +</div> +<roundcube:else /> <div id="mailcontframe"> <roundcube:object name="messages" id="messagelist" @@ -53,6 +69,7 @@ repliedIcon="/images/icons/replied.png" attachmentIcon="/images/icons/attachment.png" /> </div> +<roundcube:endif /> <div id="listcontrols"> <roundcube:label name="select" />:  Index: skins/default/templates/messagepreview.html =================================================================== --- skins/default/templates/messagepreview.html (revision 0) +++ skins/default/templates/messagepreview.html (revision 0) @@ -0,0 +1,19 @@ +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> +<head> +<title><roundcube:object name="pagetitle" /></title> +<link rel="stylesheet" type="text/css" href="/common.css" /> +<link rel="stylesheet" type="text/css" href="/mail.css" /> +</head> +<body class="iframe"> + +<div class="messageheaderbox"> +<roundcube:object name="messageHeaders" class="headers-table" cellspacing="0" cellpadding="2" addicon="/images/icons/plus.gif" summary="Message headers" /> +<roundcube:object name="messageAttachments" id="attachment-list" /> +</div> + +<roundcube:object name="blockedObjects" id="remote-objects-message" /> +<roundcube:object name="messageBody" id="messagebody" /> + +</body> +</html> Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 380) +++ skins/default/mail.css (working copy) @@ -117,10 +117,34 @@ overflow: auto; /* css hack for IE */ width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); - height: expression((parseInt(document.documentElement.clientHeight)-125)+'px'); } +#mailcontframe.preview { + bottom: auto; + height: 210px; +} +#mailpreviewframe +{ + position: absolute; + top: 300px; + left: 200px; + right: 40px; + bottom: 40px; + border: 1px solid #999999; + background-color: #F9F9F9; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); + height: expression((parseInt(document.documentElement.clientHeight)-340)+'px'); +} + +#messagecontframe +{ + width: 100%; + height: 100%; + border: 0; +} + #messagepartframe { border: 1px solid #999999; Index: index.php =================================================================== --- index.php (revision 380) +++ index.php (working copy) @@ -262,7 +262,7 @@ { include_once('program/steps/mail/func.inc'); - if ($_action=='show' || $_action=='print') + if ($_action=='show' || $_action=='preview' || $_action=='print') include('program/steps/mail/show.inc'); if ($_action=='get')

2 3

Korean translation file
by Kim Hanjo 20 Nov '07

20 Nov '07

Hi all, This is my first message for this mailing list. Please have the attachment file, localization for Korean. I use this file in my own installation. Hanjo Kim http://lordmiss.com --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/FB/Yoxtw11f/kr.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

"Supported" browsers
by chasd 15 Nov '07

15 Nov '07

At the link <http://trac.roundcube.net/wiki/Howto_Requirements> Only this is mentioned for browser requirements : * Javascript enabled * Accept cookies * Support for XMLHttpRequest Since I have some users on old or odd platforms, I was wondering if there should be a list of "tested" browsers. This may be incorrect, but from reading the Dev mail list, it seems the main developers test on the major browsers. IMHO it seems that RoundCube is "tested" on IE 6 ( Win XP ) and 7 ( Win XP and Vista ) Safari 2 ( OS X 10.4.x ) and 3 ( OS X 10.4.x and 10.5.x, Win XP, Vista ) Firefox 2 ( Win XP, OS X 10.4.x ) Should that specifically be mentioned in the browser requirements ? Are there others that are smoketested by Devs ? If other browsers are known to work by users, those could be added to a "reported to work" section, so there is not an implication those browsers are regularly used by the Devs. I think Opera 9 is used by others on the Dev list, and I use Camino, although always the very latest release. Maybe there should also be a "known not to work" section so bugs don't get filed that will likely never be addressed ? I realize that if IE 6 works, you have covered almost every Windows user, but the Mac platform has had many different browsers available for it, and many different versions of those. Sadly each with differing capabilities as far as HTML, CSS, and ECMAScript support. Such browsers would be Safari 1.2x or 1.0.x ( OS X 10.3.x, 10.2.x ), Firefox 1.0.x or 1.5.x, Mozilla Suite ( Mac OS 9 ), IE 4.x ( Mac OS 9 ), iCab, etc. Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265 _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Re: [RCD] iPhone usability
by markevich＠inbox.lv 15 Nov '07

15 Nov '07

Hello, Joel. I’m not completely sure that Iphone’s Safari browser is absolutely the same as desktop one. As far as I know all mobile versions have limited functionality because of architecture limitations. Anyway further analysis should be done on this but only few people are having Iphone so there is might be a problem in testing and fixing of this possible problem. If you are agree to participate in the development and make some tests and coding you are highly welcomed. In other case I don’t think that it’s possible to investigate and fix this problem now. Regards, Andris > From: Joel Clermont > Subject: Re: [RCD] iPhone usability > To: Drarok Ithaqua > Cc: RoundCube Dev > Message-ID: > Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes > > The issues I ran into with using RoundCube via an iPhone was the > inability to double click and drag/drop. > > In my case, I support the mail server, so it's not just about getting > access to my mailbox. Sometimes it's nice to be able to bring up > RoundCube on the road to check a problem in someone else's mailbox. > Fixing the UI gotchas for the iPhone should not be a huge ordeal. The > app itself renders fine, it is just some of the behaviors that are not > available.. > > Joel Clermont > 262-377-9930 > joel(a)orionweb.net -- Tavs bezmaksas pasts Inbox.lv _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] "Supported" browsers
by markevich＠inbox.lv 15 Nov '07

15 Nov '07

Hello, Charles. I was using Firefox 2.x (Windows, Linux), Opera 9.x (Windows, Linux), Internet Explorer. Everything was working fine except for 1 annoying bug in the latest release that's denies to login on Firefox. I don't think that browser names should be displayed in the requirements, because there are a lot of differences in the browsers engine realization (even in the same family). The key here is to specify generic functionality that is used in the Roundcube that at least must be supported in order to work. If we’ll add some browser’s names to the list it would mean that we’ll give support obligations to the community to 100% support for these browsers and it wouldn’t be right. My advice is to keep things like they are now – if your browser is supporting specified functions in the requirement it should work, if it’s supporting and not working – create ticket and we’ll try to investigate the problem. I agree that there is should be a list with the browsers that were reported as working/non-working but definitely not in the requirements section but may be at the bottom of the page. Regards, Andris > Date: Wed, 14 Nov 2007 09:31:48 -0600 > From: chasd > Subject: [RCD] "Supported" browsers > To: RoundCube Dev > Message-ID: > Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed > > At the link > > > Only this is mentioned for browser requirements : > > * Javascript enabled > * Accept cookies > * Support for XMLHttpRequest > > Since I have some users on old or odd platforms, I was wondering if > there should be a list of "tested" browsers. > This may be incorrect, but from reading the Dev mail list, it seems > the main developers test on the major browsers. > > IMHO it seems that RoundCube is "tested" on > > IE 6 ( Win XP ) and 7 ( Win XP and Vista ) > Safari 2 ( OS X 10.4.x ) and 3 ( OS X 10.4.x and 10.5.x, Win XP, Vista ) > Firefox 2 ( Win XP, OS X 10.4.x ) > > Should that specifically be mentioned in the browser requirements ? > Are there others that are smoketested by Devs ? > > If other browsers are known to work by users, those could be added to > a "reported to work" section, so there is not an implication those > browsers are regularly used by the Devs. > I think Opera 9 is used by others on the Dev list, and I use Camino, > although always the very latest release. > Maybe there should also be a "known not to work" section so bugs > don't get filed that will likely never be addressed ? > I realize that if IE 6 works, you have covered almost every Windows > user, but the Mac platform has had many different browsers available > for it, and many different versions of those. Sadly each with > differing capabilities as far as HTML, CSS, and ECMAScript support. > Such browsers would be Safari 1.2x or 1.0.x ( OS X 10.3.x, 10.2.x ), > Firefox 1.0.x or 1.5.x, Mozilla Suite ( Mac OS 9 ), IE 4.x ( Mac OS > 9 ), iCab, etc. > Charles Dostale > System Admin - Silver Oaks Communications > http://www.silveroaks.com/ > 824 17th Street, Moline IL 61265 -- Tavs bezmaksas pasts Inbox.lv _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Session handler with custom session-methods are not thread-safe.
by Micha 15 Nov '07

15 Nov '07

Hi to all. I discovered a problem with the login, where after some logins and logouts, every new Login-Attempt kicked me back to the login screen. Without any mention of a problem in the logs. I searched the forum and found that some users experienced similar problems. After some debugging I found the weak point. The problem is, that the sess_read and sess_write methods that are used during logout and also used from the periodical mail checking process, are not "synchronized" (thread-safe). So it is possible that the two events occur at the same time: The events occur in the following order: 1. Logout calls sess_read 2. Periodical Mail Check calls sess_read 3. Logout calls sess_write (with $vars (temp|b:1)) 4. Periodical Mail Check calls sess_write ($vars without temp) Step 4 ("mail check") overwrites the Session-Parameters from Step 3 ("logout"). The concrete problem in this case is the temp-Parameter. Next login, session_start reads in the session parameter, where "temp" must be true, to start a new session. Otherwise when ("temp" == false), roundcube expects a valid session and tries to resume that session. (In index.php $_SESSION['temp'] will be checked but fails.) The only way a new login is possible, is to reset the cookies (restart IE and delete cookies in Firefox). >From my point of view, the session handlers (session_start(), session_destroy() and session_regenerate_id()) must be atomic. So the session handler must have exclusive access to the custom session methods in session.inc. Micha. _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Filters Patch
by emi＠algorismia.com 15 Nov '07

15 Nov '07

Hi all!! Here is the filter patch. There are some differences between the svn copy I took last week and the one I did the patch diff with, but I think these are minor changes. If finally you want the gziped src (not patched), tell me. Take a look!! emi --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Yk/KCtBesrs/RC_Filters_patch.txt.gz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Diff'ing filters
by emi＠algorismia.com 15 Nov '07

15 Nov '07

Hi!! Thomas said me to use 'svn diff' to make the filters patch, but with this option new files are not taken. How can I add them into the patch? Or just add the patch & new files into a .tar.gz? Thanks for all! emi _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev