Dev

dev@lists.roundcube.net

1 participants
4305 discussions

Switch character seta
by Yoshikazu Tsuji 11 Sep '07

11 Sep '07

Hello. Some mailler doesn't suuport UTF-8. So, we japanese need to switch charater set. Maybe, I think other people who use multibyte language also need to switch. This is patch to add character set selector. This code was exist in older version. ============================================================ --- ./skins/default/templates/compose.html (svn rev 667) +++ ./skins/default/templates/compose.html (changed) @@ -104,6 +104,9 @@ <roundcube:button type="input" command="list" class="button" label="cancel" /> </td> <td align="right"> +<roundcube:label name="charset" />: <roundcube:objectname="charsetSelector"> +</td> +<td align="right"> <roundcube:label name="editortype" />: <span class="radios-left"><roundcube:object name="editorSelector" tabindex="9" /></span> </td> ============================================================ This is patch to set default character set every languages. ============================================================ --- ./program/localization/index.inc_ (svn rev 672) +++ ./program/localization/index.inc (changed) @@ -88,7 +88,11 @@ 'tw' => 'zh_TW' ); -$rcube_charsets = array(); +$rcube_languages_default_charset = array( + 'en_US' => 'ASCII', + 'en_GB' => 'ASCII', + 'kr' => 'EUC-KR', + 'zh_TW' => 'BIG5', + 'zh_CN' => 'GB2312', + 'ja' => 'ISO-2022-JP' +); +$rcube_charsets = array(); ?> ============================================================ This is patch to set default character to charset_selector. ============================================================ --- rcmail_template.inc_ (svn rev 732) +++ rcmail_template.inc (changed) @@ -824,7 +824,12 @@ function rcmail_charset_selector($attrib) { global $OUTPUT; + global $sess_user_lang; + static $rcube_languages_default_charset; + if (empty($rcube_languages_default_charset)) + @include($INSTALL_PATH.'program/localization/index.inc'); + // pass the following attributes to the form class $field_attrib = array('name' => '_charset'); foreach ($attrib as $attr => $value) @@ -853,7 +858,12 @@ $select = new select($field_attrib); $select->add(array_values($charsets), array_keys($charsets)); - $set = $_POST['_charset'] ? $_POST['_charset'] : $OUTPUT->get_charset(); + // language has default charset configured + if (isset($rcube_languages_default_charset[$sess_user_lang])) + $set = $rcube_languages_default_charset[$sess_user_lang]; + else + $set = 'UTF-8'; + return $select->show($set); } ============================================================ Yoshikazu. -- /** ----------------------------------------- * Yoshikazu Tsuji @ church.ne.jp * * E-mail : yskzt(a)church.ne.jp * Web : http://church.ne.jp/ * ------------------------------------------ */ _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Ticket #1484429
by yskzt＠church.ne.jp 11 Sep '07

11 Sep '07

Hi. I thought mbstring functions can handle chr(160) in UTF-8. But, when I test my patch, mbstring return false and report error "mb_strpos(): Unknown encoding or conversion error.". like this: mb_internal_encoding("UTF-8"); $test_str = "abcd".chr(160)."efg"; mb_strpos($test_str, chr(160)) ==> false I searched web sites. - The chr(160) in UTF-8 is incorrect. (http://en.wikipedia.org/wiki/UTF-8) - In UTF-8, no-break space(nbsp) is 0xC2 0xA0. (http://www.fileformat.info/info/unicode/char/00a0/index.htm) So, how about this? =================================== --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 (rev 774) +++ main.inc 2007-09-12 01:05:31.000000000 +0900 (changed) @@ -1103,6 +1103,17 @@ return $str; } +function mb_str_replace($search_str, $replace_str, $str) + { + $current_pos = 0; + while (($found_pos = mb_strpos($str, $search_str, $current_pos)) !== false) + { + $str = mb_substr($str, 0, $found_pos).$replace_str.mb_substr($str, $found_pos + mb_strlen($search_str)); + $current_pos = $found_pos + strlen($replace_str); + } + + return $str; + } /** * Replacing specials characters to a specific encoding type @@ -1123,7 +1134,12 @@ // convert nbsps back to normal spaces if not html if ($enctype!='html') - $str = str_replace(chr(160), ' ', $str); + { + if ($OUTPUT->get_charset()=='UTF-8') + $str = mb_str_replace(chr(194).chr(160), ' ', $str); + else + $str = str_replace(chr(160), ' ', $str); + } // encode for plaintext if ($enctype=='text') =================================== Yoshikazu. On Wed, 5 Sep 2007 03:05:21 +0200, till <klimpong(a)gmail.com> wrote: > On 9/3/07, Yoshikazu Tsuji <yskzt(a)church.ne.jp> wrote: >> Hi. >> >> The following code causes Ticket #1484429 >> (http://trac.roundcube.net/trac.cgi/ticket/1484429). >> ============================================================= >> = "program/include/main.inc" function rep_specialchars_output >> >> // convert nbsps back to normal spaces if not html >> if ($enctype!='html') >> $str = str_replace(chr(160), ' ', $str); >> ============================================================= >> >> This problem is happened in multibyte enviroment (japanese too). >> In message list, function rep_specialchars_output garbled >> UTF-8 message subjects. >> >> Is converting chr(160) to space really necessary ? >> >> This is patch using multi byte functions. >> >> =============================================================== >> --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 >> +++ main.inc 2007-09-03 16:22:59.000000000 +0900 >> @@ -1122,8 +1122,17 @@ >> $enctype = $GLOBALS['OUTPUT_TYPE']; >> >> // convert nbsps back to normal spaces if not html >> - if ($enctype!='html') >> - $str = str_replace(chr(160), ' ', $str); >> + if ($enctype!='html') { >> + $current_pos = 0; >> + while(true) { >> + $found_pos = mb_strpos($str, chr(160), $current_pos); >> + if($found_pos == false) >> + break; >> + >> + $str = mb_substr($str, 0, $found_pos)." ".mb_substr($str, > $found_pos >> + 1, mb_strlen($str)); >> + $currentpos += 1; >> + } >> + } >> >> // encode for plaintext >> if ($enctype=='text') >> =============================================================== > > multibyte looks like the better alternative, especially since we are > dealing with people from different countries. And since we are using > mb already, I have no issues with this. > > Just one thing, can you add this to the trac? Please? :) > > Thanks, > Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Small LDAP patch
by Harold Aling 11 Sep '07

11 Sep '07

Dear list, I'm a novice in Roundcube 'hacking', but I plan to fix a few items in the future, since I really like RC! To enable my local LDAP addressbook, I had to change the following line in 'rcube_ldap.inc' (svn version): Index: rcube_ldap.inc =================================================================== --- rcube_ldap.inc (revision 774) +++ rcube_ldap.inc (working copy) @@ -90,7 +90,7 @@ { if ($lc = @ldap_connect($host, $this->prop['port'])) { - ldap_set_option($lc, LDAP_OPT_PROTOCOL_VERSION, $this->prop['port']); + ldap_set_option($lc, LDAP_OPT_PROTOCOL_VERSION, 3); $this->prop['host'] = $host; $this->conn = $lc; break; Maybe $this->prop['ldap_version'] can be added to the preferences? -H- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] multi select question
by Thomas Bruederli 11 Sep '07

11 Sep '07

2007/9/10, Michael Baierl <mail(a)mbaierl.com>: > Thomas Bruederli wrote: > > Joel Clermont wrote: > >> The biggest problem people moan about is multi-select. It is not > >> intuitive to use a key modifier like Shift or Control to select multiple > >> messages. > > > > What is not intuitive in this behavior? All apps behave like this. > Windows Apps: yes. > Web apps: no. Users are not used to use Strg+Shift on Webapps and most > users are not even used to that on Windows - they just use the mouse. > Watch your mum and you will see ;) I kind of expected this answer... But nevertheless web apps are starting to replace desktop applications and also copy the way to control them. Yahoo! Mail found a nice way to support both: they have checkboxes (not real ones but HTML elements) but also allow to multi-select messages using shift/ctrl. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

PopPass Extension
by Cesar D. Rodas 07 Sep '07

07 Sep '07

Hello I have writen an Public Domain class of a php poppassd (that allows change password of mail users) in PHP. It is not approved yet into PHPClasses, but I can send here the source code. Can i send? I didnt see if RoundCube has yet this feature. -- Cesar D. Rodas http://www.cesarodas.com/ Mobile Phone: 595 961 974165 Phone: 595 21 645590 saddor(a)gmail.com saddor(a)guaranix.org _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Problem with attachments over 90kb only in ie7
by Joan 07 Sep '07

07 Sep '07

I'm using trunk rev.764 over an https connection. There is no problem uploading attachments from firefox, ie6 and safari, everything works fine. With ie7 there's no way to upload nothing biffer than 90Kb (maybe less), I tried it in two different computers emptying cache and all than. The server is the same in both cases. PS: The same thing happens with horde in the same server. The php.ini settings related ... post_max_size = 20M max_execution_time = 30 max_input_time = 60 memory_limit = 40M Thanks a lot _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Postgres and Sqlite (Re: MySQL usage to much??)
by till 06 Sep '07

06 Sep '07

Hey Charles, On 9/5/07, chasd <chasd(a)silveroaks.com> wrote: > I know that most users will choose MySQL. > I personally prefer PostgreSQL. > Is there any info about users that choose the SQLite backend ? > Anyone on the devel list use it, or test with it ? are you using RoundCube with Postgres? If so, I'd really welcome your feedback (bug reports, patches, ...). I sure hope there is not much to report, but I guess when you use the "mdb2" backend it should work already. Sqlite - I am not sure how to really support that yet. Apparently there is a very old Sqlite2 still used and a "newer" Sqlite3. It would be interesting to know usage stats of Sqlite (along with version) in general so we could build stronger support. For example, I've heard from users that their Sqlite did not support "ALTER TABLE-like" commands, but that has been released maybe two years ago? So I am a bit unsure what we really need to support, etc.. Cheers, Till _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

PHP5.3 coming up
by till 05 Sep '07

05 Sep '07

http://oss.backendmedia.com/PhP53 Semi-related to RoundCube development, so it's worth checking out. :) Cheers, Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Ticket #1484429
by Yoshikazu Tsuji 05 Sep '07

05 Sep '07

Hi. The following code causes Ticket #1484429 (http://trac.roundcube.net/trac.cgi/ticket/1484429). ============================================================= = "program/include/main.inc" function rep_specialchars_output // convert nbsps back to normal spaces if not html if ($enctype!='html') $str = str_replace(chr(160), ' ', $str); ============================================================= This problem is happened in multibyte enviroment (japanese too). In message list, function rep_specialchars_output garbled UTF-8 message subjects. Is converting chr(160) to space really necessary ? This is patch using multi byte functions. =============================================================== --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 +++ main.inc 2007-09-03 16:22:59.000000000 +0900 @@ -1122,8 +1122,17 @@ $enctype = $GLOBALS['OUTPUT_TYPE']; // convert nbsps back to normal spaces if not html - if ($enctype!='html') - $str = str_replace(chr(160), ' ', $str); + if ($enctype!='html') { + $current_pos = 0; + while(true) { + $found_pos = mb_strpos($str, chr(160), $current_pos); + if($found_pos == false) + break; + + $str = mb_substr($str, 0, $found_pos)." ".mb_substr($str, $found_pos + 1, mb_strlen($str)); + $currentpos += 1; + } + } // encode for plaintext if ($enctype=='text') =============================================================== Yoshikazu. -- /** ----------------------------------------- * Yoshikazu Tsuji @ church.ne.jp * * E-mail : yskzt(a)church.ne.jp * Web : http://church.ne.jp/ * ------------------------------------------ */ _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

test / ignore
by Jason Fesler 04 Sep '07

04 Sep '07

Testing mailman + XVERP patch for list delivery _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev