Dev

dev@lists.roundcube.net

1 participants
4293 discussions

Patch to allow 12 hour date to display for emails sent today.
by dmandell 08 Dec '06

08 Dec '06

Hi again, I'm an American and prefer to use a 12 hour time display (i.e. 1:05pm) rather than a 24 hour clock (13:05). Currently Roundcube allows 12 hour time displays for messages older than one day, but for messages received today it still uses the 24 hour display. The following patch creates a preference for today's date (called date_today) in main.php.inc and then edits main.inc to use it. Again, if I'm doing this wrong please let me know. Thanks, Doug Index: roundcubemail/config/main.inc.php.dist =================================================================== --- roundcubemail/config/main.inc.php.dist (revision 400) +++ roundcubemail/config/main.inc.php.dist (working copy) @@ -107,6 +107,9 @@ // the default locale setting $rcmail_config['locale_string'] = 'en'; +// use this format for today's date display +$rcmail_config['date_today'] = 'H:i'; + // use this format for short date display $rcmail_config['date_short'] = 'D H:i'; Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1687,7 +1687,7 @@ // define date format depending on current time if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit) - return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp)); + return sprintf('%s %s', rcube_label('today'), date($CONFIG['date_short'] ? $CONFIG['date_today'] : 'H:i', $timestamp)); else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit) $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i'; else if (!$format)

1 0

patch for tabindex on send button (compose email page)
by dmandell 08 Dec '06

08 Dec '06

Hi all, I prefer to use keyboard navigation whenever possible. RC currently allows tabbing between recipient, subject and body, but the send button doesn't allow tabindex. In other webmail applications (yahoo, gmail, etc) send is next after tab, and it's quite convenient that way. I'm assuming you didn't purposely make it difficult to tab to the Send button, so I've created a patch for your approval. Below is a patch that allows tabindex in buttons and makes "Send" and "Cancel" next in the tab order after the email body. Please let me know if I'm not submitting the patch right or if you have any issues. Thanks a bunch, Doug Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1501,7 +1501,7 @@ if ($attrib['label']) $attrib['value'] = $attrib['label']; - $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$ + $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$ $out = sprintf('<input%s disabled />', $attrib_str); } Index: roundcubemail/skins/default/templates/compose.html =================================================================== --- roundcubemail/skins/default/templates/compose.html (revision 400) +++ roundcubemail/skins/default/templates/compose.html (working copy) @@ -100,15 +100,15 @@ <table border="0" cellspacing="0" width="100%" summary=""><tbody><tr> <td> -<roundcube:button type="input" command="send" class="button" label="sendmessage" /> -<roundcube:button type="input" command="list" class="button" label="cancel" /> +<roundcube:button type="input" command="send" class="button" label="sendmessage" tabindex="8" /> +<roundcube:button type="input" command="list" class="button" label="cancel" tabindex="9" /> </td> <td align="right"> -<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="8" /> +<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="10" /> </td> <td align="right"> <roundcube:label name="editortype" />: </td> -<roundcube:object name="editorSelector" tabindex="9" /> +<roundcube:object name="editorSelector" tabindex="11" /> </tr></tbody></table> </td>

1 0

[Fwd: Re: Printed message]
by Robin Elfrink 07 Dec '06

07 Dec '06

Ryan: Please reply to the lest next time, while I'll try to instruct my mail-client. -------- Original Message -------- Subject: Re: Printed message Date: Thu, 07 Dec 2006 10:41:59 -0500 From: Ryan Rittenhouse <ryanmr(a)goshen.edu> To: Robin Elfrink <elfrink(a)introweb.nl> References: <4573FC24.3050400(a)introweb.nl> <4573FFF6.8090205(a)gmail.com> <457401F3.4050601(a)introweb.nl> <457404FC.4000302(a)gmail.com> <4576AFC5.3080703(a)introweb.nl> <4576B620.1020902(a)gmail.com> <45782497.9000401(a)introweb.nl> <45782C43.7000208(a)cantella.com> <45782ECF.7050306(a)introweb.nl> Robin Elfrink wrote: > How about a user-configurable option then? Or would the settings get > cluttered too much? I like the idea of user-configurable. I think it'll be a while before the settings list starts getting cluttered. Ever see the one for Ilohamail? ;p -Ryan Rittenhouse Network Administrator Goshen College ryanmr(a)goshen.edu (574) 535-7004

1 0

[Fwd: Re: Printed message]
by Robin Elfrink 07 Dec '06

07 Dec '06

Pierre: Please reply to the lest next time, while I'll try to instruct my mail-client. -------- Original Message -------- Subject: Re: Printed message Date: Thu, 7 Dec 2006 16:30:54 +0100 From: Pierre Mauduit <pierre.mauduit(a)gmail.com> To: Robin Elfrink <elfrink(a)introweb.nl> References: <45782ECF.7050306(a)introweb.nl> Hi, > How about a user-configurable option then? > I think it is the best solution to get everybody happy with this :-) -- pierre

1 0

Re: Printed message
by Robin Elfrink 07 Dec '06

07 Dec '06

Chris Richardson wrote: > personally i prefer greyscale of print screens for the simple fact that > a lot of office brand printers are not color and faxes are not color. How about a user-configurable option then? Or would the settings get cluttered too much? Robin

1 0

French translation [Was Re: Tool for translations]
by Pierre Mauduit 07 Dec '06

07 Dec '06

Hi, nice work on the translation tool ! I tried it with the french language, so here's my result : http://pedrov.kwain.net/~pedrov/rcube/rcube_trans.txt By the way, I think - and all french folks would probably agree - that a better translation for "Junk mail" is the french term "Pourriel", since "A trier" means "to sort" in french. best regards, -- pierre

2 2

Problem when loging in.
by Tommy Lindström 06 Dec '06

06 Dec '06

Hi! I have a problem when I want to login from the web with roundcube. Everything looks fine in the imaplog and no errors are reported in the logdir of roundcube. I have set full debugging on. And my imapserver is cyrus. And both cyrus and roundcube are on the same server. When I login i get this message. "* CAPABILITY IMAP4 IMAP4rev1 ACL QUOTA LITERAL+ NAMESPACE UIDPLUS X-NON-HIERARCHICAL-RENAME NO_ATOMIC_RENAME UNSELECT X-NETSCAPE cp01 OK Completed Tried PLAIN: Resource id #32" Followed by a "Login Failed". Any help is appriciated.. thanks! PS. My setup works fine with ex. outlook. // Tommy

2 1

Security: Why is user password stored in session?
by Stefan Rompf 05 Dec '06

05 Dec '06

Hi, I've just installed Roundcubemail on my server to replace another webmail package. First impression: Very nice work! However, I'm one of those who at least try to review the software they use, and there is one thing that really caught my eye: The user password is stored in the PHP session. I think authentication data should be end to end data, especially if you're running Roundcubemail over https as you should. The attached, slightly tested patch moves the password from the session into a browser cookie. Thoughts? Stefan

8 10

dragging messages while checking for new messages broken
by Jason 04 Dec '06

04 Dec '06

I was having this problem, then finially upgraded to revision 361, but I'm still seeing it. If I'm in my inbox, and I try to click and drag a message over to another folder it works normally, but not while the periodic "checking for new messages" message is at the top of the page. I searched the trac tickets and the mailing list and didn't find anything. Is anyone else having this problem? Is there a way to fix it?

1 1

conditional objects in templates
by Edgar Bueltemeyer 02 Dec '06

02 Dec '06

Hello, i would like to make following proposal to the conditional objects in templates: Its rather flexible and supports normal variables and Session-vars..... in the template file: <roundcube:button command="print" imageSel="/images/buttons/ print_sel.png" imageAct="/images/buttons/print_act.png" imagePas="/ images/buttons/print_pas.png" width="32" height="32" title="printmessage" condition="session:username:test"/> </div> in main.inc: function rcube_xml_command($command, $str_attrib, $add_attrib=array()) { global $IMAP, $CONFIG, $OUTPUT; $command = strtolower($command); $attrib = parse_attrib_string($str_attrib) + $add_attrib; //check if tag is conditional if($attrib['condition']) { $condition=explode(':',$attrib['condition']); $logmesg="condition:".$condition[0].'='.print_array($condition); //console($logmesg); if(strpos($condition[2],',')) $condition_array=explode(',', $condition[2]); else $condition_array=array(0=>$condition[2]); switch ($condition[0]) { case 'session': // if sesion var is not set -> switch off command if(!in_array($_SESSION[$condition[1]],$condition_array)) $command='none'; break; default: if(!$condition[0]==$condition[1])) $command='none'; // condition is not handled -> switch off command break; } } Regards!

3 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev