Dev

dev@lists.roundcube.net

1 participants
4289 discussions

Re: Delete open email button in svn 380
by Martin Marques 23 Nov '06

23 Nov '06

On Wed, 22 Nov 2006 08:17:45 -0600, Matt Kaatman <roundcube-dev(a)matt.kaatman.com> wrote: > Do we have any goals before we release the next beta? > > Maybe a feature freeze is in order to get a newer beta out? > > Grabbing the head from SVN will probably never be bug free but I know I > and many others are using it in a "production" environment which is > never a great idea. If you are doing it this way, probably the best > thing you can do is constantly grab the latest source. > > Robin and any other devs are impressively responsive to fixing problems > we find and discuss on here. > > Maybe we should make a list of features that need to be finished before > the next beta and once those are knocked out set a bug-scrub day or two > where everyone combs over everything to find any remaining issues. Like, when I click on an html link that's attached to my mail RC opens a new window with RC (the folder list). Very odd. Another one is that the behavior when deleting a mail in the message list changed again. Before, when you deleted a message, the next one got selected, which doesn't happen now. Trash and spam folders can't get emptied (empty botton is grey). Configuration (at least sone things) don't get applied. Example, changing the interval in which drafts get saved. It's always in a default of 5 minutes (could this be realted to DB changes I haven't applied yet?) -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador --------------------------------------------------------- -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador ---------------------------------------------------------

3 6

First & last buttons
by Robin Elfrink 22 Nov '06

22 Nov '06

Hi, I added first and last buttons to the main page, the single-email page and the address book. If it's OK I'll commit this. Robin Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 371) +++ program/localization/en_US/labels.inc (working copy) @@ -98,7 +98,9 @@ $labels['deletemessage'] = 'Move message to trash'; $labels['printmessage'] = 'Print this message'; $labels['previousmessages'] = 'Show previous set of messages'; +$labels['firstmessages'] = 'Show first set of messages'; $labels['nextmessages'] = 'Show next set of messages'; +$labels['lastmessages'] = 'Show last set of messages'; $labels['backtolist'] = 'Back to message list'; $labels['viewsource'] = 'Show source'; @@ -171,7 +173,9 @@ $labels['export'] = 'Export'; $labels['previouspage'] = 'Show previous set'; +$labels['firstpage'] = 'Show first set'; $labels['nextpage'] = 'Show next set'; +$labels['lastpage'] = 'Show last set'; // LDAP search Index: program/js/app.js =================================================================== --- program/js/app.js (revision 371) +++ program/js/app.js (working copy) @@ -141,9 +141,15 @@ { this.enable_command('show', 'reply', 'reply-all', 'forward', 'moveto', 'delete', 'viewsource', 'print', 'load-attachment', true); if (this.env.next_uid) + { this.enable_command('nextmessage', true); + this.enable_command('lastmessage', true); + } if (this.env.prev_uid) + { this.enable_command('previousmessage', true); + this.enable_command('firstmessage', true); + } } if (this.env.action=='show' && this.env.blockedobjects) @@ -478,10 +484,18 @@ this.list_page('next'); break; + case 'lastpage': + this.list_page('last'); + break; + case 'previouspage': this.list_page('prev'); break; + case 'firstpage': + this.list_page('first'); + break; + case 'expunge': if (this.env.messagecount) this.expunge_mailbox(this.env.mailbox); @@ -656,10 +670,20 @@ this.show_message(this.env.next_uid); break; + case 'lastmessage': + if (this.env.last_uid) + this.show_message(this.env.last_uid); + break; + case 'previousmessage': if (this.env.prev_uid) this.show_message(this.env.prev_uid); break; + + case 'firstmessage': + if (this.env.first_uid) + this.show_message(this.env.first_uid); + break; case 'checkmail': this.check_for_recent(); @@ -1095,8 +1119,12 @@ { if (page=='next') page = this.env.current_page+1; + if (page=='last') + page = this.env.pagecount; if (page=='prev' && this.env.current_page>1) page = this.env.current_page-1; + if (page=='first' && this.env.current_page>1) + page = 1; if (page > 0 && page <= this.env.pagecount) { @@ -2634,7 +2662,9 @@ this.set_page_buttons = function() { this.enable_command('nextpage', (this.env.pagecount > this.env.current_page)); + this.enable_command('lastpage', (this.env.pagecount > this.env.current_page)); this.enable_command('previouspage', (this.env.current_page > 1)); + this.enable_command('firstpage', (this.env.current_page > 1)); } Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 371) +++ program/steps/mail/show.inc (working copy) @@ -60,7 +60,7 @@ $javascript .= sprintf("%s.set_env('safemode', '%b');", $JS_OBJECT_NAME, $_GET['_safe']); $next = $prev = -1; - // get previous and next message UID + // get previous, first, next and last message UID if (!($_SESSION['sort_col'] == 'date' && $_SESSION['sort_order'] == 'DESC') && $IMAP->get_capability('sort')) { @@ -69,21 +69,29 @@ $MESSAGE['index'] = array_search((string)$MESSAGE['UID'], $a_msg_index, TRUE); $prev = isset($a_msg_index[$MESSAGE['index']-1]) ? $a_msg_index[$MESSAGE['index']-1] : -1 ; + $first = count($a_msg_index)>0 ? $a_msg_index[0] : -1; $next = isset($a_msg_index[$MESSAGE['index']+1]) ? $a_msg_index[$MESSAGE['index']+1] : -1 ; + $last = count($a_msg_index)>0 ? $a_msg_index[count($a_msg_index)-1] : -1; } else { // this assumes that we are sorted by date_DESC $seq = $IMAP->get_id($MESSAGE['UID']); $prev = $IMAP->get_uid($seq + 1); + $first = $IMAP->get_uid($IMAP->messagecount()); $next = $IMAP->get_uid($seq - 1); + $last = $IMAP->get_uid(1); $MESSAGE['index'] = $IMAP->messagecount() - $seq; } if ($prev > 0) $javascript .= sprintf("\n%s.set_env('prev_uid', '%s');", $JS_OBJECT_NAME, $prev); + if ($first >0) + $javascript .= sprintf("\n%s.set_env('first_uid', '%s');", $JS_OBJECT_NAME, $first); if ($next > 0) $javascript .= sprintf("\n%s.set_env('next_uid', '%s');", $JS_OBJECT_NAME, $next); + if ($last >0) + $javascript .= sprintf("\n%s.set_env('last_uid', '%s');", $JS_OBJECT_NAME, $last); $OUTPUT->add_script($javascript); } @@ -173,4 +181,4 @@ parse_template('printmessage'); else parse_template('message'); -?> \ No newline at end of file +?> Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 371) +++ skins/default/templates/mail.html (working copy) @@ -25,9 +25,11 @@ </div> <div id="messagecountbar"> +<roundcube:button command="firstpage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstmessages" /> <roundcube:button command="previouspage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />  <roundcube:object name="messageCountDisplay" />  <roundcube:button command="nextpage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="lastpage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastmessages" /> </div> <div id="mailboxlist-header"><roundcube:label name="mailboxlist" /></div> Index: skins/default/templates/message.html =================================================================== --- skins/default/templates/message.html (revision 371) +++ skins/default/templates/message.html (working copy) @@ -11,9 +11,11 @@ <roundcube:include file="/includes/header.html" /> <div id="messagecountbar"> +<roundcube:button command="firstmessage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstmessages" /> <roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />  <roundcube:object name="messageCountDisplay" />  <roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="lastmessage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastmessages" /> </div> <div id="messagetoolbar"> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 371) +++ skins/default/templates/addressbook.html (working copy) @@ -20,9 +20,11 @@ </div> <div id="abookcountbar"> +<roundcube:button command="firstpage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstpage" /> <roundcube:button command="previouspage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previouspage" />  <roundcube:object name="recordsCountDisplay" />  <roundcube:button command="nextpage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextpage" /> +<roundcube:button command="lastpage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastpage" /> </div> <div id="addresslist">

2 1

Re: Delete open email button in svn 380
by Mark Bucciarelli 22 Nov '06

22 Nov '06

On Wed, Nov 22, 2006 at 08:17:45AM -0600, Matt Kaatman wrote: > Maybe we should make a list of features that need to be > finished before the next beta and once those are knocked out > set a bug-scrub day or two where everyone combs over everything > to find any remaining issues. There is still one issue open on the 0.1-beta2 milestone list (ticket #1349473). Not sure if this is still current, but I don't remember a more recent post on the same topic: Date: Fri, 14 Jul 2006 11:28:12 +0200 From: Thomas Bruederli <roundcube(a)gmail.com> Subject: Final round for 0.1beta2 Hi everybody I finally made it to go through the most tickets and assigned a set of bugs that IMO need to be fixed for the next milestone. There are now 16 pending tickets assigned to milestone 0.1beta2: http://trac.roundcube.net/trac.cgi/query?status=new&status=assigned&status=… It looks like I will have some time again to work on the project for the next couple of weeks. Let's try to get rid of those 16 tix and we're ready to publish a new release. This will also be the first release that is "planned" with the Trac system and a proof of success of that platform. Please catch yourself some unassigned tickets and help finish this milestone. Thanks! Thomas m

2 1

Patch for imap.inc: Fixes #1483977 and #1483886
by Alexander Griesser 22 Nov '06

22 Nov '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi folks! I'm new to roundcubemail (just using it since yesterday) and today I found out, that passwords that contain german umlauts don't get authenticated correctly. After having a look at the sourcecode I found the file that contained the bug and it is located in imap.inc (iil_C_Login). Attached to this mail is a patch that fixes this issue, as well as the bugs #1483977 and #1483886. I know, that the imap library was taken from ilohamail and therefore I also informed the ilohamail mailing list about this issue and asked them to apply this patch too. The patch can also be downloaded here: http://tuxx-home.at/projects/roundcubemail/roundcubemail-loginumlauts.diff PS.: Please reply to me directly as I am not subscribed to the list. best regards, - -- | .-. | Alexander Griesser -- <private(a)tuxx-home.at> | .''`. | | /v\ \ http://www.tuxx-home.at/ / : :' : | | /( )\ | GPG-KeyID: 0xA2949B5A | `. `' | | ^^ ^^ `-------------------------------------------------' `- | -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFGkNn66HVD6KUm1oRAvn/AJ0alB0K3Dc2kbW9s1Q3Pw2P9oczAACgnUYn mp4nD4FwqVEhwPilFMJZZhc= =sBPk -----END PGP SIGNATURE----- --- imap.inc.orig 2006-09-27 10:51:22.408713456 +0200 +++ imap.inc 2006-09-27 10:50:26.982139576 +0200 @@ -225,7 +225,9 @@ function iil_C_Login(&$conn, $user, $password){ - fputs($conn->fp, "a001 LOGIN $user \"$password\"\r\n"); + // $passwords needs to be utf8_decode'd so that the german umlauts don't + // get corrupted. Updated by php(a)tuxx-home.at, ag + fputs($conn->fp, "a001 LOGIN $user \"" . utf8_decode($password) . "\"\r\n"); do{ $line = iil_ReadReply($conn->fp);

10 15

Delete open email button in svn 380
by Marco Balmer 22 Nov '06

22 Nov '06

Hello In svn380 of roundcube I can not delete an open email message with firefox 2. Is that a bug or problem with my client? Thx /maba

4 7

Single mime part email
by Robin Elfrink 22 Nov '06

22 Nov '06

Hi, I have an email with a single mime part which looks like this (irrelevant headers removed): =========================================== Content-class: urn:content-classes:message X-MS-Has-Attach: yes MIME-Version: 1.0 Content-Type: application/vnd.ms-excel; name="Bureau CVL 06-10.xls" Content-Transfer-Encoding: base64 Content-Description: Bureau CVL 06-10.xls Content-Disposition: attachment; filename="Bureau CVL 06-10.xls" X-MS-TNEF-Correlator: X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 0M8R4KGxGuEAAAAAAAAAAAAAAAAAAAAAPgADAP7/CQAGAAAAAAAAAAAAAAABAAAAAQAAAAAAAAAA EAAAEgAAAAEAAAD+////AAAAAAAAAAD///////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// etc... =========================================== So basically it's a single mime part email. This usually does not happen with _normal_ MUA's, but MS Exchange seems not to care what the world thinks. Anyway, I fixed this one with attached patch, but I am not sure about any impact with other emails with or without attachments. I looked at about 50 different emails with and without attachments, from normal users and MS users, and I found no error so far. Would you people please take a look and see if this is fine? Robin Index: program/lib/mime.inc =================================================================== --- program/lib/mime.inc (revision 382) +++ program/lib/mime.inc (working copy) @@ -108,7 +108,7 @@ } //echo "s - part: $part rest: $rest array: ".implode(" ", $a)."<br>\n"; if (is_array($a[$part-1])) return $a[$part-1]; - else return false; + else return $a; }else if (($part==0) || (empty($part))){ return $a; } Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 382) +++ program/steps/mail/func.inc (working copy) @@ -983,6 +983,18 @@ } } + // message is single part non-text + else + { + if (($fname = $structure->d_parameters['filename']) || + ($fname = $structure->ctype_parameters['name']) || + ($fname = $structure->headers['content-description'])) + { + $structure->filename = rcube_imap::decode_mime_string($fname); + $a_attachments[] = $structure; + } + } + return array($a_return_parts, $a_attachments); }

1 0

Fw: [Full-disclosure] XSS in roundcube.com and users of it
by Chris Largret 22 Nov '06

22 Nov '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey, I'm sure others have seen this as it's a couple days old now, but I'm just passing it along. It should have been sent to you guys first, but I don't see a reference on the dev list and it still works. - -Chris Begin forwarded message: Date: Sat, 11 Nov 2006 10:51:00 -0800 From: RSnake <h(a)ckers.org> To: full-disclosure(a)lists.grok.org.uk Subject: [Full-disclosure] XSS in roundcube.com and users of it There is an XSS vulnerability in roundcube webmail: http://demo.roundcube.net/?_task=');alert(%22XSS%22)// Btw, we've been posting 0-day XSS vulnerabilities at http://sla.ckers.org/forum/list.php?3 to take it out of the full disclosure list since lots of people don't want to see the sheer volume of reports. We've got close to a thousand companies and counting. We're just trying to cut down on the noise to people's inboxes. That is all. - -RSnake http://ha.ckers.org http://sla.ckers.org _______________________________________________ Full-Disclosure - We believe in it. Charter: http://lists.grok.org.uk/full-disclosure-charter.html Hosted and sponsored by Secunia - http://secunia.com/ - -- Chris Largret <http://www.largret.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFYqBuyBrDZUqad5ERAnXiAJ0Tg2JFCHj2EDXfV+5O94HBQiqaEwCfWcSl Pk1XfZ72hbyNh1twaJI7Fec= =N4Z8 -----END PGP SIGNATURE-----

7 6

Database error (1f4)
by Jason Dixon 20 Nov '06

20 Nov '06

Sorry, I know this is a FAQ but I've checked everything four times and am starting to wonder if something else is amiss. I've checked that the credentials work fine from the command line. The configs are very similar to prior installations on different servers. This server is running MySQL-5.x, so I made sure to use mysql5.initial.sql, and used the proper CREATE DATABASE statement as listed in the INSTALL file. This server hosts a number of other applications using PHP5 and MySQL-5.x, so it shouldn't be a dependencies issue. [Mon Nov 20 19:42:08 2006] [error] PHP Notice: DB Error: extension not found in /home/www/roundcube-svn-373/program/include/bugs.inc on line 80 Any ideas? Thanks, -- Jason Dixon DixonGroup Consulting http://www.dixongroup.net

1 1

Dupe bugs
by techlist 20 Nov '06

20 Nov '06

These seem to be dupes: Tickets #1456834 & #1483822 Tickets #1483926 & </trac.cgi/ticket/1483926>#1484015 </trac.cgi/ticket/1484015> -- Jay Lanstein Vice President Cantella & Co., Inc. 2 Oliver Street, 11th Floor Boston, MA 02109 (617)224-1426 - direct (617)521-8630 - office (617)521-8604 - fax The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

2 1

Preview Pane
by Geoff Hasz 20 Nov '06

20 Nov '06

I applied your patch for the preview pane according to: http://lists.roundcube.net/mail-archive/roundcube.dev/2006/10/51/ When I view an email in the preview pane that has images. the images don't show and there is no options to view images as in the single email window. Is that known issue or is it my configuration? Also is there a way to resize the the pane so the pane is bigger than the email list even if its hard coded? Thanks Geoff

3 4

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev