Dev

dev@lists.roundcube.net

1 participants
4313 discussions

Fix for Bug #1483930
by Michael Bueker 15 Aug '06

15 Aug '06

Hi, I've worked on Bug #1483930 and resolved it thus: There are now two additional labels named "previousmessage" and "nextmessage", which are used in message.html, as opposed to "previousmessages" and "nextmessages" in mail.html. I've included the label entries for en_GB, en_US, de_DE, de_CH and es in the patch. If that's an okay course of action for you, please commit the patch and close the ticket :) Cheers, mtu -- What seems to be the Officer, problem? - From South Park, "Bloody Mary" diff -uNr rc-294/program/localization/de_CH/labels.inc rc-294fix/program/localization/de_CH/labels.inc --- rc-294/program/localization/de_CH/labels.inc 2006-08-06 15:51:22.000000000 +0200 +++ rc-294fix/program/localization/de_CH/labels.inc 2006-08-06 17:15:07.000000000 +0200 @@ -99,7 +99,9 @@ $labels['deletemessage'] = 'In den Papierkorb verschieben'; $labels['printmessage'] = 'Diese Nachricht drucken'; $labels['previousmessages'] = 'Vorherige Nachrichten anzeigen'; -$labels['nextmessages'] = 'Weitere Nachrichten anzeigen'; +$labels['previousmessage'] = 'Vorherige Nachricht anzeigen'; +$labels['nextmessages'] = 'Folgende Nachrichten anzeigen'; +$labels['nextmessage'] = 'Folgende Nachricht anzeigen'; $labels['backtolist'] = 'Zurück zur Liste'; $labels['select'] = 'Auswählen'; diff -uNr rc-294/program/localization/de_DE/labels.inc rc-294fix/program/localization/de_DE/labels.inc --- rc-294/program/localization/de_DE/labels.inc 2006-08-06 15:51:20.000000000 +0200 +++ rc-294fix/program/localization/de_DE/labels.inc 2006-08-06 17:03:49.000000000 +0200 @@ -100,7 +100,9 @@ $labels['deletemessage'] = 'In den Papierkorb verschieben'; $labels['printmessage'] = 'Diese Nachricht drucken'; $labels['previousmessages'] = 'Vorherige Nachrichten anzeigen'; -$labels['nextmessages'] = 'Weitere Nachrichten anzeigen'; +$labels['previousmessage'] = 'Vorherige Nachricht anzeigen'; +$labels['nextmessages'] = 'Folgende Nachrichten anzeigen'; +$labels['nextmessage'] = 'Folgende Nachricht anzeigen'; $labels['backtolist'] = 'Zurück zur Liste'; $labels['select'] = 'Auswählen'; diff -uNr rc-294/program/localization/en_GB/labels.inc rc-294fix/program/localization/en_GB/labels.inc --- rc-294/program/localization/en_GB/labels.inc 2006-08-06 15:51:20.000000000 +0200 +++ rc-294fix/program/localization/en_GB/labels.inc 2006-08-06 16:56:16.000000000 +0200 @@ -99,7 +99,9 @@ $labels['deletemessage'] = 'Move message to trash'; $labels['printmessage'] = 'Print this message'; $labels['previousmessages'] = 'Show previous set of messages'; +$labels['previousmessage'] = 'Show previous message'; $labels['nextmessages'] = 'Show next set of messages'; +$labels['nextmessage'] = 'Show next message'; $labels['backtolist'] = 'Back to message list'; $labels['viewsource'] = 'Show source'; diff -uNr rc-294/program/localization/en_US/labels.inc rc-294fix/program/localization/en_US/labels.inc --- rc-294/program/localization/en_US/labels.inc 2006-08-06 17:09:45.000000000 +0200 +++ rc-294fix/program/localization/en_US/labels.inc 2006-08-06 16:58:43.000000000 +0200 @@ -98,7 +98,9 @@ $labels['deletemessage'] = 'Move message to trash'; $labels['printmessage'] = 'Print this message'; $labels['previousmessages'] = 'Show previous set of messages'; +$labels['previousmessage'] = 'Show previous message'; $labels['nextmessages'] = 'Show next set of messages'; +$labels['nextmessage'] = 'Show next message'; $labels['backtolist'] = 'Back to message list'; $labels['viewsource'] = 'Show source'; diff -uNr rc-294/program/localization/es/labels.inc rc-294fix/program/localization/es/labels.inc --- rc-294/program/localization/es/labels.inc 2006-08-06 15:51:22.000000000 +0200 +++ rc-294fix/program/localization/es/labels.inc 2006-08-06 17:05:28.000000000 +0200 @@ -103,7 +103,9 @@ $labels['deletemessage'] = 'Mover mensaje a la papelera'; $labels['printmessage'] = 'Imprimir este mensaje'; $labels['previousmessages'] = 'Mostrar mensajes anteriores'; +$labels['previousmessage'] = 'Mostrar mensaje anterior'; $labels['nextmessages'] = 'Mostrar mensajes siguientes'; +$labels['nextmessage'] = 'Mostrar mensaje siguiente'; $labels['backtolist'] = 'Volver a la lista de mensajes'; $labels['viewsource'] = 'Mostrar código'; diff -uNr rc-294/skins/default/templates/message.html rc-294fix/skins/default/templates/message.html --- rc-294/skins/default/templates/message.html 2006-08-06 15:51:29.000000000 +0200 +++ rc-294fix/skins/default/templates/message.html 2006-08-06 17:26:15.000000000 +0200 @@ -11,9 +11,9 @@ <roundcube:include file="/includes/header.html" /> <div id="messagecountbar"> -<roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" /> +<roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessage" />  <roundcube:object name="messageCountDisplay" />  -<roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessage" /> </div> <div id="messagetoolbar">

1 1

Re: Sorting Support in IMAP
by Eric Stadtherr 14 Aug '06

14 Aug '06

2 2

Sorting Support in IMAP
by Kevin Landers 14 Aug '06

14 Aug '06

I am wondering what kind of look up or test RoundCube does in order to decide whether or not it will allow the user to use the sorting function at the top of the columns in your mail folders. I have had the problem with quotas in the past, where RoundCube's initial look for Quota support in IMAP failed, even though Quota support does exist. So I had to comment out the checks for the Quota support in order to force RC to just go ahead and use the Quota functions. I am wondering if RC is doing a similar lookup in reference to sorting. I have logged in using Brett's RC 0.1 Beta 2 demo install. I logged into a demo account provided by "SKaero" on the RC forums. When I use his demo email account, the sorting features are present in each column. However, I then logged out and logged back in using my own account on my own server and I do not receive any sorting options. Where should I look to resolve this issue? Anyone have any insights? Thanks in advance, Kevin L.

2 3

New Template Command
by Brett Patterson 13 Aug '06

13 Aug '06

Hi all. After a user on the forum (Flash) tried to easily add a variable into a template. He tried many things, and I devised a nice template way of doing it. You can see the steps to do so here: http://roundcubeforum.net/forum/index.php?topic=342.msg1887#msg1887 It works as expected in the following manner: <roundcube:variable name="variableName" /> As with PHP, variableName != VariableName != VARIABLENAME != vArIaBlEnAmE != . . . so the name is case sensitive. This allows users to add variables they want in to their skin easily. Not sure if you want to add this or not, but I thought I'd put it on the table as an option for the beta3 or rc1 release (whichever naming convention you want to go with). ~Brett

1 0

attachment problem
by George Wu 11 Aug '06

11 Aug '06

There is a bug with roundcube where attachments don't get correctly displayed. This happens when a user sends email with an attachment via Apple Mail client to a user using roundcube. Although the email is viewable there is no attachment. Forwarding and saving to drafts correctly displays an attachment as well as forwarding to anyone else. diff -uNr rev304/roundcubemail/program/steps/mail/func.inc rev304-fixed/program/steps/mail/func.inc --- rev304/roundcubemail/program/steps/mail/func.inc 2006-08-08 16:27:06.000000000 -0700 +++ /var/www/lolamail/program/steps/mail/func.inc 2006-08-09 10:53:10.000000000 -0700 @@ -426,7 +426,8 @@ $message_icon = $attrib['messageicon']; // set attachment icon - if ($attrib['attachmenticon'] && preg_match("/multipart\/m/i", $header->ctype)) +// if ($attrib['attachmenticon'] && preg_match("/multipart\/m/i", $header->ctype)) + if ($attrib['attachmenticon'] && preg_match("/multipart\//i", $header->ctype)) $attach_icon = $attrib['attachmenticon']; $out .= sprintf('<tr id="rcmrow%d" class="message%s%s %s">'."\n", @@ -875,7 +876,8 @@ } // message contains multiple parts - else if ($message_ctype_primary=='multipart' && is_array($structure->parts)) + // else if ($message_ctype_primary=='multipart' && is_array($structure->parts)) + if ($message_ctype_primary=='multipart' && is_array($structure->parts)) { foreach ($structure->parts as $mail_part) { I've commented out the lines in question that cause this bug and replaced them with lines that do show the attachment. Is there a reason why lines 813 and down aren't under line 878 (i.e. nested if)? Also I can send out an email via Apple Mail if anyone is interested. Basically Apple Mail uses multipart/alternative as default and an attachment is contained after it. - George

1 1

Encoding problem
by Jan Mikus 11 Aug '06

11 Aug '06

There is encoding problem in headers with central european characters. Recipient address "Jan Mikuš <mikus(a)itcomputers.cz>" after encoding return "=?UTF-8?Q?Jan=20Miku=C5=A1=20<mikus(a)itcomputers.cz>?=" (right is "=?UTF-8?Q?Jan=20Miku=C5=A1?= <mikus(a)itcomputers.cz>") and Postfix this header encode to "=?UTF-8?Q?Jan=20Miku=C5=A1=20 <mikus(a)itcomputers.cz>,\n ?=(a)arachne.itcomputers.cz".

3 2

Alert message when attaching a file to a mail
by Ian 11 Aug '06

11 Aug '06

Hello, Since I updated Roundcube with the second beta, a JS alert() with some obscure HTML code is shown every time I upload an attachment. The file is uploaded correctly, I think this message was just used for debugging purpose. It can be removed by removing the line 2189 of the file "program/js/app.js". (the one with "alert(content)") Ian

2 1

Re: Addressbook database (was Re: Ticket #1332930 (Feature Requests))
by Eric Stadtherr 10 Aug '06

10 Aug '06

Brett, I have to disagree - XML is not meant for persistent storage of application data. You sacrifice referential integrity and efficient query capability if you just store everything as long text documents. Sure, the code to parse and transform it is easy, but the runtime cost of parsing through a complicated XML document for a single value in a single context is significant. Picture the popup address completion list taking 3-5 seconds to fill itself out when you start typing a name into the "Recipient" field... As an aside, if we do ever end up wanting to represent contact information in XML, there's a schema out there already for it: http://www.jabber.org/jeps/jep-0054.html -Eric > Eric Stadtherr wrote: >> >> I would suggest a database schema such as the following (let me know >> if my HTML table doesn't come across correctly): >> >> <snip> >> >> This would make it easily mappable to vCard contents without being too >> locked into vCard specifics. The "Field" column keeps you from having >> "n" columns for "n" bits of information (and saves space if only a >> subset of the fields are provided for a contact). The labels would map >> reasonably well to vCard parameters, while maintaining semantic >> consistency with tools like Apple's Address Book. Primary Key could be >> a simple surrogate key assigned to each row, or a compound key >> consisting of (Contact ID, Field, Label). The compound key would be >> more intuitive, but may cause implementation problems if the database >> provider doesn't like NULL values in the PK. Indexes could be built on >> any combination of columns to optimize searching. >> >> What do you think? >> >> -Eric >> >> >> >> On Thu, 10 Aug 2006 20:07:52 +0200, Thomas Bruederli wrote: >> >> Eric Stadtherr wrote: >> > Should rev306 be backed out then? It goes against this concept. >> > >> Well, my explanations haven't been clear enough when I talked to >> Tobias... I'll take care of that, but it definitely goes against my > ideas. >> >> I don't see any reason to have lots of fields in the database if we >> choose a format that can be parsed fast and allows us interchange > the >> data with other formats for import/export/sync. If searching the >> contacts gets a problem I suggest to create a fulltext index with > all >> field values required for search. >> >> Please don't hesitate to post your opinions to the > addressbook/database >> design. >> >> Regards, >> Thomas >> > Upon that note, why not use XML... it's what it's meant for. Instead of > another table to hold contacts, or multiple rows per contact, just store > XML data in one field. Then you can have X number of attributes of any > vCard or whatever format. It's easily parsable in PHP and can be > exported in a number for formats. It may even be quicker ;) > > <?xml version="1.0" encoding="ISO-8859-1"?> > <contacts> > <contact> > <fullname>FN</fullname> > <email type="home">fname(a)site.domain</email> > <email type="work">full.name(a)company.com</email> > <tele type="fax">+1 011-555-1234</tele> > </contact> > <contact> > <fullname>FN2</fullname> > <email type="home">someone(a)somewhere.de</email> > <tele type="work">+1 234-555-6666</tele> > </contact> > </contacts> > > Something like that would work wouldn't it? Obviously all the values > would be wrapped inside of <![CDATA[ ]]> tags... > > ~Brett

1 0

UTF7 - UTF8 folder encoding errors
by Eric Liang 10 Aug '06

10 Aug '06

Hello, I think the functions for UTF7-UTF8 encoding/decoding are not performing well, especially on the folders (view/create/rename folder). This happens mostly on non ISO-8859-1 charsets (in the source it shows that this function is not yet done). Is there a chance we get IMP's enc/decoding functions and use those instead? They work nicely in any system I tested IMP on. If someone wants privately to work with me on this issue please contact me directly. I am willing to spend a lot of my time in testing and debugging. I tried to fix this myself but I'm not good enough and even though I managed to decode folders fine (these folders contained foreign chars created by other programs) I messed things up with other functions. So basically I need someone who knows what he's doing in order to fix this together. Also, I propose that wherever needed, we should make the charset conversion assumptions configurable by the admin and not have them hardcoded to ISO-8859-1. If someone wants to work on this with me (I have a test system showcasing the issues which can be used for testing the fixes as well) please contact me directly. Thanks, Eric

3 6

Integrated spelling - how to get results?
by Martin Moeller 10 Aug '06

10 Aug '06

Hello folks. I'm handling the Danish translations and just learned of this this so I thought I'd join in. RoundCube 0.1beta2 is up and running great (with Danish translations and all), but no matter how badly I misspell words and try to check them for correctness, RoundCube always ends up saying that there were no errors. This happens with both Danish and English text and the language chosen appropriately from the menu. I assume the actual POST of the textarea is a client event? I didn't have HTTPS out allowed on the server but even when I do, it doesn't seem to work. There shouldn't be any blocks on my local machine, though... It is supposed to contact google.com as far as I can tell and that should now be allowed whether client or server-side. Anyone else seeing this? This is with Firefox 1.5.x. I tried the orange<whatsitsname> speller. That was in konqueror but it worked correctly.. Just tested that same page in Firefox, works fine... This is the link: http://orangoo.com/labs/?page_id=72 Good ideas would be greatly appreciated. It would be really nice to have that type of spell-checking available in webmail... /Martin.

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev