Dev

dev@lists.roundcube.net

2 participants
4300 discussions

Return receipt checkbox/message overlaps Priority select box on Compose message
by Vahan Yerkanian 01 Aug '06

01 Aug '06

Greetings all, There is a minor visual bug with the "Return receipt" checkbox/message in Compose message screen, overlaping the Priority select box (f.e. in Armenian version) when the contents of the select box are long enough. Best regards, Vahan

1 0

svn 284
by Brett Patterson 31 Jul '06

31 Jul '06

Hey Thomas and Charles, perhaps one of you could look into the sorting issue with the latest SVN. Just got it to play with the highlighting, and noticed some things wrong: 1.) Sorting by anything doesn't work. 2.) Highlighting is good but there is an issue: -- Firefox (WIndows) won't switch between "active" and "inactive" for me Other than that, great work. Can't wait for the next beta!! ~Brett Patterson www.roundcubeforum.net Roundcube Forum Admin

4 4

folders patch
by Charles McNulty 31 Jul '06

31 Jul '06

Here's a pretty simple patch for doing the drag over a folder thing. The other thing it does is keeps track of whether the "folder" portion of the screen or the "mail" portion of the screen has the "focus" and changes the color accordingly. For example if you've clicked on the Inbox folder, the folder will be colored red. If you then select a message, the Inbox folder will now be highlighted in grey and the message you've selected will be red. If you click back on to the Inbox folder, the message you've selected will turn grey and "Inbox" will turn back red. If you go back to the message list, select a message and drag it over the folder list, the folder's will turn red as your mouse hovers over them. I've tested this a little, but of course it could always use more testing. Please let me know your thoughts on this patch. -Charles Index: program/js/app.js =================================================================== --- program/js/app.js (revision 274) +++ program/js/app.js (working copy) @@ -244,7 +244,6 @@ // load body click event document.onmousedown = function(){ return rcube_webmail_client.reset_click(); }; document.onkeydown = function(e){ return rcube_webmail_client.key_pressed(e, msg_list_frame); }; - // flag object as complete this.loaded = true; @@ -285,6 +284,14 @@ } } + if (this.gui_objects.mailboxlist) { + var s_mbox = String(this.env.mailbox).toLowerCase().replace(this.mbox_expression, ''); + var mbox_li = document.getElementById('rcmbx'+s_mbox); + + if (mbox_li) + this.set_classname(mbox_li, 'unfocused', true); + } + this.in_message_list = true; e.cancelBubble = true; }; @@ -1161,9 +1168,10 @@ // onmouseup handler for mailboxlist item this.mbox_mouse_up = function(mbox) { - if (this.drag_active) + if (this.drag_active){ + this.unfocus_mailbox(mbox); this.command('moveto', mbox); - else + } else this.command('list', mbox); return false; @@ -1529,8 +1537,7 @@ if (this.env.search_request) add_url += '&_search='+this.env.search_request; - if (this.env.mailbox!=mbox) - this.select_mailbox(mbox); + this.select_mailbox(mbox); // load message list remotely if (this.gui_objects.messagelist) @@ -1634,7 +1641,26 @@ return true; }; - + this.focus_mailbox = function(mbox) { + if (this.gui_objects.mailboxlist && this.drag_active) { + var s_mbox = String(mbox).toLowerCase().replace(this.mbox_expression, ''); + var mbox_li = document.getElementById('rcmbx'+s_mbox); + + if (mbox_li) + this.set_classname(mbox_li, 'selected', true); + } + } + + this.unfocus_mailbox = function(mbox) { + if (this.gui_objects.mailboxlist && this.drag_active) { + var s_mbox = String(mbox).toLowerCase().replace(this.mbox_expression, ''); + var mbox_li = document.getElementById('rcmbx'+s_mbox); + + if (mbox_li) + this.set_classname(mbox_li, 'selected', false); + } + } + // move selected messages to the specified mailbox this.move_messages = function(mbox) { @@ -2199,7 +2225,6 @@ highlight.removeAttribute('id'); //highlight.removeAttribute('class'); this.set_classname(highlight, 'selected', false); - this.set_classname(highlight, 'unfocused', false); } if (next) @@ -2990,7 +3015,7 @@ // mark a mailbox as selected and set environment variable this.select_mailbox = function(mbox) { - if (this.gui_objects.mailboxlist) + if (this.gui_objects.mailboxlist ) { var item, reg, text_obj; var s_current = this.env.mailbox.toLowerCase().replace(this.mbox_expression, ''); @@ -3003,8 +3028,10 @@ if (current_li) { this.set_classname(current_li, 'selected', false); this.set_classname(current_li, 'unfocused', false); - } - if (mbox_li) + } + + if (mbox_li || this.env.mailbox == mbox) + this.set_classname(mbox_li, 'unfocused', false); this.set_classname(mbox_li, 'selected', true); } Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 274) +++ program/steps/mail/func.inc (working copy) @@ -216,6 +216,8 @@ $out .= sprintf('<li id="rcmbx%s" class="mailbox %s %s%s%s"><a href="%s&_mbox=%s"'. ' onclick="return %s.command(\'list\',\'%s\')"'. + ' onmouseover="return %s.focus_mailbox(\'%s\')"' . + ' onmouseout="return %s.unfocus_mailbox(\'%s\')"' . ' onmouseup="return %s.mbox_mouse_up(\'%s\')"%s>%s</a>', $folder_css, $class_name, @@ -227,7 +229,12 @@ $JS_OBJECT_NAME, addslashes($folder['id']), $JS_OBJECT_NAME, + addslashes($folder['id']), + $JS_OBJECT_NAME, + addslashes($folder['id']), + $JS_OBJECT_NAME, addslashes($folder['id']), + $title, rep_specialchars_output($foldername, 'html', 'all')); Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 274) +++ skins/default/mail.css (working copy) @@ -266,7 +266,7 @@ #mailboxlist li.selected { - background-color: #929292; + background-color: #CC3333; border-bottom: 1px solid #898989; } @@ -276,7 +276,18 @@ font-weight: bold; } +#mailboxlist li.unfocused +{ + background-color: #929292; + border-bottom: 1px solid #898989; +} +#mailboxlist li.unfocused a +{ + color: #FFF; + font-weight: bold; +} + /* styles for nested folders */ #mailboxlist ul { list-style: none;

3 4

Segfaults after the 'Cannot modify header...' error
by phil 31 Jul '06

31 Jul '06

As a followup, I'm now seeing some regular segfaulting of Apache after some of the 'Cannot modify header information - headers already sent in Unknown on line 0" error that I keep getting in /var/log/httpd-error.log: [Mon Jun 26 13:10:34 2006] [error] [client 70.246.222.74] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Mon Jun 26 13:10:34 2006] [error] [client 70.246.222.74] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Mon Jul 31 13:10:34 2006] [notice] child pid 75525 exit signal Segmentation fault (11) [Thu Jun 15 13:24:45 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Thu Jun 15 13:24:45 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Mon Jul 31 13:24:45 2006] [notice] child pid 75657 exit signal Segmentation fault (11) This is on Apache 2.0.58 with php5-5.1.4 - FreeBSD 6.0 P -- http://fak3r.com - you don't have to kick it -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

1 0

fixed bag in roundcube webmail
by Alexander A. Boykov 31 Jul '06

31 Jul '06

hello. maybe it's not bug, but in my system when i create first mailbox and login in webmail - there are no folders Sent and Trash. i read source code and make change: *** rcube_imap.inc.bak 2006-07-31 19:29:27.000000000 +0400 --- rcube_imap.inc 2006-07-31 19:28:21.000000000 +0400 *************** *** 364,370 **** --- 364,374 ---- if (!in_array_nocase('INBOX', $a_folders)) { $this->create_mailbox('INBOX', TRUE); + $this->create_mailbox('Sent', TRUE); + $this->create_mailbox('Trash', TRUE); array_unshift($a_folders, 'INBOX'); + array_unshift($a_folders, 'Sent'); + array_unshift($a_folders, 'Trash'); } $a_mailbox_cache = array(); now mailboxes creatres succesfully. thanks. -- С уважением, Бойков Александр Системный администратор HighLink a.boykov(a)sweb.ru

1 0

Re: HMGP to Acquire Additional 104 Wells - Susana Henley
by Odessa Grimm 31 Jul '06

31 Jul '06

coachwork pilferage bedevil drafty Hemi Energy (HMGP) to Acquire an Additional 104 Wells cancerous GRAHAM, Texas--(BUSINESS WIRE)--Mon, 31 Jul 2006 09:12:19 -0600--Hemi Energy (HMGP) announces that it is finalizing the acquisition of approximately 104 additional wells. These additional wells are located adjacent and offsetting to the 63 wells currently being upgraded and converted to EOR (Enhanced Oil Recovery). This acquisition will allow for ongoing expansion of Hemi's current Eastern Kansas EOR operations. This critical acquisition will give Hemi in excess of four contiguous square miles of EOR operations. This acquisition is expected to close within 7-14 working days. choice paleozoic prognosis http://biz.yahoo.com/bw/060727/20060727005065.html?.v=1 - Read the Entire Press Release Here

1 0

2 bugs ?
by Frank Habermann 31 Jul '06

31 Jul '06

Hello, i use the acutal(i belive its 284) svn version of roundcube and i have the following problems. if i write a mail not every mail is really send. the second problem is listing. roundcube make a background refresh of the list so that new mails in my account will be displayed. the problem here is that some mails will be displayed two or more times. if i make a hole refresh all is good. and the last thing. the number of new mails on the left side is not always right. sometimes it is not displayed and sometimes he shows new mails and i have no mails in my account. i use firefox 1.5.0.5 and on the server debian sarge with mysql 4.0.x and php4.3.x. I hope that will help. regards, Frank

2 1

Folder name in browser header
by Erik 30 Jul '06

30 Jul '06

When selecting a folder the name does not show in the browser header. Only after hitting enter the name shows. This was a bug in the past which had been solved. Apparently it's back. I'm currently running 284, but I've noticed in the 283 as well. I thought there was ticket for this but I can't find it. Does anybody know if this ticket should be in Trac? If not then I will create a new ticket, but I'd rather re-open the old one. -- Regards, Erik

1 0

Cannot modify header info error
by phil 29 Jul '06

29 Jul '06

Ok, I've read/reread the thread about this error, but I still don't understand how to clear it up. Something about taking out the ?php> - but from where? [Thu Jul 27 12:26:21 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header info rmation - headers already sent in Unknown on line 0 Thanks P -- http://fak3r.com - you don't have to kick it -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

2 1

[patch] Junk mail highlight in message list (SpamAssassin specific)
by Manu 28 Jul '06

28 Jul '06

Hi, Here a very small patch for roundcube-cvs-20060413 (the one I run) and the revision-282. If a mail is marked as spam by SpamAssassin (X-Spam-Flag in headers) the message is hightlighted in light green in message list. This can be easily "disabled" by commentting the related section in the CSS. Hope you'll find this useful. Les informations contenues dans ce message électronique peuvent être de nature confidentielle et soumises à une obligation de secret. Elles sont destinées à l'usage exclusif du réel destinataire. Si vous n'êtes pas le réel destinataire ou si vous recevez ce message par erreur, merci de nous le notifier immédiatement en le retournant à l'adresse de son émetteur. The information contained in this e-mail may be privileged and confidential. It is intended for the exclusive use of the designated recipients named above. If you are not the intended recipient or if you receive this e-mail in error, please notify us immediatly and return the original message at the address of the sender. diff -ruN roundcubemail-cvs-20060413/program/lib/imap.inc /var/www/roundcubemail-cvs-20060413/program/lib/imap.inc --- roundcubemail-cvs-20060413/program/lib/imap.inc 2006-03-27 21:06:30.000000000 +0200 +++ /var/www/roundcubemail-cvs-20060413/program/lib/imap.inc 2006-07-27 12:40:13.000000000 +0200 @@ -1212,7 +1212,7 @@ /* FETCH date,from,subject headers */ $key="fh".($c++); - $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE)])\r\n"; + $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE X-SPAM-FLAG)])\r\n"; if (!fputs($fp, $request)) return false; do{ @@ -1261,6 +1261,7 @@ $result[$id]->from = $headers["from"]; $result[$id]->to = str_replace("\n", " ", $headers["to"]); $result[$id]->subject = str_replace("\n", "", $headers["subject"]); + $result[$id]->junk = array_key_exists("x-spam-flag", $headers) ? true : false; $result[$id]->replyto = str_replace("\n", " ", $headers["reply-to"]); $result[$id]->cc = str_replace("\n", " ", $headers["cc"]); $result[$id]->bcc = str_replace("\n", " ", $headers["bcc"]); @@ -2079,4 +2080,4 @@ return (iil_C_Expunge($conn, $folder) >= 0); } -?> \ No newline at end of file +?> diff -ruN roundcubemail-cvs-20060413/program/steps/mail/func.inc /var/www/roundcubemail-cvs-20060413/program/steps/mail/func.inc --- roundcubemail-cvs-20060413/program/steps/mail/func.inc 2006-04-06 19:35:04.000000000 +0200 +++ /var/www/roundcubemail-cvs-20060413/program/steps/mail/func.inc 2006-07-27 12:42:40.000000000 +0200 @@ -406,11 +406,12 @@ // set attachment icon if ($attrib['attachmenticon'] && preg_match("/multipart\/m/i", $header->ctype)) $attach_icon = $attrib['attachmenticon']; - - $out .= sprintf('<tr id="rcmrow%d" class="message%s%s %s">'."\n", + + $out .= sprintf('<tr id="rcmrow%d" class="message%s%s%s %s">'."\n", $header->uid, $header->seen ? '' : ' unread', $header->deleted ? ' deleted' : '', + $header->junk ? ' junk' : '', $zebra_class); $out .= sprintf("<td class=\"icon\">%s</td>\n", $message_icon ? sprintf($image_tag, $skin_path, $message_icon, '') : ''); @@ -1470,4 +1471,4 @@ } -?> \ No newline at end of file +?> diff -ruN roundcubemail-cvs-20060413/skins/default/mail.css /var/www/roundcubemail-cvs-20060413/skins/default/mail.css --- roundcubemail-cvs-20060413/skins/default/mail.css 2006-04-04 23:41:22.000000000 +0200 +++ /var/www/roundcubemail-cvs-20060413/skins/default/mail.css 2006-07-27 12:47:01.000000000 +0200 @@ -439,6 +439,12 @@ background-color: #FFFFFF; } +#messagelist tr.junk +{ + /*font-style: oblique;*/ + background-color: #e0ffcc; +} + #messagelist tr.selected td { font-weight: bold; diff -ruN roundcubemail-rev282.orig/program/lib/imap.inc roundcubemail-rev282.junk/program/lib/imap.inc --- roundcubemail-rev282.orig/program/lib/imap.inc 2006-07-27 13:35:41.000000000 +0200 +++ roundcubemail-rev282.junk/program/lib/imap.inc 2006-07-27 13:41:56.000000000 +0200 @@ -1231,7 +1231,7 @@ /* FETCH date,from,subject headers */ $key="fh".($c++); - $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE)])\r\n"; + $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE X-SPAM-FLAG)])\r\n"; if (!fputs($fp, $request)) return false; do{ @@ -1280,6 +1280,7 @@ $result[$id]->from = $headers["from"]; $result[$id]->to = str_replace("\n", " ", $headers["to"]); $result[$id]->subject = str_replace("\n", "", $headers["subject"]); + $result[$id]->junk = array_key_exists("x-spam-flag", $headers) ? true : false; $result[$id]->replyto = str_replace("\n", " ", $headers["reply-to"]); $result[$id]->cc = str_replace("\n", " ", $headers["cc"]); $result[$id]->bcc = str_replace("\n", " ", $headers["bcc"]); diff -ruN roundcubemail-rev282.orig/program/steps/mail/func.inc roundcubemail-rev282.junk/program/steps/mail/func.inc --- roundcubemail-rev282.orig/program/steps/mail/func.inc 2006-07-27 13:35:45.000000000 +0200 +++ roundcubemail-rev282.junk/program/steps/mail/func.inc 2006-07-27 13:41:56.000000000 +0200 @@ -422,11 +422,12 @@ // set attachment icon if ($attrib['attachmenticon'] && preg_match("/multipart\/m/i", $header->ctype)) $attach_icon = $attrib['attachmenticon']; - - $out .= sprintf('<tr id="rcmrow%d" class="message%s%s %s">'."\n", + + $out .= sprintf('<tr id="rcmrow%d" class="message%s%s%s %s">'."\n", $header->uid, $header->seen ? '' : ' unread', $header->deleted ? ' deleted' : '', + $header->junk ? ' junk' : '', $zebra_class); $out .= sprintf("<td class=\"icon\">%s</td>\n", $message_icon ? sprintf($image_tag, $skin_path, $message_icon, '') : ''); diff -ruN roundcubemail-rev282.orig/skins/default/mail.css roundcubemail-rev282.junk/skins/default/mail.css --- roundcubemail-rev282.orig/skins/default/mail.css 2006-07-27 13:35:47.000000000 +0200 +++ roundcubemail-rev282.junk/skins/default/mail.css 2006-07-27 13:41:56.000000000 +0200 @@ -450,6 +450,12 @@ background-color: #FFFFFF; } +#messagelist tr.junk +{ + /*font-style: oblique;*/ + background-color: #e0ffcc; +} + #messagelist tr.selected td { font-weight: bold;

5 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev