Dev

dev@lists.roundcube.net

1 participants
4305 discussions

Re: Hierarchical folders (Rev 290)
by Chuck, Charlie and Charles 03 Aug '06

03 Aug '06

Brett Patterson wrote: > Actuallly, you could use lists, you just have to nest the next <ul> > element inside the previous <li> element. So the <ul> becomes a child > of the <li> > > Keep the same style, and the sub-<ul> element has the same widht and > height as the other folders. The only difference would be padding for > text and the icon ;) You pad the left so it "indents" the text and > display block the entire link and voila!! you have a row that highlights!! That's exactly as it was, and it wasn't working: <ul> <li id="inbox">inbox <ul> <li id="inbox.stuff">stuff</li> </ul> </li> </ul> In this (above) scenario, whenever you change the style of "inbox" you change the style of all of it's sublists. I changed it to: <ul> <li id="inbox">inbox</li> <ul> <li id="inbox.stuff">stuff</li> </ul> </ul> Which appeared to look and act as it was supposed to, but as Thomas correctly pointed out, it's not valid HTML, it just happens that the browsers support it anyway. Perhaps I don't understand what you're proposing. If that's the case, perhaps some sample HTML would help. -Charles PS. Obviously there are myriad solutions to this problem in HTML, but one that works without having to completely rewrite: http://trac.roundcube.net/trac.cgi/browser/trunk/roundcubemail/program/step… would be ideal.

1 0

Validation
by Brett Patterson 03 Aug '06

03 Aug '06

Since Charles "broke" the validation with his sub-folder highlighting stuff, I also noticed that in general, Roundcube won't validate because of the "search" type of input. XHTML 1.0 Transitional DTD: link <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_InputType> > <!ENTITY % InputType > "(text | password | checkbox | > radio | submit | reset | > file | hidden | image | button)" > > > >  > > <!ELEMENT input EMPTY>  > <!ATTLIST input <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_input> > %attrs; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_attrs> > %focus; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_focus> > type %InputType; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_InputType> "text" > name CDATA #IMPLIED > value CDATA #IMPLIED > checked (checked) #IMPLIED > disabled (disabled) #IMPLIED > readonly (readonly) #IMPLIED > size CDATA #IMPLIED > maxlength %Number; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_Number> #IMPLIED > src %URI; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_URI> #IMPLIED > alt CDATA #IMPLIED > usemap %URI; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_URI> #IMPLIED > onselect %Script; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_Script> #IMPLIED > onchange %Script; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_Script> #IMPLIED > accept %ContentTypes; <http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-strict.dtd_ContentTyp…> #IMPLIED > > So that won't validate since in XHTML 1.0, "search" isn't a valid input type :( Even the XHTML 1.1 spec doesn't have "search" as an input type: > <!ENTITY % input.attlist "INCLUDE" > > <![%input.attlist;[ > <!ENTITY % InputType.class > "( text | password | checkbox | radio | submit > | reset | file | hidden | image | button )" > > >  > <!ATTLIST %input.qname; > %Common.attrib; > type %InputType.class; 'text' > name CDATA #IMPLIED > value CDATA #IMPLIED > checked ( checked ) #IMPLIED > disabled ( disabled ) #IMPLIED > readonly ( readonly ) #IMPLIED > size %Number.datatype; #IMPLIED > maxlength %Number.datatype; #IMPLIED > src %URI.datatype; #IMPLIED > alt %Text.datatype; #IMPLIED > tabindex %Number.datatype; #IMPLIED > accesskey %Character.datatype; #IMPLIED > accept %ContentTypes.datatype; #IMPLIED > > I know Safari is supporting this, and with it the "results" attribute, but it won't validate. Not sure if you're working off of a different spec or not. Just thought I'd point it out ;) ~Brett

1 0

News from atmail?
by Michael Bueker 03 Aug '06

03 Aug '06

Hey, Over the last weeks, I've been anxious for news about the atmail offer and Thomas' decision about it. Is there anything new? mtu -- Linux is now being used by the US Military - brought to you by Private Network, Major Distribution, Colonel Panic and General Protection Fault.

1 0

Hierarchical folders (Rev 290)
by Thomas Bruederli 03 Aug '06

03 Aug '06

Hi Charles, I saw that you changed the list structure of the mailbox list. Now the HTML does not validate anymore because ULs cannot be nested directly within ULs. It seems to solve the highlighting problem but I'm not sure if all browsers will still display it correctly. I've tried it out with Firefox 1.5, Safari and Opera and could not detect any problems so far. If it works, we can turn a blind eye but actually I'm not very happy with this solution. Alternatively we could apply all styles to the a-tag instead of the li. Any thoughts? Regards, Thomas

2 1

Turkish Translation (with new labels)
by Hasan Cansız 01 Aug '06

01 Aug '06

New labels are translated. But i can't translate these labels. $labels['returnreceipt'] = 'Return receipt'; $labels['revertto'] = 'Revert to'; <a href=http://cansiz.info/rc/turkish_new.zip>http://cansiz.info/rc/turkish_new.zip</a> _____________________________________________________ Yahoo! kullaniyor musunuz? Simdi, 1GB e-posta saklama alani sunuyor http://tr.mail.yahoo.com

1 0

Return receipt checkbox/message overlaps Priority select box on Compose message
by Vahan Yerkanian 01 Aug '06

01 Aug '06

Greetings all, There is a minor visual bug with the "Return receipt" checkbox/message in Compose message screen, overlaping the Priority select box (f.e. in Armenian version) when the contents of the select box are long enough. Best regards, Vahan

1 0

svn 284
by Brett Patterson 31 Jul '06

31 Jul '06

Hey Thomas and Charles, perhaps one of you could look into the sorting issue with the latest SVN. Just got it to play with the highlighting, and noticed some things wrong: 1.) Sorting by anything doesn't work. 2.) Highlighting is good but there is an issue: -- Firefox (WIndows) won't switch between "active" and "inactive" for me Other than that, great work. Can't wait for the next beta!! ~Brett Patterson www.roundcubeforum.net Roundcube Forum Admin

4 4

folders patch
by Charles McNulty 31 Jul '06

31 Jul '06

Here's a pretty simple patch for doing the drag over a folder thing. The other thing it does is keeps track of whether the "folder" portion of the screen or the "mail" portion of the screen has the "focus" and changes the color accordingly. For example if you've clicked on the Inbox folder, the folder will be colored red. If you then select a message, the Inbox folder will now be highlighted in grey and the message you've selected will be red. If you click back on to the Inbox folder, the message you've selected will turn grey and "Inbox" will turn back red. If you go back to the message list, select a message and drag it over the folder list, the folder's will turn red as your mouse hovers over them. I've tested this a little, but of course it could always use more testing. Please let me know your thoughts on this patch. -Charles Index: program/js/app.js =================================================================== --- program/js/app.js (revision 274) +++ program/js/app.js (working copy) @@ -244,7 +244,6 @@ // load body click event document.onmousedown = function(){ return rcube_webmail_client.reset_click(); }; document.onkeydown = function(e){ return rcube_webmail_client.key_pressed(e, msg_list_frame); }; - // flag object as complete this.loaded = true; @@ -285,6 +284,14 @@ } } + if (this.gui_objects.mailboxlist) { + var s_mbox = String(this.env.mailbox).toLowerCase().replace(this.mbox_expression, ''); + var mbox_li = document.getElementById('rcmbx'+s_mbox); + + if (mbox_li) + this.set_classname(mbox_li, 'unfocused', true); + } + this.in_message_list = true; e.cancelBubble = true; }; @@ -1161,9 +1168,10 @@ // onmouseup handler for mailboxlist item this.mbox_mouse_up = function(mbox) { - if (this.drag_active) + if (this.drag_active){ + this.unfocus_mailbox(mbox); this.command('moveto', mbox); - else + } else this.command('list', mbox); return false; @@ -1529,8 +1537,7 @@ if (this.env.search_request) add_url += '&_search='+this.env.search_request; - if (this.env.mailbox!=mbox) - this.select_mailbox(mbox); + this.select_mailbox(mbox); // load message list remotely if (this.gui_objects.messagelist) @@ -1634,7 +1641,26 @@ return true; }; - + this.focus_mailbox = function(mbox) { + if (this.gui_objects.mailboxlist && this.drag_active) { + var s_mbox = String(mbox).toLowerCase().replace(this.mbox_expression, ''); + var mbox_li = document.getElementById('rcmbx'+s_mbox); + + if (mbox_li) + this.set_classname(mbox_li, 'selected', true); + } + } + + this.unfocus_mailbox = function(mbox) { + if (this.gui_objects.mailboxlist && this.drag_active) { + var s_mbox = String(mbox).toLowerCase().replace(this.mbox_expression, ''); + var mbox_li = document.getElementById('rcmbx'+s_mbox); + + if (mbox_li) + this.set_classname(mbox_li, 'selected', false); + } + } + // move selected messages to the specified mailbox this.move_messages = function(mbox) { @@ -2199,7 +2225,6 @@ highlight.removeAttribute('id'); //highlight.removeAttribute('class'); this.set_classname(highlight, 'selected', false); - this.set_classname(highlight, 'unfocused', false); } if (next) @@ -2990,7 +3015,7 @@ // mark a mailbox as selected and set environment variable this.select_mailbox = function(mbox) { - if (this.gui_objects.mailboxlist) + if (this.gui_objects.mailboxlist ) { var item, reg, text_obj; var s_current = this.env.mailbox.toLowerCase().replace(this.mbox_expression, ''); @@ -3003,8 +3028,10 @@ if (current_li) { this.set_classname(current_li, 'selected', false); this.set_classname(current_li, 'unfocused', false); - } - if (mbox_li) + } + + if (mbox_li || this.env.mailbox == mbox) + this.set_classname(mbox_li, 'unfocused', false); this.set_classname(mbox_li, 'selected', true); } Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 274) +++ program/steps/mail/func.inc (working copy) @@ -216,6 +216,8 @@ $out .= sprintf('<li id="rcmbx%s" class="mailbox %s %s%s%s"><a href="%s&_mbox=%s"'. ' onclick="return %s.command(\'list\',\'%s\')"'. + ' onmouseover="return %s.focus_mailbox(\'%s\')"' . + ' onmouseout="return %s.unfocus_mailbox(\'%s\')"' . ' onmouseup="return %s.mbox_mouse_up(\'%s\')"%s>%s</a>', $folder_css, $class_name, @@ -227,7 +229,12 @@ $JS_OBJECT_NAME, addslashes($folder['id']), $JS_OBJECT_NAME, + addslashes($folder['id']), + $JS_OBJECT_NAME, + addslashes($folder['id']), + $JS_OBJECT_NAME, addslashes($folder['id']), + $title, rep_specialchars_output($foldername, 'html', 'all')); Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 274) +++ skins/default/mail.css (working copy) @@ -266,7 +266,7 @@ #mailboxlist li.selected { - background-color: #929292; + background-color: #CC3333; border-bottom: 1px solid #898989; } @@ -276,7 +276,18 @@ font-weight: bold; } +#mailboxlist li.unfocused +{ + background-color: #929292; + border-bottom: 1px solid #898989; +} +#mailboxlist li.unfocused a +{ + color: #FFF; + font-weight: bold; +} + /* styles for nested folders */ #mailboxlist ul { list-style: none;

3 4

Segfaults after the 'Cannot modify header...' error
by phil 31 Jul '06

31 Jul '06

As a followup, I'm now seeing some regular segfaulting of Apache after some of the 'Cannot modify header information - headers already sent in Unknown on line 0" error that I keep getting in /var/log/httpd-error.log: [Mon Jun 26 13:10:34 2006] [error] [client 70.246.222.74] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Mon Jun 26 13:10:34 2006] [error] [client 70.246.222.74] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Mon Jul 31 13:10:34 2006] [notice] child pid 75525 exit signal Segmentation fault (11) [Thu Jun 15 13:24:45 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Thu Jun 15 13:24:45 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 [Mon Jul 31 13:24:45 2006] [notice] child pid 75657 exit signal Segmentation fault (11) This is on Apache 2.0.58 with php5-5.1.4 - FreeBSD 6.0 P -- http://fak3r.com - you don't have to kick it -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

1 0

fixed bag in roundcube webmail
by Alexander A. Boykov 31 Jul '06

31 Jul '06

hello. maybe it's not bug, but in my system when i create first mailbox and login in webmail - there are no folders Sent and Trash. i read source code and make change: *** rcube_imap.inc.bak 2006-07-31 19:29:27.000000000 +0400 --- rcube_imap.inc 2006-07-31 19:28:21.000000000 +0400 *************** *** 364,370 **** --- 364,374 ---- if (!in_array_nocase('INBOX', $a_folders)) { $this->create_mailbox('INBOX', TRUE); + $this->create_mailbox('Sent', TRUE); + $this->create_mailbox('Trash', TRUE); array_unshift($a_folders, 'INBOX'); + array_unshift($a_folders, 'Sent'); + array_unshift($a_folders, 'Trash'); } $a_mailbox_cache = array(); now mailboxes creatres succesfully. thanks. -- С уважением, Бойков Александр Системный администратор HighLink a.boykov(a)sweb.ru

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev