Dev

dev@lists.roundcube.net

1 participants
4289 discussions

code bug ?
by Sébastien BLAISOT 08 Dec '13

08 Dec '13

Hi everybody, since RC 0.9b, there is a bug in my automatic_addressbook plugin when editing a contact with th move_to config option set to 1 This means that when editing a contact in the collected_abook, it is saved in the default abook and removed from its original collected_abook (calling $CONTACTS->insert and setting abort to true and result to the new cid) the log is showing : [07-Dec-2013 14:18:16 Europe/Paris] PHP Fatal error: Cannot use object of type rcube_result_set as array in /var/www/vhosts/ssl_common/webmail/test/rc09b/program/steps/addressbook/save.inc on line 134 this seams to come from the following lines of code in program/steps/addressbook/save : $record = $CONTACTS->get_record($newcid ? $newcid : $cid, true); $record['email'] = reset($CONTACTS->get_col_values('email', $record, true)); it seems to me that get_record return in general a record, but can return in some circonstances a rcube_result_set object and the next line of code can't handle this (array assignation on a rcube_result_set object). Can somebody confirme this ? What are the condition for get_record to return an rcube_result_set with only 1 object in it ? I don't already understand very well what happens but I can make additionnal tests to help debug this. If you can confirme this seems to be a bug, I'll file a bug report. regards, sebastien

2 4

Re: [RCD] [Svn] [roundcube/roundcubemail] ac3cdd: Skip charset (or use US_ASCII) intead of UTF-8 if ...
by Michael Heydekamp 02 Dec '13

02 Dec '13

Am 25.11.2013 15:54, schrieb GitHub: > Log Message: > ----------- > Skip charset (or use US_ASCII) intead of UTF-8 if body contains only ASCII characters Yoohoo! :) This is the first test. Any hope that this logic will be extended to ISO-8859-1/15 (and probably Windows-1252) in the future? Thanks and cheers, -- Michael Heydekamp Co-Admin freexp.de Duesseldorf/Germany

2 2

Roundcube version 1.0-beta available for download
by Thomas Bruederli 01 Dec '13

01 Dec '13

Hello folks We’re proud to announce that the long awaited version 1.0 of Roundcube webmail is now available as beta release for download and testing. With this milestone we introduce some important changes to the configuration as well as some nice new features: Cleaned up the configuration into a single file Importing email messages and contact group assignments Advanced LDAP address book functionality A toggle to switch between HTML and plaintext view Save drafts in local storage for recovery Canned responses to save and recall boilerplate texts Improved keyboard navigation in messages list Attachment reminder plugin And of course plenty of small improvements and bug fixes. See the complete Changelog at http://trac.roundcube.net/wiki/Changelog and download the new packages from http://roundcube.net/download. WARNING: the old configuration files named main.inc.php and db.inc.php are now deprecated and should be replaced with one single config.inc.php file. Run the ./bin/update.sh script to get this conversion done or manually merge the files. NOTE: the new config.inc.php should only contain options that differ from the ones listed in defaults.inc.php. Please note that this is a beta release and we recommend to test it on a separate environment. Have fun! Thomas

2 1

Larry: Improved #message element behavior/location
by Thomas Bruederli 24 Nov '13

24 Nov '13

Hello devs and list lurkers One of the remaining big tasks we have scheduled for Roundcube 1.0 is the re-location of the status messages: http://trac.roundcube.net/ticket/1488974 Many people complained that the location at the bottom of the screen is somewhat out of the user's sight and the messages itself are not visible enough. Please find attached a suggestion to refactor the status messages into stacked popups but still located at the bottom of the window. What do thou think? Kind regards, Thomas

7 30

Problems with sending messages IE8/1.0-git (Javascript error)
by Michael Heydekamp 24 Nov '13

24 Nov '13

Two problems I just realized in IE8 when I want to send a message with IE8/1.0-git in a separate window: 1) A few seconds after the window has been opened the following error message appears in the lower left corner of the status bar: ----------------------------------------------------------------------- > Meldung: Das Objekt unterstützt diese Eigenschaft oder Methode nicht. > Zeile: 3712 > Zeichen: 9 > Code: 0 > URI: http://***.de/program/js/app.js?s=1384978220 ----------------------------------------------------------------------- The result aifter clicking the send button is that the message IS being sent, but the window stays on the screen and Roundcube "thinks" that it has NOT been sent. 2) Clicking on the Cancel button and on the OK button in the consecutive message box does NOT cancel the message - the window stays on the screen in this scenario as well. Not sure yet if it makes a difference when sending a message in the same window... Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 4

Re: [RCD] [Svn] [roundcube/roundcubemail] f8101f: Accept text/html parts inside multipart/mixed parts as HTML contents
by Michael Heydekamp 17 Nov '13

17 Nov '13

Thanks for this fix - works for me! Nonetheless there is still another issue with such kind of messages: In the message list, attachments are not indicated (the 'paper clip' icon is missing). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 15.11.2013 18:58, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: f8101fff1ec4a52bde553e77a120fd8618c025aa > > https://github.com/roundcube/roundcubemail/commit/f8101fff1ec4a52bde553e77a… > Author: Thomas Bruederli <thomas(a)roundcube.net> > Date: 2013-11-15 (Fri, 15 Nov 2013) > > Changed paths: > M program/lib/Roundcube/rcube_message.php > > Log Message: > ----------- > Accept text/html parts inside multipart/mixed parts as HTML contents > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 2

Hooks 'message_compose' and 'message_compose_body'
by Rosali 14 Nov '13

14 Nov '13

In current 1.0-git (master) and in 0.9.5 I see that $isHTML is set to false if we pre-define body content by hooks 'message_compose' and/or 'message_compose_body' regardless whether or not user preference is 'HTML': ./program/steps/mail/compose.inc ::: lines 643 ff. else if ($COMPOSE['param']['body']) { $body = $COMPOSE['param']['body']; $isHtml = false; } Is there a special reason for this behavior? I guess it is a bug. At least it prevents me to pre-define HTML compose bodies. If there is a special reason for this fallback to text bodies then please note that the HTML Editor select box is set accordingly; it is set accordingly to user's preference. I have already contacted Alec and he replied: "$COMPOSE['param']s in general are for text only, because they are URL parameters. If you want to inject any body use message_compose_body hook. Feel free to propose fix/better solution via pull request." I think Alec is not right. $COMPOSE['param'] is also set by the hook 'message_compose'. See ./program/steps/mail/compose.inc ::: lines 450 ff. // pipe compose parameters thru plugins $plugin = $RCMAIL->plugins->exec_hook('message_compose', $COMPOSE); $COMPOSE['param'] = array_merge($COMPOSE['param'], $plugin['param']); So, the simple solution to allow plugin developers to pre-define HTML bodies is: ./program/steps/mail/compose.inc ::: lines 643 ff. else if ($COMPOSE['param']['body']) { $body = $COMPOSE['param']['body']; $isHtml = $COMPOSE['param']['html'] ? true : false; }

2 1

saving drafts to localstorage
by Charles McNulty 10 Nov '13

10 Nov '13

Is this feature request to store drafts in localstorage defined in any detail anywhere? Is it partially implemented anywhere, or part of a plugin? I looked and couldn't find anything other than a couple of messages in the dev archives. My main question is whether we're going to save the drafts as unencrypted data? Is this something that people are comfortable with? Especially given that we would not store this as session-only data (because we presumably would want to restore data from an interrupted session), it seems like storing it as unencrypted might represent problems (at least for some more sensitive e-mails). The obvious solution would be for the server to store a private key and to send a public key to javascript for encrypting localstorage. That raises issues of where to store the private key, and how/when to generate it. It also starts to overlap with Alec's GPG plugin. Would we want to use the same GPG key that we use for sending encrypted messages (essentially sending them to ourselves), or would this be a completely separate key just for localstorage that we could potentially generate at setup and just store along with the userdata in the database. If I can get some answers to these questions, I'd love to start developing this. -Charles

3 3

Re: [RCD] [Svn] [roundcube/roundcubemail] b972b4: Add an option to disable smart Reply-List behaviour - reply_all_mode (#1488734)
by Michael Heydekamp 08 Nov '13

08 Nov '13

I think these options under "Default action of [Reply all] button" in context with the commit message "Add an option to disable smart Reply-List behaviour"... - reply to all - reply to mailing list only (if found) ...require either some explanation or different phrasing. The latter option sounds to me as if any reply-all action would be disabled when replying to a non-list message. But I dare to believe that this isn't true, right? (Untested) Furhermore, the Reply-All button has two options anway. To which of these two options does this change apply? Or is it just a toggle which of these two options of the button will be taken by default when just clicking on the button without explicitely selecting one of those options? If so, then it's even more confusing. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 30.10.2013 12:04, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: b972b4c4c079898250912588d1eb1d8907dfe868 > > https://github.com/roundcube/roundcubemail/commit/b972b4c4c079898250912588d… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-10-30 (Wed, 30 Oct 2013) > > Changed paths: > M CHANGELOG > M config/defaults.inc.php > M program/js/app.js > M program/localization/en_US/labels.inc > M program/steps/mail/func.inc > M program/steps/settings/func.inc > M program/steps/settings/save_prefs.inc > M skins/classic/functions.js > M skins/larry/ui.js > > Log Message: > ----------- > Add an option to disable smart Reply-List behaviour - reply_all_mode (#1488734) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 1

Re: [RCD] [Svn] [roundcube/roundcubemail] 0f4c9b: check if the new password matched the requirements
by Michael Heydekamp 08 Nov '13

08 Nov '13

Just wanted to confirm that the commit below appears to work (see screenshot attached). :) Just one thing: Is there any way to keep those AJAX messages (or however they are called) on the screen until they have been "clicked away" (or confirmed with the Enter key) by the user? Especially in this case that would make most sense as it takes some time to read (and understand) the message, but it does appear on the screen for just 7 seconds or so. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 04.11.2013 17:53, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 0f4c9b850f665f0fdafb00809b4b9f100c59f331 > > https://github.com/roundcube/roundcubemail/commit/0f4c9b850f665f0fdafb00809… > Author: Till Krüss <me(a)tillkruess.com> > Date: 2013-10-15 (Tue, 15 Oct 2013) > > Changed paths: > M plugins/password/drivers/domainfactory.php > > Log Message: > ----------- > check if the new password matched the requirements; code cleanup > > > Commit: 910a3581be47da1d19eb15a68ea6b51c2c31ef67 > > https://github.com/roundcube/roundcubemail/commit/910a3581be47da1d19eb15a68… > Author: Till Krüss <me(a)tillkruess.com> > Date: 2013-10-15 (Tue, 15 Oct 2013) > > Changed paths: > M plugins/password/drivers/domainfactory.php > > Log Message: > ----------- > check if password was changed successfully, before looking for error messages > > > Commit: d4f27d90d57b62a833e643fa9e823d4a8aaa1dcf > > https://github.com/roundcube/roundcubemail/commit/d4f27d90d57b62a833e643fa9… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-11-04 (Mon, 04 Nov 2013) > > Changed paths: > M plugins/password/drivers/domainfactory.php > > Log Message: > ----------- > Merge pull request #136 from tillkruess/extend-df-password-driver > > Extend domainfactory password driver > > > Compare: > https://github.com/roundcube/roundcubemail/compare/a8b004e8d8f0...d4f27d90d… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev