Dev

dev@lists.roundcube.net

1 participants
4289 discussions

Re: [RCD] [RCU] roundcube 0.9.3 - Invalid request. no data saved
by Reindl Harald 29 Oct '13

29 Oct '13

Am 29.10.2013 14:53, schrieb Igor Zinovik: > My roundcube does not allow me to login into my mailbox. It just writes: > " invalid request no data was saved " > > I enabled all logging settings in main.inc.php > $rcmail_config['smtp_log'] = true; > $rcmail_config['log_logins'] = true; > $rcmail_config['log_session'] = true; > $rcmail_config['sql_debug'] = true; > $rcmail_config['imap_debug'] = true; > > My Apache is able to successfully save sessions to /var/lib/php5/ that's nice but roundcube still insists to not use the php session-handler otherwise i would no longer need to carry the patch from months ago in the RPM-SPEC Patch2: roundcubemail_native_session_handler.patch [builduser@buildserver:/rpmbuild/SPECS]$ cat ../SOURCES/roundcubemail_native_session_handler.patch diff --git a/config/main.inc.php.dist b/config/main.inc.php.dist index 4a73ff1..58332cb 100644 --- a/config/main.inc.php.dist +++ b/config/main.inc.php.dist @@ -254,9 +254,10 @@ $rcmail_config['session_name'] = null; // Session path. Defaults to PHP session.cookie_path setting. $rcmail_config['session_path'] = null; -// Backend to use for session storage. Can either be 'db' (default) or 'memcache' -// If set to memcache, a list of servers need to be specified in 'memcache_hosts' +// Backend to use for session storage. Can either be 'db' (default), 'memcache' or 'php' +// If set to 'memcache', a list of servers need to be specified in 'memcache_hosts' // Make sure the Memcache extension (http://pecl.php.net/package/memcache) version >= 2.0.0 is installed +// Setting this value to 'php' will use the default session save handler configured in PHP $rcmail_config['session_storage'] = 'db'; // Use these hosts for accessing memcached diff --git a/program/include/rcmail.php b/program/include/rcmail.php index 89f2f96..a7ddb1e 100644 --- a/program/include/rcmail.php +++ b/program/include/rcmail.php @@ -746,7 +746,7 @@ class rcmail extends rcube // before closing the database connection, write session data if ($_SERVER['REMOTE_ADDR'] && is_object($this->session)) { - session_write_close(); + $this->session->write_close(); } // write performance stats to logs/console diff --git a/program/lib/Roundcube/rcube.php b/program/lib/Roundcube/rcube.php index 4471ace..4e3f8fc 100644 --- a/program/lib/Roundcube/rcube.php +++ b/program/lib/Roundcube/rcube.php @@ -457,7 +457,6 @@ class rcube ini_set('session.name', $sess_name ? $sess_name : 'roundcube_sessid'); ini_set('session.use_cookies', 1); ini_set('session.use_only_cookies', 1); - ini_set('session.serialize_handler', 'php'); ini_set('session.cookie_httponly', 1); // use database for storing session data @@ -471,7 +470,7 @@ class rcube // start PHP session (if not in CLI mode) if ($_SERVER['REMOTE_ADDR']) { - session_start(); + $this->session->start(); } } diff --git a/program/lib/Roundcube/rcube_session.php b/program/lib/Roundcube/rcube_session.php index dedde22..4e06827 100644 --- a/program/lib/Roundcube/rcube_session.php +++ b/program/lib/Roundcube/rcube_session.php @@ -42,6 +42,7 @@ class rcube_session private $secret = ''; private $ip_check = false; private $logging = false; + private $storage; private $memcache; @@ -59,11 +60,14 @@ class rcube_session $this->set_lifetime($lifetime); // use memcache backend - if ($config->get('session_storage', 'db') == 'memcache') { + $this->storage = $config->get('session_storage', 'db'); + if ($this->storage == 'memcache') { $this->memcache = rcube::get_instance()->get_memcache(); // set custom functions for PHP session management if memcache is available if ($this->memcache) { + ini_set('session.serialize_handler', 'php'); + session_set_save_handler( array($this, 'open'), array($this, 'close'), @@ -79,7 +83,9 @@ class rcube_session true, true); } } - else { + else if ($this->storage != 'php') { + ini_set('session.serialize_handler', 'php'); + // set custom functions for PHP session management session_set_save_handler( array($this, 'open'), @@ -92,6 +98,22 @@ class rcube_session } + /** + * Wrapper for session_start() + */ + public function start() + { + session_start(); + + // copy some session properties to object vars + if ($this->storage == 'php') { + $this->key = session_id(); + $this->ip = $_SESSION['__IP']; + $this->changed = $_SESSION['__MTIME']; + } + } + + public function open($save_path, $session_name) { return true; @@ -116,6 +138,20 @@ class rcube_session /** + * Wrapper for session_write_close() + */ + public function write_close() + { + if ($this->storage == 'php') { + $_SESSION['__IP'] = $this->ip; + $_SESSION['__MTIME'] = time(); + } + + session_write_close(); + } + + + /** * Read session data from database * * @param string Session ID

1 0

Post hooks for DB operations
by Gus 29 Oct '13

29 Oct '13

Hi all, I'm currently writing a plugin that needs to act after an identity has been inserted into database. There is an identity_create hook that is called before the identity is inserted. How about adding a hook (whose argument would be data for the newly created identity, including the identity_id), that would be called after the database record has been created? That way you could write a plugin that could, e.g. 1. use identity_create to start a DB transaction and possibly modify identity data 2. use the new identity_stored (or something similar) hook to write it's own record into its own database table (with a constraint referencing the new identity) and commit the transaction (or rollback if something went wrong) Similar to those, I would also propose post-insert/update hooks for other events that could prove useful, so: identity_stored ( $record ) for after an identity was stored (created or updated) user_created ( $record ) for after a new user has been created contact_stored ( $record ) for after a contact has been stored (created or updated) group_stored ( $record ) for after a group has been stored (created, updated, renamed, members added, members deleted) preferences_stored ( $record ) for after user's preferences have been saved Is this acceptable? It's not too complicated to add those and I'd be willing to contribute the code and document the changes on the wiki. If not, I'd appreciate if you could clue me into how I might be able to write a plugin that needs to do something similar as described above (i.e. create records in additional tables that keep referential integrity with records in Roundcube's own tables). Regards, Tin

1 0

feedback regarding larry
by Cor Bosman 24 Oct '13

24 Oct '13

Hey all, ive been getting some feedback regarding the larry theme. Most of it i can handle myself, but one specifically keeps coming back. People dont realise that this button does anything, and miss all the feature that are accessed through it: http://grab.by/rkkc It's in a bit of a strange place. You click on the left, but it opens something underneath. It doesnt really look very clear what it's supposed to do. I would actually prefer to start it out in open, and let people figure out how to close it, that would sure save us a lot of support calls. Would be even better if it could be more intuitive about that it's supposed to do. Cor

5 8

roundcube webmail
by Joaquin Moyares Rojas 24 Oct '13

24 Oct '13

2 1

Text search - timeouts and other issues
by Michael Heydekamp 22 Oct '13

22 Oct '13

My INBOX has > 10,000 messages. When doing a text search in the body across those messages, I'm ALWAYS getting a timeout the first time. Sometimes also when doing it a second time. But when doing it at least the third time (but sometimes at the second attempt already), I get a result within a few seconds. Is there anything we can do server-side which can improve this? IMAP server is Cyrus. Furthermore, how does the text search work at all in detail? If I enter for instance "term1 term2" (without the quotation marks), does RC look for "term1" OR "term2", or does it look for "term1" AND "term2"? And if the latter, does it look for "term1 term2" as an exact phrase, or does it look separately for "term1" AND "term2" anywhere in the body? And do quotation marks have a meaning at all? Our users are asking us this, and currently we don't have a good answer for them. Last but not least: Will there be a header only search available in the near future? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 3

Security updates 0.9.5 and 0.8.7
by Thomas Bruederli 21 Oct '13

21 Oct '13

Dear Roundcube users We just published new releases which fix a recently reported vulnerability that allows an attacker to overwrite configuration settings using user preferences. This can result in random file access, manipulated SQL queries and even code execution. The latter one only affects versions 0.8.6 and older. Beside the security fix, the 0.9.5 release also includes other minor bug fixes and improvements. Most notably it brings the default spell checker back after Google suspended their public spell checking service. Please update your installations with the new versions or patch them with the fixes listed below for the various older versions of Roundcube. Download the new versions from http://roundcube.net/download Patch for 0.9.x: https://github.com/roundcube/roundcubemail/commit/4109bb26ce.diff Patch for 0.8.x: https://github.com/roundcube/roundcubemail/commit/eb433aa33c.diff Patch for 0.7.x: https://github.com/roundcube/roundcubemail/commit/1972037274.diff More information about the vulnerability will be published under CVE-2013-6172. Kind regards, Thomas

1 0

identity_select hook for 0.9.4
by Michael Heydekamp 17 Oct '13

17 Oct '13

Hi Alec, would it be a big deal to make the identity_select hook available for 0.9.4, too? Looking at the commit and as the plugin itself does exist already, this would be only 5 lines of new/changed code. I could try to do this myself, but we would then run into possible merge conflicts at our daily git-pull. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 3

Reply-To header in SVN list messages
by Michael Heydekamp 16 Oct '13

16 Oct '13

Currently the messages in the SVN list have these addresses in the Reply-To header: ------------------------------------------------------ > svn(a)lists.roundcube.net, GitHub <noreply(a)github.com> ------------------------------------------------------ To have a "noreply" address in the Reply-To does not make any sense by definition. And any reply to svn(a)lists.roundcube.net will never make it to this R/O list anyway. So wouldn't it be better to set the Reply-To to the dev-list...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

Re: [RCD] [Svn] [roundcube/roundcubemail] acbf6e: Fix address matching in Return-Path header on identity selection (#1489374)
by Michael Heydekamp 16 Oct '13

16 Oct '13

Confirmed, thanks! -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 15.10.2013 18:53, schrieb GitHub: > Branch: refs/heads/release-0.9 > Home: https://github.com/roundcube/roundcubemail > Commit: acbf6eede613a5496cabccbdbfcb2f4e2cbd60d2 > > https://github.com/roundcube/roundcubemail/commit/acbf6eede613a5496cabccbdb… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-10-15 (Tue, 15 Oct 2013) > > Changed paths: > M CHANGELOG > M program/steps/mail/func.inc > M tests/MailFunc.php > > Log Message: > ----------- > Fix address matching in Return-Path header on identity selection (#1489374) > > Conflicts: > > CHANGELOG > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Identity selection broken? (was: [Svn] [roundcube/roundcubemail] acbf6e: Fix address matching in Return-Path header on identity selection (#1489374))
by Michael Heydekamp 16 Oct '13

16 Oct '13

Identity selection appears to be completely broken (I assume due to the commit below). The default identity is being selected always, but even that doesn't work correctly: The signature is not being loaded into the editor. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 15.10.2013 18:53, schrieb GitHub: > Branch: refs/heads/release-0.9 > Home: https://github.com/roundcube/roundcubemail > Commit: acbf6eede613a5496cabccbdbfcb2f4e2cbd60d2 > > https://github.com/roundcube/roundcubemail/commit/acbf6eede613a5496cabccbdb… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-10-15 (Tue, 15 Oct 2013) > > Changed paths: > M CHANGELOG > M program/steps/mail/func.inc > M tests/MailFunc.php > > Log Message: > ----------- > Fix address matching in Return-Path header on identity selection (#1489374) > > Conflicts: > > CHANGELOG > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

4 12

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev