Dev

dev@lists.roundcube.net

1 participants
4289 discussions

Codebase cleanup, PSR-1/2 compliance - and before you say no, I'm offering to do the work
by David Deutsch 24 Sep '13

24 Sep '13

Hey everybody, I'm David and I would like to help out. Starting on any project, it's usually best to get familiar with the codebase. Now - I really enjoy combing through and cleaning up codebases and that's usually a great way to do just that. To give an example, I've recently done this to RedBeanPHP, you can check out the details here: Discussion: https://groups.google.com/forum/#!topic/redbeanorm/S8EnZTIZPDE Repository: https://github.com/gabordemooij/redbean Pull Requests: https://github.com/gabordemooij/redbean/pull/281 https://github.com/gabordemooij/redbean/pull/282 https://github.com/gabordemooij/redbean/pull/289 So - in a nutshell, that's what I'm offering to do for Roundcube. Examples, picked at random: /plugins/archive/archive.php Original: https://github.com/roundcube/roundcubemail/blob/master/plugins/archive/arch… Cleanup: https://gist.github.com/daviddeutsch/6285028 /installer/rcube_install.php Original: https://github.com/roundcube/roundcubemail/blob/master/installer/rcube_inst… Cleanup: https://gist.github.com/daviddeutsch/6285286 /program/lib/Roundcube/rcube_vcard.php Original: https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcub… Cleanup: https://gist.github.com/daviddeutsch/6285504 All as one commit: https://github.com/daviddeutsch/roundcubemail/commit/568051120f98070b554bc0… I like code concise and self explanatory. I think if there are more than three indents (within a function), you can usually simplify the code and make it easier to understand while you're at it. I actually, weirdly, enjoy a 80 character line limit and while I usually prefer tabs (I disagree with PSR-2 on that), I'm fine coding with 4 spaces for indentation. I'd be happy to accommodate to special customs, of course, although I do think that sticking to PSR - flawed as it may be in spots - really helps enable collaboration by convention. Let me know if this sounds like something that would at all be welcome in this project. best regards, David Deutsch

15 97

paul sosthenes kilyabum invited you to check out Dropbox
by paul sosthenes kilyabum via Dropbox 12 Sep '13

12 Sep '13

Hi there, paul sosthenes kilyabum wants you to try Dropbox! Dropbox lets you bring all your photos, docs and videos with you anywhere and share them easily. Get started here. https://www.dropbox.com/l/BakwN2fMi46Cpb9uIntsUE1?text=1 Thanks! - The Dropbox Team ____________________________________________________ To stop receiving invites from Dropbox, please go to https://www.dropbox.com/l/IruWjsdi6oqMIc9x7k3BWD1?text=1 Dropbox, Inc., PO Box 77767, San Francisco, CA 94107

1 0

Session Class Questions
by Rodrigo Castillo 12 Sep '13

12 Sep '13

I'm exploring the rcmail_session class to hunt down some intermittent issues with untimely session expiration, and to develop a better remember_me extension (or attempt to get it into core...). I came across the following code ... /** * Setter for session lifetime */ public function set_lifetime($lifetime) { $this->lifetime = max(120, $lifetime); // valid time range is now - 1/2 lifetime to now + 1/2 lifetime $now = time(); $this->now = $now - ($now % ($this->lifetime / 2)); } ... /** * Create session cookie from session data * * @param int Time slot to use */ function _mkcookie($timeslot) { $auth_string = "$this->key,$this->secret,$timeslot"; return "S" . (function_exists('sha1') ? sha1($auth_string) : md5($auth_string)); } ... /** * Check session authentication cookie * * @return boolean True if valid, False if not */ function check_auth() { ... if ($result && $this->_mkcookie($this->now) != $this->cookie) { ... } It's quite deliberate, and it made me curious as to the reasoning behind the decision not to simply include a 'created_at' and 'expires_at' within the cookie, which would simplify the validation of the timespan. Is the reason for security, or perhaps a load-balancing?

3 3

Quotas not updating
by Bruce Markey 11 Sep '13

11 Sep '13

Sorry if this isn't the place to ask this.. I'm having one little issue and I'm hoping it's just something I'm doing wrong. Running postfix/dovecot/vimbadmin. Quotas work just fine. They display fine. Except when I went to change some users storage space this is not reflected in roundcube. Space was changed in vimbadmin, its reflected in the mysql table so all is well there. When I hover over the bar in roundcube it shows the previous amount. Is this a cache thing or does it pull that amount every time I log in. Thank you. Bruce Markey -- Please use PGP, ENCRYPT everything. For information about acquiring a secryption.com account, email me. My public key: https://www.secryption.com/BruceMarkey.asc or https://keyserver.pgp.com

3 3

Update 0.9.4 release
by Thomas Bruederli 09 Sep '13

09 Sep '13

Dear Roundcube lovers! It wouldn't be Roundcube if there wasn't a minor glitch in our stable releases every now and then :-) It so happened again in the recent 0.9.3 release where the new include_path check triggered some regex warnings on Windows systems. We apologize for this inconvenience! But we're trying hard to keep up and here's a new release which fixes that nasty bug together with some other reported issues that we considered worth being ported to the 0.9 release series. It's considered stable (really!) and we recommend to update all productive installations of Roundcube with this version. Download it from http://roundcube.net/download, see the full changelog in our wiki: http://trac.roundcube.net/wiki/Changelog Kind regards, Thomas

4 3

Roundcube 1.0-git and PHP Version 5.5.3
by Aleksandar Lazic 04 Sep '13

04 Sep '13

Hi. Today I have moved my php-system to 5.5.3 I just wanted to communicate that the Roundcube 1.0-git works until now without any issues. Best regards Aleks

2 2

PGP Plugin
by Scott Kramer List 03 Sep '13

03 Sep '13

Hi, Is there any sort of PGP plugin avail? Thanks! Scott

2 1

Larry: improved attachment preview page?
by A.L.E.C 01 Sep '13

01 Sep '13

While I work on a new plugin for files management. I found that we could improve our current attachment preview page. I'm attaching a screenshot from my plugin. I'd like to make attachment preview page to look the same, i.e. attachment properties on the left and toolbar with buttons (Download for now, but we could add other e.g. Print, Save, Edit). What do you think? An opposite layout would be to make it more looking as message preview page with properties on top and small buttons in right-top corner (and no toolbar). I however, prefer the solution with toolbar. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 4

Address book display bug when email type is "main" [0.9.2]
by Rob Sheldon 30 Aug '13

30 Aug '13

One of my customers did an Outlook export / Roundcube import of his contacts, and none of the contacts were displaying their email address in the address book's vcard section. In the database, all of his contacts had been saved with, "EMAIL;TYPE=INTERNET;TYPE=MAIN:address@host.com". My contacts for example are, "EMAIL;TYPE=INTERNET;TYPE=OTHER:address@host.com". Changing TYPE=OTHER to TYPE=MAIN in one of my contacts caused that one to also not display correctly. I traced this back to program/steps/addressbook/func.inc: 29c29 < 'email' => array('type' => 'text', 'size' => 40, 'maxlength' => 254, 'label' => rcube_label('email'), 'subtypes' => array('home','work','other'), 'category' => 'main'), --- > 'email' => array('type' => 'text', 'size' => 40, 'maxlength' > => 254, 'label' => rcube_label('email'), 'subtypes' => > array('home','work','other','main'), 'category' => 'main'), ...but I'm not sure if this is generally desired behavior or not, so I'm posting here for discussion instead of trac. Thanks, - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278

2 7

Re: [RCD] suggested new features
by Matee Moshkovits 28 Aug '13

28 Aug '13

hi guys COR BOSMAN WROTE: > THIS COULD BE DONE WITH A PLUGIN. AND I EVEN THINK THERE ALREADY IS A PLUGIN FOR THAT? > OR DOESNT LARRY HAVE HOOKS FOR A SPOT TO PUT THE REMEMBER ME HTML? > > COR I tried Larry it looks good but I can not find the hook, also that assumes that people are not using other skins and that all Admins are PHP smart to enable the hook as well as install plugins I was thinking of having it as an admin config thing .... config.php so it will exist on every skin and be idiot proof ARNE BERGLUND WROTE: > How is this different than the built-in option for browser auth caching? > > // Allow browser-autocompletion on login form. > // 0 - disabled, 1 - username and host only, 2 - username, host, > password > $rcmail_config['login_autocomplete'] = 0; > > -- > Arne Berglund > System Administrator, Internet Services > Lane Education Service District > Eugene, OR not all browsers have a good working auto-complete, (Internet Exploder 6.0 - 8.0, Opera (All versions), Android Browser (pre: Ice Cream Sandwitch)) and of those that do, how many people think that remember my password is a bad idea ... this gives a choice where it only does the username ... and not the password .... so if the admin has browser auth caching turned off (obviously a security aware admin) it still works ... -- If you have any questions, please do not hesitate to contact our office. Thank you Matee Moshkovits Chief Technology Officer AffordHost Inc. Tel: 416-238-7698 ext. 225 E-mail: mmmoshko(a)affordhost.com

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev