Dev

dev@lists.roundcube.net

4291 discussions

Rate limiting plugin
by David Carter 17 Feb '13

17 Feb '13

Good morning, I'm a Roundcube newbie who is currently working on some minor plugins to adapt Roundcube to our needs. One of our requirements is the ability to disable outgoing mail on accounts compromised by spammers after someone falls for a phishing spam. The attached plugin is close to what I need, other than the fact that the user doesn't get any feedback to indicate that email has been disabled. Should I be using something other than rcmail::raise_error() to stop Roundcube in its tracks and generate an error page? Thanks, -- David Carter Email: David.Carter(a)ucs.cam.ac.uk University Computing Service, Phone: (01223) 334502 New Museums Site, Pembroke Street, Fax: (01223) 334679 Cambridge UK. CB2 3QH. /* ================================================================== */ class hermes_ratelimit extends rcube_plugin { public $task = 'mail'; private $max_recipients = 1000; public function init() { $this->add_hook('message_before_send', array($this, 'message_before_send')); } public function message_before_send($p) { $username = $_SESSION['username']; # XXX Should check if $username compromised in previous login session here. $mailto = $p['mailto']; $recips = explode(",", $mailto); $count = count($recips); if (isset($_SESSION['recip_count'])) { $_SESSION['recip_count'] = $_SESSION['recip_count'] + $count; } else { $_SESSION['recip_count'] = $count; } if ($_SESSION['recip_count'] >= $this->max_recipients) { error_log("hermes_ratelimit: " . $username . " reached limit of " . $this->max_recipients); # XXX Should add $username to database blacklist here rcmail::raise_error (array('code' => 800, 'type' => 'smtp', 'message' => "Compromised account? Outgoing email disabled!" ), true, true); } } }

2 2

Reply-To entered in identity being overwritten upon adding another address
by Michael Heydekamp 02 Feb '13

02 Feb '13

It's a bit unfortunate that any Cc, Bcc and Reply-To addresses entered in an identity are still not shown in the compose window (so that you can never be 100% sure if the respective headers are filled correctly), but I just encountered an even more serious issue: Unlike to Cc and Bcc, where I can manually add any other addresses while the ones entered in the identity are being preserved, any address added to the Reply-To field is not really "additional": It does overwrite the ones defined in the identity. Of course, I realized that only AFTER I sent the message... I request to correct this (and furthermore, I request to display all addresses being defined in the identity). I'm fully aware that it may get somewhat complicated if you're switching identies in the compose window back and forth (to distinguish between manually added addresses and addresses being defined in the identity...). But anyway, to display all of them would instantly disclose any problems and the user would at least have the chance to correct them manually. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 3

Display of message flowed, although message not being declared as flowed
by Michael Heydekamp 01 Feb '13

01 Feb '13

For a number of good reasons, I usually do not produce messages in "format=flowed". Roundcube (hopefully unintentional) seems to ignore my intention, as it does display EVERY message as it would be in "format=flowed" upon reading it. Specifically: Resizing the window also leads to a line-rewrapping, which is continously adapted to the current window size. This breaks the display of things such as tables, charts, ASCII-Art etc., and makes them pretty unreadable. But exactly these things are the reason why I want to avoid "format=flowed". This format may make some sense if a message contains nothing but "flowing" text (but even then I find those extremely long lines difficult to read), but you can't take it for granted that a message does not contain anything else but "flowing" text. May I request to limit this behaviour to messages which are explicitely declared as "format=flowed", but to avoid it for messages not being declared as such? Technically this is possible, as I just verified. ;) Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 6

Kolab calendar plugin: no notifications
by Rob Sheldon 31 Jan '13

31 Jan '13

Hate to bug the mailing list with this, but I spent several hours going through the code & Google, and I'm stumped. I'm running 0.8.4, I'm trying to get the Kolab calendar plugin working because it looks pretty slick. Latest version of that available for download seems to be v0.7.4, except for a v3.0.1. I can't tell which one (if either) is correct for 0.8.4, but 3.0.1 complained immediately about a missing rcube class, so I fell back to 0.7.4 which mostly works (after you copy the skins in from v3.0.1). The only problem it seems to be having is that no notifications are going out for events. I would assume that it needs to be tied in to some kind of cron job (or...?), but I don't see a reasonable-looking candidate for that, nor have I been able to sort out how the notifications system is supposed to work. I see events being added to the events table in MySQL, everything looks reasonable there, but I can't find anything responsible for handling them once they're in there. What am I missing? The docs are pretty thin. I'd be happy to help with either code / documentation if necessary. Thanks, - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278

5 9

Re: [RCD] [Svn] [roundcube/roundcubemail] b3bbb2: Add addressbook widget on compose page in classic skin
by Michael Heydekamp 30 Jan '13

30 Jan '13

Great - thanks for that, Alec! There are a few issues, though: 1) In cases where more than just one mail address is assigned to an address book entry, Larry is displaying the addresses right next to the real name in italics. Can we have the same in Classic as well? Or, alternatively, display them in angle brackets? Or even both (which would be the best option IMO, also for Larry)? 2) Clicking on the down arrow of the spell check button leads to a "hidden" list of available languages (hidden behind the search field). See screenshot attached. Wouldn't it be better to move all those buttons to the right anyway (so that they are aligned with the text composing field)? 3) As we now need more horizontal space on the screen than before, I'm still struggling to convince IE8 to open a wider window when I'm replying in a new window (which is my preferred option). Any idea how I can do that, or might Roundcube be able to set the window size? Anyway, you fulfilled one of my most important wishes, so thanks again. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 27.01.2013 13:17, schrieb GitHub: > Branch: refs/heads/release-0.9 > Home: https://github.com/roundcube/roundcubemail > Commit: b3bbb281002386f6cedf5b6f007074ecbfc96f5b > > https://github.com/roundcube/roundcubemail/commit/b3bbb281002386f6cedf5b6f0… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-01-27 (Sun, 27 Jan 2013) > > Changed paths: > M CHANGELOG > M skins/classic/addressbook.css > M skins/classic/functions.js > M skins/classic/googiespell.css > M skins/classic/ie6hacks.css > M skins/classic/iehacks.css > M skins/classic/images/icons/groupactions.gif > M skins/classic/images/icons/groupactions.png > M skins/classic/mail.css > M skins/classic/splitter.js > M skins/classic/templates/compose.html > > Log Message: > ----------- > Add addressbook widget on compose page in classic skin > > > Commit: b0cc5519d74ac50a2c01b8106f9afa43357ccb48 > > https://github.com/roundcube/roundcubemail/commit/b0cc5519d74ac50a2c01b8106… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-01-27 (Sun, 27 Jan 2013) > > Changed paths: > M skins/classic/mail.css > M skins/classic/templates/mail.html > > Log Message: > ----------- > Small fix to initial splitter position > > > Compare: > https://github.com/roundcube/roundcubemail/compare/a8fd895263d6...b0cc5519d… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 2

Attaching text files and charset declaration
by Michael Heydekamp 29 Jan '13

29 Jan '13

To make sure that a text file attached to a message will be displayed correctly at the recipient's end, it requires a correct charset declaration. Currently I don't see any chance to declare a specific charset when attaching an arbitrary text file with Roundcube. AFAIK and AFAIR, mutt for instance can do that (as being stated in a Usenet newsgroup longer ago, I did never use mutt myself). Of course, neither Roundcube nor any other MUA can guess the correct charset. The user attaching the file needs to know (and declare) it. Any hope that this will be possible in the nearer future? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

redirection loop when cookies are disabled
by Sébastien BLAISOT 29 Jan '13

29 Jan '13

Hi, I've juste noticed with RC 0.9b and RC 0.8.4 that when cookies are disabled on browser side (tested with FF and chrome), I get a redirection loop (302 redirect) on /?_task=mail This is not very user-friendly, it would be better to show a nice error page. Can somebody confirm what I've noted before I fill in a bug report or is it only related to my installation ? regards, S. Blaisot

1 1

Replies to HTML messages
by Michael Heydekamp 27 Jan '13

27 Jan '13

I have set "Compose HTML messages" to "Never", because that is what I want. I'm a bit confused with regards to plain text replies to messages with a text/html and a text/plain part. Roundcube often (but not always) seems to quote the text/html part rather than the text/plain part. This often leads to really ugly replies/quotes with tons of useless/duplicated links at the end of the message (while the links within the message are sometimes being removed). See message attached. Is this intentional...? (Well, hopefully not) If replying to a HTML only message, Roundcube has of course no other choice than replying to the HTMl part. But in this case I'm still wondering why all links contained in the message are being duplicated at the end of the message with "[1]", "[2]" and so on, and sometimes even being removed within the message text (as can be seen with the attached message). It's a bit of an annoyance to remove these links at the end of the message and the "[1]", "[2]" etc. within the message text. Furthermore, the option "Compose HTML messages" has apparently four options now, the last one ("on forward or reply to HTML message") not being localized (yet?) Or is it a duplicate to "on reply to HTML message only"?. Last but not least, in very few and exceptional cases I'd indeed like to compose a HTML message when replying to a HTML message. Currently I see no other way than to change the option "Compose HTML messages", create the reply, and then reset "Compose HTML messages" back to "Never" (which I then sometimes forget, of course, and which is not too comfortable). Of course I can change the editor type AFTER clicking the reply button, but then all HTML tags of the quoted message are still lost. I currently have no good idea for a UI for this, but a function to reload the HTML part into the message editor (or to load the HTML part upfront after the user has - in which way ever - clearly stated that he exceptionally wants to create a HTML message) would just be great. Regards, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 15

Announcing: OpenPGP finally brought to Roundcube
by Niklas Femerstrand 20 Jan '13

20 Jan '13

Whazzup, I just released the beta of my plugin that implements OpenPGP into Roundcube through JavaScript by using the OpenPGP.js library. Github repo available here <https://github.com/qnrq/rc_openpgpjs> and announcement here <http://qnrq.se/rc_openpgpjs_ending_seven_years_of_roundcube_insecurity/>. Expect a stable release as soon as I have regulated my dopamine levels; or rather, as soon as I have fixed these <https://github.com/qnrq/rc_openpgpjs/issues?milestone=1&page=1&state=open> minor issues. I'm estimating it'll take /at most/ one or two weeks to finalize the stable version. In the meantime we can handle the political discussions that this may stir up. Please ennjoy it, mah homiez! /qnrq

4 5

Re: [RCD] hack tracker
by Sébastien BLAISOT 18 Jan '13

18 Jan '13

forwarding this to the list for archives, this could be interesting to others. regards, S.B. -------- Message original -------- Sujet: Re: [RCD] hack tracker Date : Sat, 19 Jan 2013 00:28:10 +0100 De : Sébastien BLAISOT <sebastien(a)blaisot.org> Pour : 3072019751(a)linuxmail.org Le 18/01/2013 09:38, 3072019751(a)linuxmail.org a écrit : >>> How to submit a request for a "time of previous login session"/"ip of previous login session" feature? >> hi, >> >> Maybe you can have a look at to the following request : >> http://trac.roundcube.net/ticket/1488847 >> >> and this plugin that can display the previous login time : >> https://github.com/sblaisot/roundcube-topline > Thanks a lot, > just a detail, would it work for rc0.7.3? Well, this plugin can't work with rc0.7.3 for two reasons : * It has been designed for larry skin only at the moment, which is only available starting from rc 0.8 * It needs some containers that are only present in the larry skin starting from rc 0.9-beta but the logic behind it for getting the time of previous session login and storing it in the user session should be applicable. in short : 1) register to login_after hook in the initialization of your plugin $this->add_hook('login_after', array($this, 'store_lastlogin')); 2) store previous login time in user session on login public function store_lastlogin($p) { $rcmail = rcmail::get_instance(); $user = $rcmail->user; $_SESSION['lastlogin'] = $user->data['last_login']; return $p; } 3) use stored data for whatever you want $my_wonderful_variable = $_SESSION['lastlogin']; regards, S.B.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev